diff mbox series

[1/1] package/libgee: needs gcc >= 4.9

Message ID 20220317190027.183976-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/libgee: needs gcc >= 4.9 | expand

Commit Message

Fabrice Fontaine March 17, 2022, 7 p.m. UTC
Fix the following build failure raised since bump to version 0.20.5
in commit 10780e8d6df83d7a92b6dd3282e91fdc0ba369af and
https://gitlab.gnome.org/GNOME/libgee/-/commit/f0ccfe94ff731929e93601a38f931a12d52e5c2e:

task.c:59:1: error: initializer element is not constant
 static GOnce gee_task_data_async_pool = (GOnce) G_ONCE_INIT;
 ^

Fixes:
 - http://autobuild.buildroot.org/results/8354ea4192bcf2eb9c3be74d93b640db52ced10a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/granite/Config.in | 6 ++++--
 package/libgee/Config.in  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

Comments

Arnout Vandecappelle March 27, 2022, 3:35 p.m. UTC | #1
On 17/03/2022 20:00, Fabrice Fontaine wrote:
> Fix the following build failure raised since bump to version 0.20.5
> in commit 10780e8d6df83d7a92b6dd3282e91fdc0ba369af and
> https://gitlab.gnome.org/GNOME/libgee/-/commit/f0ccfe94ff731929e93601a38f931a12d52e5c2e:
> 
> task.c:59:1: error: initializer element is not constant
>   static GOnce gee_task_data_async_pool = (GOnce) G_ONCE_INIT;
>   ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/8354ea4192bcf2eb9c3be74d93b640db52ced10a
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/granite/Config.in | 6 ++++--
>   package/libgee/Config.in  | 6 ++++--
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/package/granite/Config.in b/package/granite/Config.in
> index 726bde1b2d..9519e16d45 100644
> --- a/package/granite/Config.in
> +++ b/package/granite/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_GRANITE
>   	depends on BR2_USE_WCHAR
>   	depends on BR2_TOOLCHAIN_HAS_THREADS
>   	depends on BR2_USE_MMU # fork()
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libgee
>   	depends on BR2_PACKAGE_LIBGTK3
>   	select BR2_PACKAGE_LIBGEE
>   	select BR2_PACKAGE_LIBGLIB2
> @@ -12,7 +13,8 @@ config BR2_PACKAGE_GRANITE
>   
>   	  https://github.com/elementary/granite
>   
> -comment "granite needs libgtk3 and a toolchain w/ wchar, threads"
> +comment "granite needs libgtk3 and a toolchain w/ wchar, threads, gcc >= 4.9"
>   	depends on BR2_USE_MMU
>   	depends on !BR2_PACKAGE_LIBGTK3 || !BR2_USE_WCHAR \
> -		|| !BR2_TOOLCHAIN_HAS_THREADS
> +		|| !BR2_TOOLCHAIN_HAS_THREADS \
> +		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> diff --git a/package/libgee/Config.in b/package/libgee/Config.in
> index 07c387c985..cb33ec9ec2 100644
> --- a/package/libgee/Config.in
> +++ b/package/libgee/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGEE
>   	depends on BR2_USE_WCHAR
>   	depends on BR2_TOOLCHAIN_HAS_THREADS
>   	depends on BR2_USE_MMU # fork()
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>   	select BR2_PACKAGE_LIBGLIB2
>   	help
>   	  Libgee is an utility library providing GObject-based
> @@ -10,6 +11,7 @@ config BR2_PACKAGE_LIBGEE
>   
>   	  https://wiki.gnome.org/Projects/Libgee
>   
> -comment "libgee needs a toolchain w/ wchar, threads"
> +comment "libgee needs a toolchain w/ wchar, threads, gcc >= 4.9"
>   	depends on BR2_USE_MMU
> -	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
Peter Korsgaard March 30, 2022, 5:19 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fix the following build failure raised since bump to version 0.20.5
 > in commit 10780e8d6df83d7a92b6dd3282e91fdc0ba369af and
 > https://gitlab.gnome.org/GNOME/libgee/-/commit/f0ccfe94ff731929e93601a38f931a12d52e5c2e:

 > task.c:59:1: error: initializer element is not constant
 >  static GOnce gee_task_data_async_pool = (GOnce) G_ONCE_INIT;
 >  ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/8354ea4192bcf2eb9c3be74d93b640db52ced10a

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.
diff mbox series

Patch

diff --git a/package/granite/Config.in b/package/granite/Config.in
index 726bde1b2d..9519e16d45 100644
--- a/package/granite/Config.in
+++ b/package/granite/Config.in
@@ -3,6 +3,7 @@  config BR2_PACKAGE_GRANITE
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libgee
 	depends on BR2_PACKAGE_LIBGTK3
 	select BR2_PACKAGE_LIBGEE
 	select BR2_PACKAGE_LIBGLIB2
@@ -12,7 +13,8 @@  config BR2_PACKAGE_GRANITE
 
 	  https://github.com/elementary/granite
 
-comment "granite needs libgtk3 and a toolchain w/ wchar, threads"
+comment "granite needs libgtk3 and a toolchain w/ wchar, threads, gcc >= 4.9"
 	depends on BR2_USE_MMU
 	depends on !BR2_PACKAGE_LIBGTK3 || !BR2_USE_WCHAR \
-		|| !BR2_TOOLCHAIN_HAS_THREADS
+		|| !BR2_TOOLCHAIN_HAS_THREADS \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
diff --git a/package/libgee/Config.in b/package/libgee/Config.in
index 07c387c985..cb33ec9ec2 100644
--- a/package/libgee/Config.in
+++ b/package/libgee/Config.in
@@ -3,6 +3,7 @@  config BR2_PACKAGE_LIBGEE
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  Libgee is an utility library providing GObject-based
@@ -10,6 +11,7 @@  config BR2_PACKAGE_LIBGEE
 
 	  https://wiki.gnome.org/Projects/Libgee
 
-comment "libgee needs a toolchain w/ wchar, threads"
+comment "libgee needs a toolchain w/ wchar, threads, gcc >= 4.9"
 	depends on BR2_USE_MMU
-	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9