| Message ID | 20220128110542.1101197-2-giulio.benetti@benettiengineering.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | package/libcamera: fix missing comment for binutils-bug-27597 | expand |
Giulio, All, On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly: > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > package/libcamera/Config.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in > index 23a0040abf..88db054975 100644 > --- a/package/libcamera/Config.in > +++ b/package/libcamera/Config.in > @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads > > endif # BR2_PACKAGE_LIBCAMERA > > -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" > +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" Bug 27597 is inherently an architecture-speific bug, which is always set for NIOS2, so there is nothing the user can do about it except switch to another architecture... The comments are meant for when the user has an alternative option, like chossing a different version of a component. In this case, there is nothing the user can do, so we don't add it to the comment. Regards, Yann E. MORIN. > depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS > depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ > !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR > -- > 2.25.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
On 12/02/22 17:49, Yann E. MORIN wrote: > Giulio, All, > > On 2022-01-28 12:05 +0100, Giulio Benetti spake thusly: >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> >> --- >> package/libcamera/Config.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in >> index 23a0040abf..88db054975 100644 >> --- a/package/libcamera/Config.in >> +++ b/package/libcamera/Config.in >> @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads >> >> endif # BR2_PACKAGE_LIBCAMERA >> >> -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" >> +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" > > Bug 27597 is inherently an architecture-speific bug, which is always set > for NIOS2, so there is nothing the user can do about it except switch to > another architecture... > > The comments are meant for when the user has an alternative option, like > chossing a different version of a component. > > In this case, there is nothing the user can do, so we don't add it to > the comment. Aaah, right, like hidden options. Ok, so let's drop this patch. Thank you! Best regards
diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in index 23a0040abf..88db054975 100644 --- a/package/libcamera/Config.in +++ b/package/libcamera/Config.in @@ -92,7 +92,7 @@ comment "lc-compliance test application needs a toolchain w/ C++, wchar, threads endif # BR2_PACKAGE_LIBCAMERA -comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7" +comment "libcamera needs a toolchain w/ C++, threads, wchar, dynamic library, gcc >= 7, not binutils bug 27597" depends on BR2_PACKAGE_LIBCAMERA_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || BR2_STATIC_LIBS || !BR2_USE_WCHAR
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- package/libcamera/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)