| Message ID | 20220118104338.2081259-26-giulio.benetti@benettiengineering.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | Use the best FPU strategies on 32-bits Arm Cortex | expand |
18.01.2022 13:43, Giulio Benetti: > This board has Allwinner H2+(compatible with H3) that is a cortex-A7 and > supports NEON/VFPV4 FPU strategy, so let's enable it instead of only VFPV4. > > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > --- > configs/orangepi_zero_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig > index 1c107b10e6..a0af809e92 100644 > --- a/configs/orangepi_zero_defconfig > +++ b/configs/orangepi_zero_defconfig > @@ -1,6 +1,6 @@ > BR2_arm=y > BR2_cortex_a7=y > -BR2_ARM_FPU_VFPV4=y > +BR2_ARM_FPU_NEON_VFPV4=y > BR2_GLOBAL_PATCH_DIR="board/orangepi/orangepi-zero/patches" > BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y > BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_12=y Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com>
Hi Sergey, thank you for the Tested-by, but you should put it… > Il giorno 23 gen 2022, alle ore 19:08, Sergey Kuzminov <kuzminov.sergey81@gmail.com> ha scritto: > > 18.01.2022 13:43, Giulio Benetti: >> This board has Allwinner H2+(compatible with H3) that is a cortex-A7 and >> supports NEON/VFPV4 FPU strategy, so let's enable it instead of only VFPV4. >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> …here, after my SoB. And when answering to Mailing List(ML), always use “Reply to All”. Honestly it’s since years I always use “Reply to All” because it works both for multiple recipients and for single recipient too. This way I don’t forget to do it. Best regards! Giulio >> --- >> configs/orangepi_zero_defconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig >> index 1c107b10e6..a0af809e92 100644 >> --- a/configs/orangepi_zero_defconfig >> +++ b/configs/orangepi_zero_defconfig >> @@ -1,6 +1,6 @@ >> BR2_arm=y >> BR2_cortex_a7=y >> -BR2_ARM_FPU_VFPV4=y >> +BR2_ARM_FPU_NEON_VFPV4=y >> BR2_GLOBAL_PATCH_DIR="board/orangepi/orangepi-zero/patches" >> BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y >> BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_12=y > > Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com> > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Giulio, All, On 2022-01-23 20:12 +0100, Giulio Benetti spake thusly: > Hi Sergey, > > thank you for the Tested-by, but you should put it… > > > Il giorno 23 gen 2022, alle ore 19:08, Sergey Kuzminov <kuzminov.sergey81@gmail.com> ha scritto: > > > > 18.01.2022 13:43, Giulio Benetti: > >> This board has Allwinner H2+(compatible with H3) that is a cortex-A7 and > >> supports NEON/VFPV4 FPU strategy, so let's enable it instead of only VFPV4. > >> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > …here, after my SoB. No, not needed: Patchwork will correctly catch it wherever it is as long as the mail is a proper reply, which it is here, and you can check it on patchwork: the 'T' column is now set to '1' for this patch, and the tested-by tag is properly added to the mbox (which is what we maintainers use when applying patches): $ curl 'https://patchwork.ozlabs.org/project/buildroot/patch/20220118104338.2081259-26-giulio.benetti@benettiengineering.com/mbox/' [...] Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Tested-by: Sergey Kuzminov <kuzminov.sergey81@gmail.com> [...] Regards, Yann E. MORIN.
diff --git a/configs/orangepi_zero_defconfig b/configs/orangepi_zero_defconfig index 1c107b10e6..a0af809e92 100644 --- a/configs/orangepi_zero_defconfig +++ b/configs/orangepi_zero_defconfig @@ -1,6 +1,6 @@ BR2_arm=y BR2_cortex_a7=y -BR2_ARM_FPU_VFPV4=y +BR2_ARM_FPU_NEON_VFPV4=y BR2_GLOBAL_PATCH_DIR="board/orangepi/orangepi-zero/patches" BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_12=y
This board has Allwinner H2+(compatible with H3) that is a cortex-A7 and supports NEON/VFPV4 FPU strategy, so let's enable it instead of only VFPV4. Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com> --- configs/orangepi_zero_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)