diff mbox series

configs/kontron_smarc_sal28: move gpt between rcw and bootloader

Message ID 20211227105550.916883-1-michael@walle.cc
State Accepted
Headers show
Series configs/kontron_smarc_sal28: move gpt between rcw and bootloader | expand

Commit Message

Michael Walle Dec. 27, 2021, 10:55 a.m. UTC
genimage v15 complains about the GPT overlapping with the RCW. Move it
to offset 16k which is between the rcw (which isn't expected to grow
much more) and the bootloader.

This will fix the following error:
ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.

Signed-off-by: Michael Walle <michael@walle.cc>
---

Please note, that this patch applies on top of
https://lore.kernel.org/buildroot/20211219142035.6220-2-peter@korsgaard.com/

 board/kontron/smarc-sal28/genimage.cfg | 1 +
 1 file changed, 1 insertion(+)

Comments

Giulio Benetti Dec. 27, 2021, 11:13 a.m. UTC | #1
Hi Michael, All,

On 27/12/21 11:55, Michael Walle wrote:
> genimage v15 complains about the GPT overlapping with the RCW. Move it
> to offset 16k which is between the rcw (which isn't expected to grow
> much more) and the bootloader.
> 
> This will fix the following error:
> ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
> ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
Thomas Petazzoni Dec. 27, 2021, 2:44 p.m. UTC | #2
On Mon, 27 Dec 2021 11:55:50 +0100
Michael Walle <michael@walle.cc> wrote:

> genimage v15 complains about the GPT overlapping with the RCW. Move it
> to offset 16k which is between the rcw (which isn't expected to grow
> much more) and the bootloader.
> 
> This will fix the following error:
> ERROR: hdimage(sdcard-emmc.img): partition [GPT array] (offset 0x400, size 0x4000) overlaps previous partition rcw (offset 0x1000, size 0x580)
> ERROR: hdimage(sdcard-emmc.img): bootloaders, etc. that overlap with the partition table must declare the overlapping area as a hole.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/board/kontron/smarc-sal28/genimage.cfg b/board/kontron/smarc-sal28/genimage.cfg
index 0ad020b347..c885cd51a6 100644
--- a/board/kontron/smarc-sal28/genimage.cfg
+++ b/board/kontron/smarc-sal28/genimage.cfg
@@ -1,6 +1,7 @@ 
 image sdcard-emmc.img {
 	hdimage {
 		partition-table-type = "gpt"
+		gpt-location = 16K
 	}
 
 	partition rcw {