| Message ID | 20211119175553.2413433-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
| Series | [v2,1/2] Revert "package/log4cxx: select boost chrono and date-time with gcc < 7" | expand |
On Fri, 19 Nov 2021 18:55:52 +0100 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > these selects on boost side as the build failure was raised with gcc >= > 7 (making this commit a "no-op"). Indeed, the build failure is raised > with cmake < 3.21.3, because cmake assumed that boost thread depends on > date-time until > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. I don't understand why you say this commit is a no-op. It clearly isn't. In gcc < 7.x configurations, this commit ensures that boost chrono and boost date-time are selected. The fact that you realize later that the build failure occurred with gcc >= 7.x, meaning this commit does not help fixing the issue does not make this commit a no-op. Thomas
Hello Fabrice, On Sun, 21 Nov 2021 14:57:41 +0100 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > On Fri, 19 Nov 2021 18:55:52 +0100 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > these selects on boost side as the build failure was raised with gcc >= > > 7 (making this commit a "no-op"). Indeed, the build failure is raised > > with cmake < 3.21.3, because cmake assumed that boost thread depends on > > date-time until > > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. > > I don't understand why you say this commit is a no-op. It clearly > isn't. In gcc < 7.x configurations, this commit ensures that boost > chrono and boost date-time are selected. > > The fact that you realize later that the build failure occurred with > gcc >= 7.x, meaning this commit does not help fixing the issue does not > make this commit a no-op. Do you have some feedback/comment on the above questions? Thanks! Thomas
Hello Thomas, Le jeu. 13 janv. 2022 à 23:14, Thomas Petazzoni <thomas.petazzoni@bootlin.com> a écrit : > > Hello Fabrice, > > On Sun, 21 Nov 2021 14:57:41 +0100 > Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > > On Fri, 19 Nov 2021 18:55:52 +0100 > > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > > > > This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move > > > these selects on boost side as the build failure was raised with gcc >= > > > 7 (making this commit a "no-op"). Indeed, the build failure is raised > > > with cmake < 3.21.3, because cmake assumed that boost thread depends on > > > date-time until > > > https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. > > > > I don't understand why you say this commit is a no-op. It clearly > > isn't. In gcc < 7.x configurations, this commit ensures that boost > > chrono and boost date-time are selected. > > > > The fact that you realize later that the build failure occurred with > > gcc >= 7.x, meaning this commit does not help fixing the issue does not > > make this commit a no-op. > > Do you have some feedback/comment on the above questions? Indeed, this is not a no-op so I suggest to only apply the second patch of the serie. > > Thanks! > > Thomas > -- > Thomas Petazzoni, co-owner and CEO, Bootlin > Embedded Linux and Kernel engineering and training > https://bootlin.com Best Regards, Fabrice
diff --git a/package/log4cxx/Config.in b/package/log4cxx/Config.in index 27a5f06988..6f1956f829 100644 --- a/package/log4cxx/Config.in +++ b/package/log4cxx/Config.in @@ -12,8 +12,6 @@ config BR2_PACKAGE_LOG4CXX select BR2_PACKAGE_APR_UTIL select BR2_PACKAGE_BOOST if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_PACKAGE_BOOST_ATOMIC if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 - select BR2_PACKAGE_BOOST_CHRONO if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 - select BR2_PACKAGE_BOOST_DATE_TIME if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 select BR2_PACKAGE_BOOST_THREAD if !BR2_TOOLCHAIN_GCC_AT_LEAST_7 help Apache log4cxx is a logging framework for C++ patterned
This reverts commit 3c2245cb65741c965f4bb87d35ac3c64f250a1ae to move these selects on boost side as the build failure was raised with gcc >= 7 (making this commit a "no-op"). Indeed, the build failure is raised with cmake < 3.21.3, because cmake assumed that boost thread depends on date-time until https://github.com/Kitware/CMake/commit/1ad0c5ae53fc0c4f774166337f0e9c93c578cf9b. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- Changes v1 -> v2 (after review of Yann E. Morin): - Update commuit message to explain that this commit is a no-op and the relationship with cmake package/log4cxx/Config.in | 2 -- 1 file changed, 2 deletions(-)