| Message ID | 20211018195822.2263226-1-arnout@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] tests: sample_python_dbus_next: ignore F821 flake8 error | expand |
Arnout, All, On 2021-10-18 21:58 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly: > The dbus-next package uses the Python type annotation for dbus types. This is > not compatible with the python typing assumption that flake8 makes. > > Exclude F821 from this line. > > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829 > partially: > support/testing/tests/package/sample_python_dbus_next.py:17:36: F821 undefined name 's' > support/testing/tests/package/sample_python_dbus_next.py:17:48: F821 undefined name 's' > support/testing/tests/package/sample_python_dbus_next.py:17:56: F821 undefined name 's' > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> You beat me to it, but I still managed to put my little touch: I've changed the title to: support/testing: ... Applied to master, thanks. Regards, Yann E. MORIN. > --- > support/testing/tests/package/sample_python_dbus_next.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/support/testing/tests/package/sample_python_dbus_next.py b/support/testing/tests/package/sample_python_dbus_next.py > index 1fcb76f45a..710bfa8c04 100644 > --- a/support/testing/tests/package/sample_python_dbus_next.py > +++ b/support/testing/tests/package/sample_python_dbus_next.py > @@ -14,7 +14,7 @@ class SampleInterface(ServiceInterface): > pass > > @method() > - def ConcatStrings(self, what1: 's', what2: 's') -> 's': > + def ConcatStrings(self, what1: 's', what2: 's') -> 's': # noqa: F821 > return what1 + what2 > > > -- > 2.31.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes: > The dbus-next package uses the Python type annotation for dbus types. This is > not compatible with the python typing assumption that flake8 makes. > Exclude F821 from this line. > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829 > partially: > support/testing/tests/package/sample_python_dbus_next.py:17:36: F821 undefined name 's' > support/testing/tests/package/sample_python_dbus_next.py:17:48: F821 undefined name 's' > support/testing/tests/package/sample_python_dbus_next.py:17:56: F821 undefined name 's' Committed to 2021.08.x, thanks.
diff --git a/support/testing/tests/package/sample_python_dbus_next.py b/support/testing/tests/package/sample_python_dbus_next.py index 1fcb76f45a..710bfa8c04 100644 --- a/support/testing/tests/package/sample_python_dbus_next.py +++ b/support/testing/tests/package/sample_python_dbus_next.py @@ -14,7 +14,7 @@ class SampleInterface(ServiceInterface): pass @method() - def ConcatStrings(self, what1: 's', what2: 's') -> 's': + def ConcatStrings(self, what1: 's', what2: 's') -> 's': # noqa: F821 return what1 + what2
The dbus-next package uses the Python type annotation for dbus types. This is not compatible with the python typing assumption that flake8 makes. Exclude F821 from this line. Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/1687009829 partially: support/testing/tests/package/sample_python_dbus_next.py:17:36: F821 undefined name 's' support/testing/tests/package/sample_python_dbus_next.py:17:48: F821 undefined name 's' support/testing/tests/package/sample_python_dbus_next.py:17:56: F821 undefined name 's' Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- support/testing/tests/package/sample_python_dbus_next.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)