diff mbox series

[1/1] package/python3: fix bzip2 build

Message ID 20211017200558.1409403-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/python3: fix bzip2 build | expand

Commit Message

Fabrice Fontaine Oct. 17, 2021, 8:05 p.m. UTC
Fix the following build failure raised since commit
21a56f9edbca8dd8b19567be6be2b32e44ebb860 which wrongly removed
the select on BR2_PACKAGE_BZIP2 from BR2_PACKAGE_PYTHON3_BZIP2:

Makefile:587: *** bzip2 is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/041a2f9c536fce1a1acf6da0464855e4f1e1604f

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/python3/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Oct. 18, 2021, 7:52 p.m. UTC | #1
On Sun, 17 Oct 2021 22:05:58 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix the following build failure raised since commit
> 21a56f9edbca8dd8b19567be6be2b32e44ebb860 which wrongly removed
> the select on BR2_PACKAGE_BZIP2 from BR2_PACKAGE_PYTHON3_BZIP2:
> 
> Makefile:587: *** bzip2 is in the dependency chain of python3 that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/041a2f9c536fce1a1acf6da0464855e4f1e1604f
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/python3/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Indeed, there's been a misunderstanding. Arnout asked to drop the
"select BR2_PACKAGE_HOST_BZIP2" from package/python3/Config.in.host,
but Adam removed the "select BR2_PACKAGE_BZIP2" from
package/python3/Config.in instead, and Arnout didn't spot the mistake
when applying.

Anyway, I've applied your patch, and did another to drop the bogus
select BR2_PACKAGE_HOST_BZIP2. Thanks for fixing this!

Thomas
diff mbox series

Patch

diff --git a/package/python3/Config.in b/package/python3/Config.in
index 18b6d6367b..efc4dbb3d4 100644
--- a/package/python3/Config.in
+++ b/package/python3/Config.in
@@ -54,6 +54,7 @@  config BR2_PACKAGE_PYTHON3_BERKELEYDB
 
 config BR2_PACKAGE_PYTHON3_BZIP2
 	bool "bz2 module"
+	select BR2_PACKAGE_BZIP2
 	help
 	  bzip2 module for Python3