diff mbox series

[v2] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20

Message ID 20211015081601.2472850-1-giulio.benetti@benettiengineering.com
State Accepted
Headers show
Series [v2] package/sunxi-mali-mainline-driver: update help section to make it work on Linux >= 4.20 | expand

Commit Message

Giulio Benetti Oct. 15, 2021, 8:16 a.m. UTC
On Linux version >= 4.20 in order to have mali working we need to pass
drm_kms_helper.drm_leak_fbdev_smem=1 and at least
drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
V1->V2:
* add double buffer too
---
 package/sunxi-mali-mainline-driver/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni Oct. 18, 2021, 7:47 p.m. UTC | #1
On Fri, 15 Oct 2021 10:16:01 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> On Linux version >= 4.20 in order to have mali working we need to pass
> drm_kms_helper.drm_leak_fbdev_smem=1 and at least
> drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> V1->V2:
> * add double buffer too
> ---
>  package/sunxi-mali-mainline-driver/Config.in | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to master with some reformatting tweaks. Thanks!

Thomas
Peter Korsgaard Oct. 25, 2021, 11:20 a.m. UTC | #2
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > On Linux version >= 4.20 in order to have mali working we need to pass
 > drm_kms_helper.drm_leak_fbdev_smem=1 and at least
 > drm_kms_helper.drm_fbdev_overalloc=200 to have a double buffer fbdev.

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x and 2021.08.x, thanks.
diff mbox series

Patch

diff --git a/package/sunxi-mali-mainline-driver/Config.in b/package/sunxi-mali-mainline-driver/Config.in
index 5db66c5bf6..bd6819cf82 100644
--- a/package/sunxi-mali-mainline-driver/Config.in
+++ b/package/sunxi-mali-mainline-driver/Config.in
@@ -25,5 +25,11 @@  config BR2_PACKAGE_SUNXI_MALI_MAINLINE_DRIVER
 	  starting from Linux Kernel >= 4.20 following options must be
 	  enabled:
 	  - CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
+	  and following kernel command-line must be passed:
+	  `drm_kms_helper.drm_leak_fbdev_smem = 1`
+	  since drm_kms_helper.drm_leak_fbdev_smem is set to 0 by default
+	  `drm_kms_helper.drm_fbdev_overalloc >= 200`
+	  since the driver requires at least double buffering and fails to
+	  work with the default value(100).
 
 	  https://github.com/mripard/sunxi-mali/blob/master/README.md