diff mbox series

configs/olimex_a20_olinuxino: fix mali not working because Linux version >= 4.20

Message ID 20211014213630.2436055-1-giulio.benetti@benettiengineering.com
State Changes Requested
Headers show
Series configs/olimex_a20_olinuxino: fix mali not working because Linux version >= 4.20 | expand

Commit Message

Giulio Benetti Oct. 14, 2021, 9:36 p.m. UTC
Since on olinuxino_lime/lime2 we have a Linux version >= 4.20 we need to
pass drm_kms_helper.drm_leak_fbdev_smem=1 to kernel command-line that
really enables DRM_FBDEV_LEAK_PHYS_SMEM. CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
only adds the code for this, but drm_leak_fbdev_smem is 0 by default, so we
need to override it. This fixes both olimex_a20_olinuxino_lime and lime2
that use extlinux.conf.

Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
 .../a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Giulio Benetti Oct. 14, 2021, 10:11 p.m. UTC | #1
On 10/14/21 11:36 PM, Giulio Benetti wrote:
> Since on olinuxino_lime/lime2 we have a Linux version >= 4.20 we need to
> pass drm_kms_helper.drm_leak_fbdev_smem=1 to kernel command-line that
> really enables DRM_FBDEV_LEAK_PHYS_SMEM. CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
> only adds the code for this, but drm_leak_fbdev_smem is 0 by default, so we
> need to override it. This fixes both olimex_a20_olinuxino_lime and lime2
> that use extlinux.conf.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>   .../a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf    | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf b/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
> index f754da3623..25ee0c349c 100644
> --- a/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
> +++ b/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
> @@ -1,4 +1,4 @@
>   label Olinuxino
>       kernel /boot/zImage
>       fdtdir /boot
> -    append console=ttyS0,115200 root=/dev/mmcblk0p1 rootwait panic=10 ${extra}
> +    append console=ttyS0,115200 root=/dev/mmcblk0p1 rootwait panic=10 drm_kms_helper.drm_leak_fbdev_smem=1 ${extra}
> 

This lacks drm_kms_helper.drm_fbdev_overalloc=200 too at least. I'm 
going to send a v2 for this.

Sorry for the noise
Thomas Petazzoni Jan. 8, 2022, 8:57 p.m. UTC | #2
On Thu, 14 Oct 2021 23:36:30 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Since on olinuxino_lime/lime2 we have a Linux version >= 4.20 we need to
> pass drm_kms_helper.drm_leak_fbdev_smem=1 to kernel command-line that
> really enables DRM_FBDEV_LEAK_PHYS_SMEM. CONFIG_DRM_FBDEV_LEAK_PHYS_SMEM
> only adds the code for this, but drm_leak_fbdev_smem is 0 by default, so we
> need to override it. This fixes both olimex_a20_olinuxino_lime and lime2
> that use extlinux.conf.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  .../a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
diff mbox series

Patch

diff --git a/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf b/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
index f754da3623..25ee0c349c 100644
--- a/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
+++ b/board/olimex/a20_olinuxino/rootfs_overlay/boot/extlinux/extlinux.conf
@@ -1,4 +1,4 @@ 
 label Olinuxino
     kernel /boot/zImage
     fdtdir /boot
-    append console=ttyS0,115200 root=/dev/mmcblk0p1 rootwait panic=10 ${extra}
+    append console=ttyS0,115200 root=/dev/mmcblk0p1 rootwait panic=10 drm_kms_helper.drm_leak_fbdev_smem=1 ${extra}