Message ID | 20211014160824.2154396-1-fontaine.fabrice@gmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [1/1] package/libdbi: needs dynamic library | expand |
Hi, On Thu, 14 Oct 2021 18:08:24 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > libdbi needs dynamic library to avoid the following build failure raised > since the addition of the package in commit > c6aac6ebdbbd3873110a9e19de1957e49cb9344e: > > dbi_main.c:84:2: error: #error no dynamic loading support > 84 | #error no dynamic loading support > | ^~~~~ > > Fixes: > - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/libdbi-drivers/Config.in | 4 ++++ > package/libdbi/Config.in | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in > index 087e6aaf0e..7c505340c1 100644 > --- a/package/libdbi-drivers/Config.in > +++ b/package/libdbi-drivers/Config.in > @@ -1,8 +1,12 @@ > config BR2_PACKAGE_LIBDBI_DRIVERS > bool "libdbi-drivers" > + depends on !BR2_STATIC_LIBS # libdbi > select BR2_PACKAGE_LIBDBI > help > The libdbi-drivers project provides the > database-specific drivers for the libdbi framework. > > http://libdbi-drivers.sourceforge.net > + > +comment "libdbi-drivers needs a toolchain w/ dynamic library" > + depends on BR2_STATIC_LIBS > diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in > index ded2bc6e53..13ac344f82 100644 > --- a/package/libdbi/Config.in > +++ b/package/libdbi/Config.in > @@ -1,7 +1,11 @@ > config BR2_PACKAGE_LIBDBI > bool "lidbi" > + depends on !BR2_STATIC_LIBS > help > libdbi implements a database-independent abstraction layer > in C, similar to the DBI/DBD layer in Perl. > > http://libdbi.sourceforge.net > + > +comment "libdbi needs a toolchain w/ dynamic library" > + depends on BR2_STATIC_LIBS Indeed, Also in collectd Config.in, "depends on" needs to be added and its related comment. ---- 8< ---- config BR2_PACKAGE_COLLECTD_DBI bool "dbi" depends on !BR2_STATIC_LIBS # libdbi select BR2_PACKAGE_LIBDBI help Executes SQL statements on various databases and interprets the returned data. comment "dbi needs a toolchain w/ dynamic library" depends on BR2_STATIC_LIBS ---- 8< ---- Hervé
Hi, Le jeu. 14 oct. 2021 à 18:41, Herve Codina <herve.codina@bootlin.com> a écrit : > > Hi, > > On Thu, 14 Oct 2021 18:08:24 +0200 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > > libdbi needs dynamic library to avoid the following build failure raised > > since the addition of the package in commit > > c6aac6ebdbbd3873110a9e19de1957e49cb9344e: > > > > dbi_main.c:84:2: error: #error no dynamic loading support > > 84 | #error no dynamic loading support > > | ^~~~~ > > > > Fixes: > > - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/libdbi-drivers/Config.in | 4 ++++ > > package/libdbi/Config.in | 4 ++++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in > > index 087e6aaf0e..7c505340c1 100644 > > --- a/package/libdbi-drivers/Config.in > > +++ b/package/libdbi-drivers/Config.in > > @@ -1,8 +1,12 @@ > > config BR2_PACKAGE_LIBDBI_DRIVERS > > bool "libdbi-drivers" > > + depends on !BR2_STATIC_LIBS # libdbi > > select BR2_PACKAGE_LIBDBI > > help > > The libdbi-drivers project provides the > > database-specific drivers for the libdbi framework. > > > > http://libdbi-drivers.sourceforge.net > > + > > +comment "libdbi-drivers needs a toolchain w/ dynamic library" > > + depends on BR2_STATIC_LIBS > > diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in > > index ded2bc6e53..13ac344f82 100644 > > --- a/package/libdbi/Config.in > > +++ b/package/libdbi/Config.in > > @@ -1,7 +1,11 @@ > > config BR2_PACKAGE_LIBDBI > > bool "lidbi" > > + depends on !BR2_STATIC_LIBS > > help > > libdbi implements a database-independent abstraction layer > > in C, similar to the DBI/DBD layer in Perl. > > > > http://libdbi.sourceforge.net > > + > > +comment "libdbi needs a toolchain w/ dynamic library" > > + depends on BR2_STATIC_LIBS > > > Indeed, > > Also in collectd Config.in, "depends on" needs to be added > and its related comment. Nope, collectd already depends on dynamic library since commit 9960b957a63e8fdd197d9cef6ea55b1b05c40ec3 so it's not needed to add this dependency a second time. I'll send a patch to drop it from BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL. > > ---- 8< ---- > config BR2_PACKAGE_COLLECTD_DBI > bool "dbi" > depends on !BR2_STATIC_LIBS # libdbi > select BR2_PACKAGE_LIBDBI > help > Executes SQL statements on various databases and > interprets the returned data. > > comment "dbi needs a toolchain w/ dynamic library" > depends on BR2_STATIC_LIBS > ---- 8< ---- > > Hervé > > -- > Hervé Codina, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com Best Regards, Fabrice
On Thu, 14 Oct 2021 18:51:55 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > > Also in collectd Config.in, "depends on" needs to be added > > and its related comment. > Nope, collectd already depends on dynamic library since commit > 9960b957a63e8fdd197d9cef6ea55b1b05c40ec3 so it's not needed to add > this dependency a second time. > I'll send a patch to drop it from BR2_PACKAGE_COLLECTD_NOTIFY_EMAIL. Ok. Best regards, Hervé
On Thu, 14 Oct 2021 18:08:24 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > libdbi needs dynamic library to avoid the following build failure raised > since the addition of the package in commit > c6aac6ebdbbd3873110a9e19de1957e49cb9344e: > > dbi_main.c:84:2: error: #error no dynamic loading support > 84 | #error no dynamic loading support > | ^~~~~ > > Fixes: > - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/libdbi-drivers/Config.in | 4 ++++ > package/libdbi/Config.in | 4 ++++ > 2 files changed, 8 insertions(+) Applied to master, but after adding the !BR2_STATIC_LIBS dependency to collectd, as suggested by Hervé. Indeed, we prefer to duplicate those dependencies, if they turn out to change at the top-level BR2_PACKAGE_COLLECTD option. Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > On Thu, 14 Oct 2021 18:08:24 +0200 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: >> libdbi needs dynamic library to avoid the following build failure raised >> since the addition of the package in commit >> c6aac6ebdbbd3873110a9e19de1957e49cb9344e: >> >> dbi_main.c:84:2: error: #error no dynamic loading support >> 84 | #error no dynamic loading support >> | ^~~~~ >> >> Fixes: >> - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d >> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> >> --- >> package/libdbi-drivers/Config.in | 4 ++++ >> package/libdbi/Config.in | 4 ++++ >> 2 files changed, 8 insertions(+) > Applied to master, but after adding the !BR2_STATIC_LIBS dependency to > collectd, as suggested by Hervé. Indeed, we prefer to duplicate those > dependencies, if they turn out to change at the top-level > BR2_PACKAGE_COLLECTD option. Committed to 2021.11.x, thanks.
diff --git a/package/libdbi-drivers/Config.in b/package/libdbi-drivers/Config.in index 087e6aaf0e..7c505340c1 100644 --- a/package/libdbi-drivers/Config.in +++ b/package/libdbi-drivers/Config.in @@ -1,8 +1,12 @@ config BR2_PACKAGE_LIBDBI_DRIVERS bool "libdbi-drivers" + depends on !BR2_STATIC_LIBS # libdbi select BR2_PACKAGE_LIBDBI help The libdbi-drivers project provides the database-specific drivers for the libdbi framework. http://libdbi-drivers.sourceforge.net + +comment "libdbi-drivers needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS diff --git a/package/libdbi/Config.in b/package/libdbi/Config.in index ded2bc6e53..13ac344f82 100644 --- a/package/libdbi/Config.in +++ b/package/libdbi/Config.in @@ -1,7 +1,11 @@ config BR2_PACKAGE_LIBDBI bool "lidbi" + depends on !BR2_STATIC_LIBS help libdbi implements a database-independent abstraction layer in C, similar to the DBI/DBD layer in Perl. http://libdbi.sourceforge.net + +comment "libdbi needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
libdbi needs dynamic library to avoid the following build failure raised since the addition of the package in commit c6aac6ebdbbd3873110a9e19de1957e49cb9344e: dbi_main.c:84:2: error: #error no dynamic loading support 84 | #error no dynamic loading support | ^~~~~ Fixes: - http://autobuild.buildroot.org/results/9cd56a625cbd52b0c070e2d462e02f5161d9631d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/libdbi-drivers/Config.in | 4 ++++ package/libdbi/Config.in | 4 ++++ 2 files changed, 8 insertions(+)