| Message ID | 20211013070105.1857677-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/dtbocfg: depends on kernel | expand |
Hi, On Wed, 13 Oct 2021 09:01:05 +0200 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > Fix the following build failure raised since the addition of the package > in commit 9fc7b49ab193da55b0a72d27b5e0ea33245b4df0: > > Makefile:587: *** linux is in the dependency chain of dtbocfg that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > > Fixes: > - http://autobuild.buildroot.org/results/449a731c0a1394c28f519e341ea145cb42af012d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/dtbocfg/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in > index c1e8318e5c..862dc0ccc5 100644 > --- a/package/dtbocfg/Config.in > +++ b/package/dtbocfg/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_DTBOCFG > bool "dtbocfg" > + depends on BR2_LINUX_KERNEL > help > dtbocfg, which stands for Device Tree Blob Overlay > Configuration File System, was developed to serve Yes indeed. I missed this one. Acked-by: Herve Codina <herve.codina@bootlin.com> Hervé
Fabrice, All, On 2021-10-13 09:01 +0200, Fabrice Fontaine spake thusly: > Fix the following build failure raised since the addition of the package > in commit 9fc7b49ab193da55b0a72d27b5e0ea33245b4df0: > > Makefile:587: *** linux is in the dependency chain of dtbocfg that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > > Fixes: > - http://autobuild.buildroot.org/results/449a731c0a1394c28f519e341ea145cb42af012d > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/dtbocfg/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in > index c1e8318e5c..862dc0ccc5 100644 > --- a/package/dtbocfg/Config.in > +++ b/package/dtbocfg/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_DTBOCFG > bool "dtbocfg" > + depends on BR2_LINUX_KERNEL You forgot to add the corresponding comment: "dtbocfg needs a kernel to be built", so I've done so when applying, and applied to master, thanks. Regards, Yann E. MORIN. > help > dtbocfg, which stands for Device Tree Blob Overlay > Configuration File System, was developed to serve > -- > 2.33.0 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
Fabrice, All, On 2021-10-13 18:16 +0200, Yann E. MORIN spake thusly: > On 2021-10-13 09:01 +0200, Fabrice Fontaine spake thusly: > > Fix the following build failure raised since the addition of the package > > in commit 9fc7b49ab193da55b0a72d27b5e0ea33245b4df0: > > > > Makefile:587: *** linux is in the dependency chain of dtbocfg that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. > > > > Fixes: > > - http://autobuild.buildroot.org/results/449a731c0a1394c28f519e341ea145cb42af012d > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/dtbocfg/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in > > index c1e8318e5c..862dc0ccc5 100644 > > --- a/package/dtbocfg/Config.in > > +++ b/package/dtbocfg/Config.in > > @@ -1,5 +1,6 @@ > > config BR2_PACKAGE_DTBOCFG > > bool "dtbocfg" > > + depends on BR2_LINUX_KERNEL > > You forgot to add the corresponding comment: "dtbocfg needs a kernel to > be built", so I've done so when applying, and applied to master, thanks. ... and of course, I apparently forgot to run "git commit --amend"... Sigh... :-( Regards, Yann E. MORIN. > Regards, > Yann E. MORIN. > > > help > > dtbocfg, which stands for Device Tree Blob Overlay > > Configuration File System, was developed to serve > > -- > > 2.33.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot@buildroot.org > > https://lists.buildroot.org/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------' > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
diff --git a/package/dtbocfg/Config.in b/package/dtbocfg/Config.in index c1e8318e5c..862dc0ccc5 100644 --- a/package/dtbocfg/Config.in +++ b/package/dtbocfg/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_DTBOCFG bool "dtbocfg" + depends on BR2_LINUX_KERNEL help dtbocfg, which stands for Device Tree Blob Overlay Configuration File System, was developed to serve
Fix the following build failure raised since the addition of the package in commit 9fc7b49ab193da55b0a72d27b5e0ea33245b4df0: Makefile:587: *** linux is in the dependency chain of dtbocfg that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in. Stop. Fixes: - http://autobuild.buildroot.org/results/449a731c0a1394c28f519e341ea145cb42af012d Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/dtbocfg/Config.in | 1 + 1 file changed, 1 insertion(+)