| Message ID | 20210912200706.2884974-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/minicom: drop autoreconf | expand |
Hi Fabrice, On 9/12/21 10:07 PM, Fabrice Fontaine wrote: > autoreconf (and so AM_ICONV) is not needed since commit > 2df32e0d4437b422175089edf1917219656fccef Can you specify the upstream commit instead of the Buildroot one in commit log? Except that: Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Best regards
On 9/12/21 11:09 PM, Giulio Benetti wrote: > Hi Fabrice, > > On 9/12/21 10:07 PM, Fabrice Fontaine wrote: >> autoreconf (and so AM_ICONV) is not needed since commit >> 2df32e0d4437b422175089edf1917219656fccef > > Can you specify the upstream commit instead of the Buildroot one in > commit log? Ah yeah, with a link too. Thanks a lot
Hi Giulio, Le dim. 12 sept. 2021 à 23:11, Giulio Benetti <giulio.benetti@benettiengineering.com> a écrit : > > On 9/12/21 11:09 PM, Giulio Benetti wrote: > > Hi Fabrice, > > > > On 9/12/21 10:07 PM, Fabrice Fontaine wrote: > >> autoreconf (and so AM_ICONV) is not needed since commit > >> 2df32e0d4437b422175089edf1917219656fccef > > > > Can you specify the upstream commit instead of the Buildroot one in > > commit log? There is no upstream commit, we can drop autoreconf, because we're using the official tarball which provides a configure script since buildroot commit 2df32e0d4437b422175089edf1917219656fccef. > > Ah yeah, with a link too. > > Thanks a lot > > -- > Giulio Benetti > Benetti Engineering sas > > > > > Except that: > > > > Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> > > > > Best regards > > > Best Regards, Fabrice
Hi Fabrice, On 9/12/21 11:33 PM, Fabrice Fontaine wrote: > Hi Giulio, > > Le dim. 12 sept. 2021 à 23:11, Giulio Benetti > <giulio.benetti@benettiengineering.com> a écrit : >> >> On 9/12/21 11:09 PM, Giulio Benetti wrote: >>> Hi Fabrice, >>> >>> On 9/12/21 10:07 PM, Fabrice Fontaine wrote: >>>> autoreconf (and so AM_ICONV) is not needed since commit >>>> 2df32e0d4437b422175089edf1917219656fccef >>> >>> Can you specify the upstream commit instead of the Buildroot one in >>> commit log? > There is no upstream commit, we can drop autoreconf, because we're > using the official tarball which provides a configure script since > buildroot commit 2df32e0d4437b422175089edf1917219656fccef. Ah, pardon, you're right, it's the tarball and it contains configure script already generated, so no upstream commit. Fine. Thank you and Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com> Kind regards
Fabrice, All, On 2021-09-12 22:07 +0200, Fabrice Fontaine spake thusly: > autoreconf (and so AM_ICONV) is not needed since commit > 2df32e0d4437b422175089edf1917219656fccef > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Applied to master, thanks. Regards, Yann E. MORIN. > --- > package/minicom/minicom.mk | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk > index b81ee52120..5cd1d6b8b8 100644 > --- a/package/minicom/minicom.mk > +++ b/package/minicom/minicom.mk > @@ -11,12 +11,9 @@ MINICOM_SITE = \ > MINICOM_LICENSE = GPL-2.0+ > MINICOM_LICENSE_FILES = COPYING > MINICOM_CPE_ID_VENDOR = minicom_project > -MINICOM_AUTORECONF = YES > > MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \ > $(TARGET_NLS_DEPENDENCIES) host-pkgconf > -# add host-gettext for AM_ICONV macro > -MINICOM_DEPENDENCIES += host-gettext > > MINICOM_CONF_OPTS = \ > --enable-dfl-port=/dev/ttyS1 \ > -- > 2.33.0 > > _______________________________________________ > buildroot mailing list > buildroot@lists.buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes: > autoreconf (and so AM_ICONV) is not needed since commit > 2df32e0d4437b422175089edf1917219656fccef > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks.
diff --git a/package/minicom/minicom.mk b/package/minicom/minicom.mk index b81ee52120..5cd1d6b8b8 100644 --- a/package/minicom/minicom.mk +++ b/package/minicom/minicom.mk @@ -11,12 +11,9 @@ MINICOM_SITE = \ MINICOM_LICENSE = GPL-2.0+ MINICOM_LICENSE_FILES = COPYING MINICOM_CPE_ID_VENDOR = minicom_project -MINICOM_AUTORECONF = YES MINICOM_DEPENDENCIES = ncurses $(if $(BR2_ENABLE_LOCALE),,libiconv) \ $(TARGET_NLS_DEPENDENCIES) host-pkgconf -# add host-gettext for AM_ICONV macro -MINICOM_DEPENDENCIES += host-gettext MINICOM_CONF_OPTS = \ --enable-dfl-port=/dev/ttyS1 \
autoreconf (and so AM_ICONV) is not needed since commit 2df32e0d4437b422175089edf1917219656fccef Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/minicom/minicom.mk | 3 --- 1 file changed, 3 deletions(-)