diff mbox series

[14/16] support/testing: test_ubi: add image format on the qemu command line

Message ID 20210912141140.253778-12-romain.naour@gmail.com
State Accepted
Headers show
Series [01/16] support/testing: test_file_capabilities: bump to kernel 4.19.204 | expand

Commit Message

Romain Naour Sept. 12, 2021, 2:11 p.m. UTC
Adding the Image format on the Qemu command line avoid this warning:

"WARNING: Image format was not specified for 'output/TestUbi/images/rootfs.ubi' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions."

Signed-off-by: Romain Naour <romain.naour@gmail.com>
---
 support/testing/tests/fs/test_ubi.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Oct. 17, 2021, 7:50 p.m. UTC | #1
Romain, All,

On 2021-09-12 16:11 +0200, Romain Naour spake thusly:
> Adding the Image format on the Qemu command line avoid this warning:
> 
> "WARNING: Image format was not specified for 'output/TestUbi/images/rootfs.ubi' and probing guessed raw.
>          Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
>          Specify the 'raw' format explicitly to remove the restrictions."
> 
> Signed-off-by: Romain Naour <romain.naour@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  support/testing/tests/fs/test_ubi.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/fs/test_ubi.py b/support/testing/tests/fs/test_ubi.py
> index 8148e5f336..eeb55b1d59 100644
> --- a/support/testing/tests/fs/test_ubi.py
> +++ b/support/testing/tests/fs/test_ubi.py
> @@ -32,7 +32,7 @@ class TestUbi(infra.basetest.BRTest):
>                             kernel_cmdline=["root=ubi0:rootfs",
>                                             "ubi.mtd=0",
>                                             "rootfstype=ubifs"],
> -                           options=["-drive", "file={},if=pflash".format(img)])
> +                           options=["-drive", "file={},if=pflash,format=raw".format(img)])
>          self.emulator.login()
>          cmd = "mount | grep 'ubi0:rootfs on / type ubifs'"
>          _, exit_code = self.emulator.run(cmd)
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@lists.buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/support/testing/tests/fs/test_ubi.py b/support/testing/tests/fs/test_ubi.py
index 8148e5f336..eeb55b1d59 100644
--- a/support/testing/tests/fs/test_ubi.py
+++ b/support/testing/tests/fs/test_ubi.py
@@ -32,7 +32,7 @@  class TestUbi(infra.basetest.BRTest):
                            kernel_cmdline=["root=ubi0:rootfs",
                                            "ubi.mtd=0",
                                            "rootfstype=ubifs"],
-                           options=["-drive", "file={},if=pflash".format(img)])
+                           options=["-drive", "file={},if=pflash,format=raw".format(img)])
         self.emulator.login()
         cmd = "mount | grep 'ubi0:rootfs on / type ubifs'"
         _, exit_code = self.emulator.run(cmd)