diff mbox series

[v4,1/3] package/clapack: introduce BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS

Message ID 20210724214526.47637-1-arnout@mind.be
State Accepted
Headers show
Series [v4,1/3] package/clapack: introduce BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS | expand

Commit Message

Arnout Vandecappelle July 24, 2021, 9:45 p.m. UTC
This makes it easier for packages that depend on clapack to get
their dependencies correct.

Since the glibc dependency only exists for PowerPC, treat it as
an architecture dependency.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/clapack/Config.in | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Comments

Yann E. MORIN July 25, 2021, 7:47 a.m. UTC | #1
Arnout, All,

On 2021-07-24 23:45 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> This makes it easier for packages that depend on clapack to get
> their dependencies correct.
> 
> Since the glibc dependency only exists for PowerPC, treat it as
> an architecture dependency.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/clapack/Config.in | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/package/clapack/Config.in b/package/clapack/Config.in
> index a912eb6c91..98f94b0e60 100644
> --- a/package/clapack/Config.in
> +++ b/package/clapack/Config.in
> @@ -1,14 +1,19 @@
> +config BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS
> +	bool
> +	default y
> +	# assembler: Error: value out of range
> +	depends on !BR2_m68k_cf
> +	# _fpu_control is used on PowerPC, but not available with
> +	# uClibc or musl
> +	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
> +
>  comment "clapack needs a glibc toolchain"
>  	depends on BR2_powerpc
>  	depends on !BR2_TOOLCHAIN_USES_GLIBC
>  
>  config BR2_PACKAGE_CLAPACK
>  	bool "cblas/clapack"
> -	# _fpu_control is used on PowerPC, but not available with
> -	# uClibc or musl
> -	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
> -	# assembler: Error: value out of range
> -	depends on !BR2_m68k_cf
> +	depends on BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS
>  	help
>  	  BLAS and LAPACK C implementation (f2c'ed version of).
>  
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/package/clapack/Config.in b/package/clapack/Config.in
index a912eb6c91..98f94b0e60 100644
--- a/package/clapack/Config.in
+++ b/package/clapack/Config.in
@@ -1,14 +1,19 @@ 
+config BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS
+	bool
+	default y
+	# assembler: Error: value out of range
+	depends on !BR2_m68k_cf
+	# _fpu_control is used on PowerPC, but not available with
+	# uClibc or musl
+	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
+
 comment "clapack needs a glibc toolchain"
 	depends on BR2_powerpc
 	depends on !BR2_TOOLCHAIN_USES_GLIBC
 
 config BR2_PACKAGE_CLAPACK
 	bool "cblas/clapack"
-	# _fpu_control is used on PowerPC, but not available with
-	# uClibc or musl
-	depends on !BR2_powerpc || BR2_TOOLCHAIN_USES_GLIBC
-	# assembler: Error: value out of range
-	depends on !BR2_m68k_cf
+	depends on BR2_PACKAGE_CLAPACK_ARCH_SUPPORTS
 	help
 	  BLAS and LAPACK C implementation (f2c'ed version of).