diff mbox series

[1/1] package/uhd: USRP1 needs gcc >= 4.9

Message ID 20210522162924.16002-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/uhd: USRP1 needs gcc >= 4.9 | expand

Commit Message

Fabrice Fontaine May 22, 2021, 4:29 p.m. UTC
Commit c577eac16eaae515973faf3013da197516bfd391 forgot to add
dependencies of BR2_PACKAGE_UHD_USB to BR2_PACKAGE_UHD_USRP1

Fixes:
 - http://autobuild.buildroot.org/results/eaae6548fb536e2b0ea539c236cd7579e63fa21e

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/uhd/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Yann E. MORIN May 22, 2021, 4:59 p.m. UTC | #1
Fabrice, All,

On 2021-05-22 18:29 +0200, Fabrice Fontaine spake thusly:
> Commit c577eac16eaae515973faf3013da197516bfd391 forgot to add
> dependencies of BR2_PACKAGE_UHD_USB to BR2_PACKAGE_UHD_USRP1
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/eaae6548fb536e2b0ea539c236cd7579e63fa21e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/uhd/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/uhd/Config.in b/package/uhd/Config.in
> index fae0887509..f61bbf0e8f 100644
> --- a/package/uhd/Config.in
> +++ b/package/uhd/Config.in
> @@ -129,10 +129,14 @@ comment "USB support needs a toolchain w/ gcc >= 4.9"
>  
>  config BR2_PACKAGE_UHD_USRP1
>  	bool "USRP1 support"
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
>  	select BR2_PACKAGE_UHD_USB
>  	help
>  	  enable USRP1 support
>  
> +comment "USRP1 support needs a toolchain w/ gcc >= 4.9"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +
>  config BR2_PACKAGE_UHD_USRP2
>  	bool "USRP2 support"
>  	help
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard June 7, 2021, 9:37 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Commit c577eac16eaae515973faf3013da197516bfd391 forgot to add
 > dependencies of BR2_PACKAGE_UHD_USB to BR2_PACKAGE_UHD_USRP1

 > Fixes:
 >  - http://autobuild.buildroot.org/results/eaae6548fb536e2b0ea539c236cd7579e63fa21e

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2021.02.x, thanks.
diff mbox series

Patch

diff --git a/package/uhd/Config.in b/package/uhd/Config.in
index fae0887509..f61bbf0e8f 100644
--- a/package/uhd/Config.in
+++ b/package/uhd/Config.in
@@ -129,10 +129,14 @@  comment "USB support needs a toolchain w/ gcc >= 4.9"
 
 config BR2_PACKAGE_UHD_USRP1
 	bool "USRP1 support"
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # libusb
 	select BR2_PACKAGE_UHD_USB
 	help
 	  enable USRP1 support
 
+comment "USRP1 support needs a toolchain w/ gcc >= 4.9"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+
 config BR2_PACKAGE_UHD_USRP2
 	bool "USRP2 support"
 	help