diff mbox series

[1/1] package/zyre: bump version to 2.0.1

Message ID 20210308122733.1404-1-jack.cripps@disguise.one
State Accepted
Headers show
Series [1/1] package/zyre: bump version to 2.0.1 | expand

Commit Message

Jack Cripps March 8, 2021, 12:27 p.m. UTC
Version bump required due to python setup.py missing from v2.0.0 python bindings

Signed-off-by: Jack Cripps <jack.cripps@disguise.one>
---
Backport to 2019.11.x
---
 package/zyre/zyre.hash | 2 +-
 package/zyre/zyre.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN March 8, 2021, 10:56 p.m. UTC | #1
Jack, All,

On 2021-03-08 12:27 +0000, Jack Cripps spake thusly:
> Version bump required due to python setup.py missing from v2.0.0 python bindings
> 
> Signed-off-by: Jack Cripps <jack.cripps@disguise.one>

Applied to master, thanks.

> ---
> Backport to 2019.11.x

2019.11.x was not an LTS, and it stopped being maintained in February
2020.

Regards,
Yann E. MORIN.

> ---
>  package/zyre/zyre.hash | 2 +-
>  package/zyre/zyre.mk   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/zyre/zyre.hash b/package/zyre/zyre.hash
> index 289341f494..d9d92d78f2 100644
> --- a/package/zyre/zyre.hash
> +++ b/package/zyre/zyre.hash
> @@ -1,3 +1,3 @@
>  # Locally computed
> -sha256  b978a999947ddb6722d956db2427869b313225e50518c4fbbf960a68109e3e91  zyre-2.0.0.tar.gz
> +sha256  624d379dc880025144f58d3a7dc35ea1be4a57ba4e2a58c98ec15a60891be12d  zyre-2.0.1.tar.gz
>  sha256  1f256ecad192880510e84ad60474eab7589218784b9a50bc7ceee34c2b91f1d5  LICENSE
> diff --git a/package/zyre/zyre.mk b/package/zyre/zyre.mk
> index 21224d6bb4..a726859adf 100644
> --- a/package/zyre/zyre.mk
> +++ b/package/zyre/zyre.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -ZYRE_VERSION = 2.0.0
> +ZYRE_VERSION = 2.0.1
>  ZYRE_SITE = $(call github,zeromq,zyre,v$(ZYRE_VERSION))
>  ZYRE_LICENSE = MPL-2.0
>  ZYRE_LICENSE_FILES = LICENSE
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard March 19, 2021, 8:27 p.m. UTC | #2
>>>>> "Jack" == Jack Cripps <jack.cripps@disguise.one> writes:

 > Version bump required due to python setup.py missing from v2.0.0 python bindings

What does that mean exactly? How are those bindings installed and used?
We don't seem to do anything to handle them in zyre.mk?

 > Signed-off-by: Jack Cripps <jack.cripps@disguise.one>
 > ---
 > Backport to 2019.11.x

I take it you mean 2020.11.x here? 2020.02.x and 2021.02.x also has
zyre, so it is presumably needed there as well?
Jack Cripps March 22, 2021, 11:35 a.m. UTC | #3
---------- Forwarded message ---------
From: Jack Cripps <jack.cripps@disguise.one>
Date: Mon, 22 Mar 2021 at 11:22
Subject: Re: [PATCH 1/1] package/zyre: bump version to 2.0.1
To: Peter Korsgaard <peter@korsgaard.com>
Cc: <buildroot@buildroot.org>, Simon Dawson <spdawson@gmail.com>


Hi,

Apologies, the zyre.mk file included in 2.0.0 or 2.0.1 does not build any
of the auto-generated, alternative language bindings for zyre ecosystem. I
don't know if this would be desired behaviour (or whether there is some way
of adding this to the zyre config file). In lieu of this, I use an custom
external package 'python-zyre' to build the ctypes python bindings as a
python package. Zyre 2.0.0 is missing the setuptools.py file from it's
python bindings hence the required bump to v2.0.1. I do not know why this
quite critical file is missing from v2.0.0.

I believe probably all buildroot versions that have zyre 2.0.0 should be
updated to 2.0.1, so 2020.02.x onwards I suppose.

Thanks,
Jack Cripps

On Fri, 19 Mar 2021 at 20:27, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Jack" == Jack Cripps <jack.cripps@disguise.one> writes:
>
>  > Version bump required due to python setup.py missing from v2.0.0 python
> bindings
>
> What does that mean exactly? How are those bindings installed and used?
> We don't seem to do anything to handle them in zyre.mk?
>
>  > Signed-off-by: Jack Cripps <jack.cripps@disguise.one>
>  > ---
>  > Backport to 2019.11.x
>
> I take it you mean 2020.11.x here? 2020.02.x and 2021.02.x also has
> zyre, so it is presumably needed there as well?
>
> --
> Bye, Peter Korsgaard
>
diff mbox series

Patch

diff --git a/package/zyre/zyre.hash b/package/zyre/zyre.hash
index 289341f494..d9d92d78f2 100644
--- a/package/zyre/zyre.hash
+++ b/package/zyre/zyre.hash
@@ -1,3 +1,3 @@ 
 # Locally computed
-sha256  b978a999947ddb6722d956db2427869b313225e50518c4fbbf960a68109e3e91  zyre-2.0.0.tar.gz
+sha256  624d379dc880025144f58d3a7dc35ea1be4a57ba4e2a58c98ec15a60891be12d  zyre-2.0.1.tar.gz
 sha256  1f256ecad192880510e84ad60474eab7589218784b9a50bc7ceee34c2b91f1d5  LICENSE
diff --git a/package/zyre/zyre.mk b/package/zyre/zyre.mk
index 21224d6bb4..a726859adf 100644
--- a/package/zyre/zyre.mk
+++ b/package/zyre/zyre.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-ZYRE_VERSION = 2.0.0
+ZYRE_VERSION = 2.0.1
 ZYRE_SITE = $(call github,zeromq,zyre,v$(ZYRE_VERSION))
 ZYRE_LICENSE = MPL-2.0
 ZYRE_LICENSE_FILES = LICENSE