diff mbox series

package/ply: needs dynamic library

Message ID 20210213190522.GA490@arbad
State Accepted
Headers show
Series package/ply: needs dynamic library | expand

Commit Message

Andreas Klinger Feb. 13, 2021, 7:05 p.m. UTC
ply is not compiling with static libraries.

Fixes:
 - http://autobuild.buildroot.net/results/3a586241d37614b644ff6c4674ae28df2b22fdf8

Signed-off-by: Andreas Klinger <ak@it-klinger.de>
---
 package/ply/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Yann E. MORIN Feb. 13, 2021, 9:35 p.m. UTC | #1
Andres, All,

On 2021-02-13 20:05 +0100, Andreas Klinger spake thusly:
> ply is not compiling with static libraries.
> 
> Fixes:
>  - http://autobuild.buildroot.net/results/3a586241d37614b644ff6c4674ae28df2b22fdf8

I found this build to be puzzling, so I dug deeper, and then found this
commit log to be lacking the interesting explanations, so I expanded the
commit log. Please review what I wrote if it makes sense...

Applied to master, thanks.

Regards,
Yann E. MORIN.

> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
>  package/ply/Config.in | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/ply/Config.in b/package/ply/Config.in
> index 35c2dc9bfc..16f5f8a267 100644
> --- a/package/ply/Config.in
> +++ b/package/ply/Config.in
> @@ -5,11 +5,18 @@ config BR2_PACKAGE_PLY_ARCH_SUPPORTS
>  	default y if BR2_powerpc
>  	default y if BR2_x86_64
>  
> +comment "ply needs a toolchain w/ dynamic library"
> +	depends on BR2_PACKAGE_PLY_ARCH_SUPPORTS
> +	depends on BR2_USE_MMU
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 # BPF_JLT
> +	depends on BR2_STATIC_LIBS
> +
>  config BR2_PACKAGE_PLY
>  	bool "ply"
>  	depends on BR2_PACKAGE_PLY_ARCH_SUPPORTS
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 # BPF_JLT
> +	depends on !BR2_STATIC_LIBS
>  	help
>  	  ply is a light-weight dynamic tracer for Linux. By means of
>  	  using the BPF it can attach probes to the linux kernel
> -- 
> 2.20.1
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Andreas Klinger Feb. 14, 2021, 6:39 a.m. UTC | #2
Hi Yann,

"Yann E. MORIN" <yann.morin.1998@free.fr> schrieb am Sa, 13. Feb 22:35:
> > Fixes:
> >  - http://autobuild.buildroot.net/results/3a586241d37614b644ff6c4674ae28df2b22fdf8
> 
> I found this build to be puzzling, so I dug deeper, and then found this
> commit log to be lacking the interesting explanations, so I expanded the
> commit log. Please review what I wrote if it makes sense...

Thank you for the brilliant description in the commit log. It makes the context
evident.

Regards,

Andreas
diff mbox series

Patch

diff --git a/package/ply/Config.in b/package/ply/Config.in
index 35c2dc9bfc..16f5f8a267 100644
--- a/package/ply/Config.in
+++ b/package/ply/Config.in
@@ -5,11 +5,18 @@  config BR2_PACKAGE_PLY_ARCH_SUPPORTS
 	default y if BR2_powerpc
 	default y if BR2_x86_64
 
+comment "ply needs a toolchain w/ dynamic library"
+	depends on BR2_PACKAGE_PLY_ARCH_SUPPORTS
+	depends on BR2_USE_MMU
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 # BPF_JLT
+	depends on BR2_STATIC_LIBS
+
 config BR2_PACKAGE_PLY
 	bool "ply"
 	depends on BR2_PACKAGE_PLY_ARCH_SUPPORTS
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 # BPF_JLT
+	depends on !BR2_STATIC_LIBS
 	help
 	  ply is a light-weight dynamic tracer for Linux. By means of
 	  using the BPF it can attach probes to the linux kernel