diff mbox series

[v2,1/1] package/libllcp: drop wrong comment

Message ID 20201213220329.735998-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [v2,1/1] package/libllcp: drop wrong comment | expand

Commit Message

Fabrice Fontaine Dec. 13, 2020, 10:03 p.m. UTC
Dependency on threads comes from libllcp itself not from libusb (which
is not even selected)

While at it, also add a comment about this dependency

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
 - Add a comment

 package/libllcp/Config.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Dec. 30, 2020, 10:56 p.m. UTC | #1
On Sun, 13 Dec 2020 23:03:29 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Dependency on threads comes from libllcp itself not from libusb (which
> is not even selected)
> 
> While at it, also add a comment about this dependency
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
>  - Add a comment

Applied to master, thanks.

Thomas
Peter Korsgaard Jan. 5, 2021, 4:47 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Dependency on threads comes from libllcp itself not from libusb (which
 > is not even selected)

 > While at it, also add a comment about this dependency

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 > ---
 > Changes v1 -> v2:
 >  - Add a comment

Committed to 2020.02.x and 2020.11.x, thanks.
diff mbox series

Patch

diff --git a/package/libllcp/Config.in b/package/libllcp/Config.in
index 1660e92a87..5dc5c36a67 100644
--- a/package/libllcp/Config.in
+++ b/package/libllcp/Config.in
@@ -1,9 +1,12 @@ 
 config BR2_PACKAGE_LIBLLCP
 	bool "libllcp"
-	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_LIBNFC
 	help
 	  Library extending libnfc with support for Logical Link Control
 	  Protocol.
 
 	  https://github.com/nfc-tools/libllcp
+
+comment "libllcp needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS