diff mbox series

package/python-tinyrpc: not available for python 2.x

Message ID 20200929204557.28901-1-peter@korsgaard.com
State Accepted
Headers show
Series package/python-tinyrpc: not available for python 2.x | expand

Commit Message

Peter Korsgaard Sept. 29, 2020, 8:45 p.m. UTC
Fixes:
http://autobuild.buildroot.net/results/eef0969bac04800cec51fa27f1e1ecd3a4c8211e/

tinyrpc 1.x is not compatible with python 2.x, leading to errors during the
pycompile step:

error:   File "/usr/lib/python2.7/site-packages/tinyrpc/client.py", line 37
    self, protocol: RPCProtocol, transport: ClientTransport
                  ^
SyntaxError: invalid syntax

As also documented in the README:
The current version will support Python3 only.  Have a look at the 0.9.x
version if you need Python2 support

https://github.com/mbr/tinyrpc/blob/1.0.4/README.rst

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/python-tinyrpc/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Asaf Kahlon Sept. 30, 2020, 4:39 a.m. UTC | #1
Hello,

On Tue, Sep 29, 2020 at 11:46 PM Peter Korsgaard <peter@korsgaard.com> wrote:
>
> Fixes:
> http://autobuild.buildroot.net/results/eef0969bac04800cec51fa27f1e1ecd3a4c8211e/
>
> tinyrpc 1.x is not compatible with python 2.x, leading to errors during the
> pycompile step:
>
> error:   File "/usr/lib/python2.7/site-packages/tinyrpc/client.py", line 37
>     self, protocol: RPCProtocol, transport: ClientTransport
>                   ^
> SyntaxError: invalid syntax
>
> As also documented in the README:
> The current version will support Python3 only.  Have a look at the 0.9.x
> version if you need Python2 support
>
> https://github.com/mbr/tinyrpc/blob/1.0.4/README.rst
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/python-tinyrpc/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/python-tinyrpc/Config.in b/package/python-tinyrpc/Config.in
> index 3c643c754a..3194b7825a 100644
> --- a/package/python-tinyrpc/Config.in
> +++ b/package/python-tinyrpc/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_TINYRPC
>         bool "python-tinyrpc"
> +       depends on BR2_PACKAGE_PYTHON3
>         select BR2_PACKAGE_PYTHON_SIX # runtime
>         help
>           A small, modular, transport and protocol neutral RPC
> --
> 2.20.1
>
Reviewed-by: Asaf Kahlon <asafka7@gmail.com>

Regards,
Asaf.
Yann E. MORIN Sept. 30, 2020, 7:13 p.m. UTC | #2
Peter, All,

On 2020-09-29 22:45 +0200, Peter Korsgaard spake thusly:
> Fixes:
> http://autobuild.buildroot.net/results/eef0969bac04800cec51fa27f1e1ecd3a4c8211e/
> 
> tinyrpc 1.x is not compatible with python 2.x, leading to errors during the
> pycompile step:
> 
> error:   File "/usr/lib/python2.7/site-packages/tinyrpc/client.py", line 37
>     self, protocol: RPCProtocol, transport: ClientTransport
>                   ^
> SyntaxError: invalid syntax
> 
> As also documented in the README:
> The current version will support Python3 only.  Have a look at the 0.9.x
> version if you need Python2 support
> 
> https://github.com/mbr/tinyrpc/blob/1.0.4/README.rst
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/python-tinyrpc/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-tinyrpc/Config.in b/package/python-tinyrpc/Config.in
> index 3c643c754a..3194b7825a 100644
> --- a/package/python-tinyrpc/Config.in
> +++ b/package/python-tinyrpc/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_TINYRPC
>  	bool "python-tinyrpc"
> +	depends on BR2_PACKAGE_PYTHON3
>  	select BR2_PACKAGE_PYTHON_SIX # runtime
>  	help
>  	  A small, modular, transport and protocol neutral RPC
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Oct. 2, 2020, 8:59 a.m. UTC | #3
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Fixes:
 > http://autobuild.buildroot.net/results/eef0969bac04800cec51fa27f1e1ecd3a4c8211e/

 > tinyrpc 1.x is not compatible with python 2.x, leading to errors during the
 > pycompile step:

 > error:   File "/usr/lib/python2.7/site-packages/tinyrpc/client.py", line 37
 >     self, protocol: RPCProtocol, transport: ClientTransport
 >                   ^
 > SyntaxError: invalid syntax

 > As also documented in the README:
 > The current version will support Python3 only.  Have a look at the 0.9.x
 > version if you need Python2 support

 > https://github.com/mbr/tinyrpc/blob/1.0.4/README.rst

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2020.02.x, 2020.05.x and 2020.08.x, thanks.
diff mbox series

Patch

diff --git a/package/python-tinyrpc/Config.in b/package/python-tinyrpc/Config.in
index 3c643c754a..3194b7825a 100644
--- a/package/python-tinyrpc/Config.in
+++ b/package/python-tinyrpc/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_PYTHON_TINYRPC
 	bool "python-tinyrpc"
+	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
 	  A small, modular, transport and protocol neutral RPC