| Message ID | 20200516161140.21831-1-danomimanchego123@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/libssh2: fix autoreconf comment | expand |
Danomi, All, On 2020-05-16 12:11 -0400, Danomi Manchego spake thusly: > The comment explaining the autoreconf says that we are building from a git > clone - but we are not, currently. However, the reconf is still needed due > to patches modifying ac files. > > This commit corrects the comment. > > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> > --- > package/libssh2/libssh2.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/libssh2/libssh2.mk b/package/libssh2/libssh2.mk > index 3819c1a..2d2599f 100644 > --- a/package/libssh2/libssh2.mk > +++ b/package/libssh2/libssh2.mk > @@ -14,7 +14,7 @@ LIBSSH2_CONF_OPTS = --disable-examples-build > # 0003-packet-c-improve-message-parsing.patch > LIBSSH2_IGNORE_CVES += CVE-2019-17498 > > -# building from a git clone > +# patch touching configure.ac ... and acincludes.m4. Applied to master with that fixed. thanks! Regards, Yann E. MORIN. > LIBSSH2_AUTORECONF = YES > > ifeq ($(BR2_PACKAGE_LIBSSH2_MBEDTLS),y) > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes: > The comment explaining the autoreconf says that we are building from a git > clone - but we are not, currently. However, the reconf is still needed due > to patches modifying ac files. > This commit corrects the comment. > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> Committed to 2020.02.x, thanks.
diff --git a/package/libssh2/libssh2.mk b/package/libssh2/libssh2.mk index 3819c1a..2d2599f 100644 --- a/package/libssh2/libssh2.mk +++ b/package/libssh2/libssh2.mk @@ -14,7 +14,7 @@ LIBSSH2_CONF_OPTS = --disable-examples-build # 0003-packet-c-improve-message-parsing.patch LIBSSH2_IGNORE_CVES += CVE-2019-17498 -# building from a git clone +# patch touching configure.ac LIBSSH2_AUTORECONF = YES ifeq ($(BR2_PACKAGE_LIBSSH2_MBEDTLS),y)
The comment explaining the autoreconf says that we are building from a git clone - but we are not, currently. However, the reconf is still needed due to patches modifying ac files. This commit corrects the comment. Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> --- package/libssh2/libssh2.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)