| Message ID | 20200225212213.22680-1-romain.naour@smile.fr |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Config.in: add BR2_HOST_GCC_AT_LEAST_9 | expand |
On Tue, 25 Feb 2020 22:22:13 +0100 Romain Naour <romain.naour@smile.fr> wrote: > Fedora 30 switched to GCC 9.x. [1] > > [1] https://fedoraproject.org/wiki/Changes/GCC9 > > Signed-off-by: Romain Naour <romain.naour@smile.fr> Thanks, but this was not sufficiently tested it seems: on my Fedora system with gcc 9.x, BR2_HOST_GCC_VERSION was still 8, and therefore BR2_HOST_GCC_AT_LEAST_9 was not "y". This is because the main Buildroot Makefile HOSTCC_MAX_VERSION variable needs to be updated as well. I fixed that up and applied to master. Thanks! Best regards, Thomas
Hello Thomas, Le 25/02/2020 à 23:23, Thomas Petazzoni a écrit : > On Tue, 25 Feb 2020 22:22:13 +0100 > Romain Naour <romain.naour@smile.fr> wrote: > >> Fedora 30 switched to GCC 9.x. [1] >> >> [1] https://fedoraproject.org/wiki/Changes/GCC9 >> >> Signed-off-by: Romain Naour <romain.naour@smile.fr> > > Thanks, but this was not sufficiently tested it seems: on my Fedora > system with gcc 9.x, BR2_HOST_GCC_VERSION was still 8, and therefore > BR2_HOST_GCC_AT_LEAST_9 was not "y". This is because the main Buildroot > Makefile HOSTCC_MAX_VERSION variable needs to be updated as well. > > I fixed that up and applied to master. Thanks! Sorry for that. I was looking at [1] at the same time (that is why I noticed this symbol was missing). [1] https://bugs.busybox.net/show_bug.cgi?id=12581 Best regards, Romain > > Best regards, > > Thomas >
diff --git a/Config.in b/Config.in index 2ccbdfb963..abaee794a4 100644 --- a/Config.in +++ b/Config.in @@ -50,6 +50,11 @@ config BR2_HOST_GCC_AT_LEAST_8 default y if BR2_HOST_GCC_VERSION = "8" select BR2_HOST_GCC_AT_LEAST_7 +config BR2_HOST_GCC_AT_LEAST_9 + bool + default y if BR2_HOST_GCC_VERSION = "9" + select BR2_HOST_GCC_AT_LEAST_8 + # When adding new entries above, be sure to update # the HOSTCC_MAX_VERSION variable in the Makefile.
Fedora 30 switched to GCC 9.x. [1] [1] https://fedoraproject.org/wiki/Changes/GCC9 Signed-off-by: Romain Naour <romain.naour@smile.fr> --- Config.in | 5 +++++ 1 file changed, 5 insertions(+)