diff mbox series

[2/2] package/mesa3d: x11 needs EGL, GLX or a vulkan driver

Message ID 20191229131453.327907-2-fontaine.fabrice@gmail.com
State New
Headers show
Series [1/2] package/mesa3d: XvMC needs x11 | expand

Commit Message

Fabrice Fontaine Dec. 29, 2019, 1:14 p.m. UTC
As specified in meson.build, x11 platform needs EGL, GLX or a vulkan
driver:

if with_platform_x11
  if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm')
    pre_args += '-DHAVE_X11_PLATFORM'
  endif

Fixes:
 - http://autobuild.buildroot.org/results/e044609e603ca68695d842d08809fdcb35bc8127

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/mesa3d/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Sept. 15, 2020, 7:05 p.m. UTC | #1
On Sun, 29 Dec 2019 14:14:53 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> As specified in meson.build, x11 platform needs EGL, GLX or a vulkan
> driver:
> 
> if with_platform_x11
>   if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm')
>     pre_args += '-DHAVE_X11_PLATFORM'
>   endif
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/e044609e603ca68695d842d08809fdcb35bc8127

This autobuilder failure seems related to the XvMC issue fixed by PATCH
1/2 in this series.

> diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
> index 844360950c..373fe7004c 100644
> --- a/package/mesa3d/Config.in
> +++ b/package/mesa3d/Config.in
> @@ -87,6 +87,7 @@ config BR2_PACKAGE_MESA3D_NEEDS_X11
>  	bool
>  	depends on BR2_PACKAGE_XORG7
>  	select BR2_PACKAGE_LIBXCB
> +	select BR2_PACKAGE_MESA3D_OPENGL_EGL if !(BR2_PACKAGE_MESA3D_OPENGL_GLX || BR2_PACKAGE_MESA3D_VULKAN_DRIVER)

I am rather confused but this. How is having a Vulkan driver at the
same "level" as having either EGL or GLX ?

Shouldn't it be the responsibility of whoever selects
BR2_PACKAGE_MESA3D_NEEDS_X11 to define whether EGL or GLX is used. It
seems a bit "random" to me that EGL is selected if neither GLX nor a
Vulkan driver are enabled.

Thomas
diff mbox series

Patch

diff --git a/package/mesa3d/Config.in b/package/mesa3d/Config.in
index 844360950c..373fe7004c 100644
--- a/package/mesa3d/Config.in
+++ b/package/mesa3d/Config.in
@@ -87,6 +87,7 @@  config BR2_PACKAGE_MESA3D_NEEDS_X11
 	bool
 	depends on BR2_PACKAGE_XORG7
 	select BR2_PACKAGE_LIBXCB
+	select BR2_PACKAGE_MESA3D_OPENGL_EGL if !(BR2_PACKAGE_MESA3D_OPENGL_GLX || BR2_PACKAGE_MESA3D_VULKAN_DRIVER)
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_XLIB_LIBXDAMAGE
 	select BR2_PACKAGE_XLIB_LIBXEXT