| Message ID | 20191031131507.1936-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/3] package/sysrepo: link with libatomic when needed | expand |
On Thu, 31 Oct 2019 14:15:05 +0100 Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote: > On some architectures, atomic binutils are provided by the libatomic > library from gcc. Linking with libatomic is therefore necessary, > otherwise the build fails with: > > /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: libsysrepo.so.0.7.8: undefined reference to `__atomic_fetch_add_4' > > This is often for example the case on sparcv8 32 bit. > > Fixes: > - http://autobuild.buildroot.org/results/d807f3dc922a61e099a66de3bc340c018a86e150 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/sysrepo/sysrepo.mk | 4 ++++ > 1 file changed, 4 insertions(+) Series applied, thanks! Thomas
diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk index 31317d6236..72c380768d 100644 --- a/package/sysrepo/sysrepo.mk +++ b/package/sysrepo/sysrepo.mk @@ -29,6 +29,10 @@ SYSREPO_CONF_OPTS = \ # build .. https://github.com/sysrepo/sysrepo/issues/947 SYSREPO_CONF_OPTS += -DUSE_SR_MEM_MGMT=OFF +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y) +SYSREPO_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic +endif + define SYSREPO_INSTALL_INIT_SYSV $(INSTALL) -m 755 -D package/sysrepo/S50sysrepod \ $(TARGET_DIR)/etc/init.d/S50sysrepod
On some architectures, atomic binutils are provided by the libatomic library from gcc. Linking with libatomic is therefore necessary, otherwise the build fails with: /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/bin/../lib/gcc/sparc-buildroot-linux-uclibc/7.4.0/../../../../sparc-buildroot-linux-uclibc/bin/ld: libsysrepo.so.0.7.8: undefined reference to `__atomic_fetch_add_4' This is often for example the case on sparcv8 32 bit. Fixes: - http://autobuild.buildroot.org/results/d807f3dc922a61e099a66de3bc340c018a86e150 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/sysrepo/sysrepo.mk | 4 ++++ 1 file changed, 4 insertions(+)