diff mbox series

[v4] package/python-matplotlib: add kiwisolver dependency

Message ID 20190930084741.4641-1-esben@geanix.com
State Not Applicable
Headers show
Series [v4] package/python-matplotlib: add kiwisolver dependency | expand

Commit Message

Esben Haabendal Sept. 30, 2019, 8:47 a.m. UTC
This is needed by matplotlib.pyplot, and is also documented at
https://matplotlib.org/users/installing.html#building-on-linux

Signed-off-by: Esben Haabendal <esben@geanix.com>
---
 package/python-matplotlib/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Sept. 30, 2019, noon UTC | #1
Hello Esben,

On Mon, 30 Sep 2019 10:47:41 +0200
Esben Haabendal <esben@geanix.com> wrote:

> This is needed by matplotlib.pyplot, and is also documented at
> https://matplotlib.org/users/installing.html#building-on-linux
> 
> Signed-off-by: Esben Haabendal <esben@geanix.com>

This is exactly the same version as v2, which was exactly the same as
v3. Why do you resend the same patch multiple times ?

This version is in fact even less good than the v3, because you lost
the Reviewed-by from Yegor.

It seems like you keep sending new versions with no changes, just
because your patches haven't been applied. Your patches have been
applied because we have a backlog of ~350 patches. We can't lose any of
them, because they are recorded by patchwork.

Best regards,

Thomas
Esben Haabendal Oct. 3, 2019, 6:31 a.m. UTC | #2
Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

> Hello Esben,
>
> On Mon, 30 Sep 2019 10:47:41 +0200
> Esben Haabendal <esben@geanix.com> wrote:
>
>> This is needed by matplotlib.pyplot, and is also documented at
>> https://matplotlib.org/users/installing.html#building-on-linux
>> 
>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>
> This is exactly the same version as v2, which was exactly the same as
> v3. Why do you resend the same patch multiple times ?
>
> This version is in fact even less good than the v3, because you lost
> the Reviewed-by from Yegor.
>
> It seems like you keep sending new versions with no changes, just
> because your patches haven't been applied. Your patches have been
> applied because we have a backlog of ~350 patches. We can't lose any of
> them, because they are recorded by patchwork.

Sorry about that.  For some reason I had assumed that buildroot used the
same lossy approach as is usual on kernel lists.  I will do my best to
not make the same mistake in the future :)

/Esben
Thomas Petazzoni Oct. 3, 2019, 9:13 a.m. UTC | #3
Hello Esben,

On Thu, 03 Oct 2019 08:31:55 +0200
Esben Haabendal <esben@geanix.com> wrote:

> Sorry about that.  For some reason I had assumed that buildroot used the
> same lossy approach as is usual on kernel lists.  I will do my best to
> not make the same mistake in the future :)

Mistakes always happen, and even with patchwork it is possible for one
of the maintainer to make a mistake a mark a patch as Accepted even if
it was not applied.

However, you can always check at
http://patchwork.ozlabs.org/project/buildroot/list/ if your patch is
still there. As long as it's there, it's not forgotten.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/python-matplotlib/Config.in b/package/python-matplotlib/Config.in
index 07160affd043..e6ed8cda2f28 100644
--- a/package/python-matplotlib/Config.in
+++ b/package/python-matplotlib/Config.in
@@ -9,6 +9,7 @@  config BR2_PACKAGE_PYTHON_MATPLOTLIB
 	select BR2_PACKAGE_PYTHON_CYCLER
 	select BR2_PACKAGE_PYTHON_SETUPTOOLS # runtime
 	select BR2_PACKAGE_PYTHON_DATEUTIL # runtime
+	select BR2_PACKAGE_PYTHON_KIWISOLVER # runtime
 	select BR2_PACKAGE_PYTHON_NUMPY # runtime
 	select BR2_PACKAGE_PYTHON_PYPARSING # runtime
 	select BR2_PACKAGE_PYTHON3_ZLIB # runtime