| Message ID | 20190909121525.13935-2-maeva.manuel@nxp.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/7] board/freescale/common/imx: add support for i.MX8QM | expand |
Hi Maeva, Sorry for the (very) late reply. On Mon, Sep 09, 2019 at 12:14:58PM +0000, Maeva Manuel wrote: > Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com> > --- > package/freescale-imx/Config.in | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in > index f010aab87b..5672e09b05 100644 > --- a/package/freescale-imx/Config.in > +++ b/package/freescale-imx/Config.in > @@ -40,6 +40,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL > config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 > bool "imx7d/imx7ulp" > > +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 > + bool "imx8" > + > config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M > bool "imx8m" This isn't sufficient, you also need to make sure to add BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 in the BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU definition as I'm sure it has a Vivante GPU ;) Looking at Config.in, seems that MX8MM has the same issue. Regards, Gary
Hello,
On Mon, 9 Sep 2019 12:14:58 +0000
Maeva Manuel <maeva.manuel@nxp.com> wrote:
> Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com>
I have applied after extending the commit log to give a bit more
context about the i.MX8 family, which contains i.MX8QM and i.MX8QP.
I've also updated BR2_PACKAGE_FREESCALE_IMX_PLATFORM and
BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU with this new i.MX platform, as
suggested by Gary.
Thanks!
Thomas
On Fri, 8 Nov 2019 18:30:26 +0100 Gary Bisson <bisson.gary@gmail.com> wrote: > This isn't sufficient, you also need to make sure to add > BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 in the > BR2_PACKAGE_FREESCALE_IMX_HAS_VIV_GPU definition as I'm sure it has a > Vivante GPU ;) True, I fixed that when applying. > Looking at Config.in, seems that MX8MM has the same issue. It was fixed yesterday by commit 7b3c48ed8107c5cd39f5d761734964dcd8c8d408. Thanks! Thomas
diff --git a/package/freescale-imx/Config.in b/package/freescale-imx/Config.in index f010aab87b..5672e09b05 100644 --- a/package/freescale-imx/Config.in +++ b/package/freescale-imx/Config.in @@ -40,6 +40,9 @@ config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX6UL config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX7 bool "imx7d/imx7ulp" +config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8 + bool "imx8" + config BR2_PACKAGE_FREESCALE_IMX_PLATFORM_IMX8M bool "imx8m"
Signed-off-by: Maeva Manuel <maeva.manuel@nxp.com> --- package/freescale-imx/Config.in | 3 +++ 1 file changed, 3 insertions(+)