diff mbox series

CHANGES: fix missing "binutils" in 2019.05-rc1 description

Message ID 20190509065155.21279-1-thomas.petazzoni@bootlin.com
State Rejected
Headers show
Series CHANGES: fix missing "binutils" in 2019.05-rc1 description | expand

Commit Message

Thomas Petazzoni May 9, 2019, 6:51 a.m. UTC
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 CHANGES | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard May 9, 2019, 7:32 a.m. UTC | #1
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > ---
 >  CHANGES | 4 ++--
 >  1 file changed, 2 insertions(+), 2 deletions(-)

 > diff --git a/CHANGES b/CHANGES
 > index 6fb63479ee..fb9e2e70c5 100644
 > --- a/CHANGES
 > +++ b/CHANGES
 > @@ -8,8 +8,8 @@
 >  	not just when not available on the build host.
 
 >  	Toolchain: Glibc bumped to 2.29, musl bumped to 1.1.22,
 > -	binutils 2.32 added, 2.28/2.29 removed, default changed to
 > -	2.31.1.
 > +	binutils 2.32 added, binutils 2.28/2.29 removed, default
 > +	changed to 2.31.1.

I actually did this on purpose as the entire line is about binutils, so
it is implied for the removed / default part.

But I don't really feel strongly about it. If you find this way clearer
then feel free to apply.
Thomas Petazzoni May 9, 2019, 7:46 a.m. UTC | #2
On Thu, 09 May 2019 09:32:01 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

>  >  	Toolchain: Glibc bumped to 2.29, musl bumped to 1.1.22,
>  > -	binutils 2.32 added, 2.28/2.29 removed, default changed to
>  > -	2.31.1.
>  > +	binutils 2.32 added, binutils 2.28/2.29 removed, default
>  > +	changed to 2.31.1.  
> 
> I actually did this on purpose as the entire line is about binutils, so
> it is implied for the removed / default part.

Ah yes, indeed, my bad. I read it incorrectly. We can withdraw my patch.

Thomas
diff mbox series

Patch

diff --git a/CHANGES b/CHANGES
index 6fb63479ee..fb9e2e70c5 100644
--- a/CHANGES
+++ b/CHANGES
@@ -8,8 +8,8 @@ 
 	not just when not available on the build host.
 
 	Toolchain: Glibc bumped to 2.29, musl bumped to 1.1.22,
-	binutils 2.32 added, 2.28/2.29 removed, default changed to
-	2.31.1.
+	binutils 2.32 added, binutils 2.28/2.29 removed, default
+	changed to 2.31.1.
 
 	fs: Set FAKEROOTDONTTRYCHOWN environment variable to not
 	forward {f,l,}chown calls to libc when running under fakeroot