diff mbox series

[1/1] package/llvm: fix build with gcc < 5.1

Message ID 20190413084555.2367-1-valentinkorenblit@gmail.com
State Accepted
Headers show
Series [1/1] package/llvm: fix build with gcc < 5.1 | expand

Commit Message

Valentin Korenblit April 13, 2019, 8:45 a.m. UTC
Fixes:

http://autobuild.buildroot.net/results/0c046a1b57a4f0b992333003d41062e1b256eb0d

Signed-off-by: Valentin Korenblit <valentinkorenblit@gmail.com>
---
 package/llvm/llvm.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Romain Naour April 13, 2019, 2:36 p.m. UTC | #1
Hi Valentin,

Le 13/04/2019 à 10:45, Valentin Korenblit a écrit :
> Fixes:
> 
> http://autobuild.buildroot.net/results/0c046a1b57a4f0b992333003d41062e1b256eb0d
> 
> Signed-off-by: Valentin Korenblit <valentinkorenblit@gmail.com>
> ---
>  package/llvm/llvm.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index cd374d74b4..28c5e89706 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -17,6 +17,9 @@ LLVM_INSTALL_STAGING = YES
>  HOST_LLVM_DEPENDENCIES = host-python
>  LLVM_DEPENDENCIES = host-llvm
>  

Maybe a comment about these options is welcome :)

# LLVM >= 9.0 will soon require C++14 support, building llvm 8.x using a
toolchain using gcc < 5.1 is deprecated but still build with gcc >= 4.8.
# https://reviews.llvm.org/D57264
> +HOST_LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
> +LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON

Best regards,
Romain

> +
>  # Don't build clang libcxx libcxxabi lldb compiler-rt lld polly as llvm subprojects
>  # This flag assumes that projects are checked out side-by-side and not nested
>  HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_PROJECTS=""
>
Arnout Vandecappelle April 13, 2019, 2:52 p.m. UTC | #2
On 13/04/2019 16:36, Romain Naour wrote:
> Hi Valentin,
> 
> Le 13/04/2019 à 10:45, Valentin Korenblit a écrit :
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/0c046a1b57a4f0b992333003d41062e1b256eb0d
>>
>> Signed-off-by: Valentin Korenblit <valentinkorenblit@gmail.com>
>> ---
>>  package/llvm/llvm.mk | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
>> index cd374d74b4..28c5e89706 100644
>> --- a/package/llvm/llvm.mk
>> +++ b/package/llvm/llvm.mk
>> @@ -17,6 +17,9 @@ LLVM_INSTALL_STAGING = YES
>>  HOST_LLVM_DEPENDENCIES = host-python
>>  LLVM_DEPENDENCIES = host-llvm
>>  
> 
> Maybe a comment about these options is welcome :)
> 
> # LLVM >= 9.0 will soon require C++14 support, building llvm 8.x using a
> toolchain using gcc < 5.1 is deprecated but still build with gcc >= 4.8.
> # https://reviews.llvm.org/D57264

 I did exactly that and applied to master, thanks.

 Regards,
 Arnout

>> +HOST_LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
>> +LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
> 
> Best regards,
> Romain
> 
>> +
>>  # Don't build clang libcxx libcxxabi lldb compiler-rt lld polly as llvm subprojects
>>  # This flag assumes that projects are checked out side-by-side and not nested
>>  HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_PROJECTS=""
>>
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox series

Patch

diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index cd374d74b4..28c5e89706 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -17,6 +17,9 @@  LLVM_INSTALL_STAGING = YES
 HOST_LLVM_DEPENDENCIES = host-python
 LLVM_DEPENDENCIES = host-llvm
 
+HOST_LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
+LLVM_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
+
 # Don't build clang libcxx libcxxabi lldb compiler-rt lld polly as llvm subprojects
 # This flag assumes that projects are checked out side-by-side and not nested
 HOST_LLVM_CONF_OPTS += -DLLVM_ENABLE_PROJECTS=""