| Message ID | 20190406132059.2601-1-anisse@astier.eu |
|---|---|
| State | Superseded |
| Headers | show |
| Series | package/go: fix building host go toolchain when target isn't supported | expand |
Hi everyone, I'd like to provide additionnal context on this patch. The main motivation is the continous series of host-go build failures since 2019-03-18: http://autobuild.buildroot.net/?reason=host-go-1.12.1 Which coincides with the merging of this patch series: https://git.buildroot.net/buildroot/commit/?id=aba08cd218315c8ce5ec97c5e2dd5edbcfa47fdd Before submitting I also evaluated the following : - completely disabling build host packages if the target isn't supported - building a second separated go toolchain, specifically for the host. But it would be more work and duplication. - I don't think it would be a good idea to revert the host support patch series, since they provide a very useful feature, which might only grow as host go tools become more common (I even have such a tool with dmencrypt) Regards, Anisse On Sat, Apr 06, 2019 at 03:20:59PM +0200, Anisse Astier wrote: > The go toolchain can cross-compile by default. So most of the time, > building a toolchain that supports a target, allows us to also build go > binaries for the host. This is how support for host go packages was > added: we use the same toolchain that was initially built only for > target. > > But we might want to build a go binary for the host, when compiling a > target for which go isn't supported. Then, building host-go will fail: > by default, we build go for a specific target, and give the toolchain > bootstrap scripts the cross compiler we'll use. > > This change modifies this behaviour: we only assume the go toolchain is > cross-capable if we know the current target is supported. Otherwise this > is a simple host go tool. For the host, only x86_64, i386 and arm are > supported, to mimic the limitation of the go-bootstrap package. > > Fixes: > http://autobuild.buildroot.net/results/98b9c7aaff2af4d19adfedac00b768d92530ce94 > http://autobuild.buildroot.net/results/bed228995ce3778720f991df9b41345a7c724a46 > http://autobuild.buildroot.net/results/3b3ea148165b96513ea511ee0d4adb334a6afac8 > > Signed-off-by: Anisse Astier <anisse@astier.eu> > --- > package/go/go.mk | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/package/go/go.mk b/package/go/go.mk > index c27f161f48..86f60b8514 100644 > --- a/package/go/go.mk > +++ b/package/go/go.mk > @@ -62,6 +62,22 @@ else > HOST_GO_CGO_ENABLED = 0 > endif > > +HOST_GO_CROSS_ENV = \ > + CC_FOR_TARGET="$(TARGET_CC)" \ > + CXX_FOR_TARGET="$(TARGET_CXX)" \ > + GO_ASSUME_CROSSCOMPILING=1 > + > +ifneq ($(BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS),y) > +HOST_GO_CROSS_ENV = > +GO_GOARM = > +ifeq ($(HOSTARCH),x86_64) > +GO_GOARCH = amd64 > +else ifeq ($(HOSTARCH),i386) > +GO_GOARCH = 386 > +else ifeq ($(HOSTARCH),arm) > +GO_GOARCH = arm > +endif > +endif > # The go build system is not compatible with ccache, so use > # HOSTCC_NOCCACHE. See https://github.com/golang/go/issues/11685. > HOST_GO_MAKE_ENV = \ > @@ -75,16 +91,12 @@ HOST_GO_MAKE_ENV = \ > $(if $(GO_GOARM),GOARM=$(GO_GOARM)) \ > GOOS=linux \ > CC=$(HOSTCC_NOCCACHE) \ > - CXX=$(HOSTCXX_NOCCACHE) \ > - GO_ASSUME_CROSSCOMPILING=1 > + CXX=$(HOSTCXX_NOCCACHE) > > -HOST_GO_TARGET_CC = \ > - CC_FOR_TARGET="$(TARGET_CC)" \ > - CXX_FOR_TARGET="$(TARGET_CXX)" > > define HOST_GO_BUILD_CMDS > cd $(@D)/src && \ > - $(HOST_GO_MAKE_ENV) $(HOST_GO_TARGET_CC) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ > + $(HOST_GO_MAKE_ENV) $(HOST_GO_CROSS_ENV) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ > ./make.bash $(if $(VERBOSE),-v) > endef > > -- > 2.20.1 >
Hi Anisse, On 12/04/2019 14:26, Anisse Astier wrote: > Hi everyone, > > I'd like to provide additionnal context on this patch. The main > motivation is the continous series of host-go build failures since > 2019-03-18: > http://autobuild.buildroot.net/?reason=host-go-1.12.1 That was clear from the Fixes: entry :-) > > Which coincides with the merging of this patch series: > https://git.buildroot.net/buildroot/commit/?id=aba08cd218315c8ce5ec97c5e2dd5edbcfa47fdd > > Before submitting I also evaluated the following : > - completely disabling build host packages if the target isn't > supported > - building a second separated go toolchain, specifically for the host. > But it would be more work and duplication. > - I don't think it would be a good idea to revert the host support > patch series, since they provide a very useful feature, which might > only grow as host go tools become more common (I even have such a > tool with dmencrypt) Obviously it wouldn't. The patch is pretty good anyway. I was about to apply and wanted to make one little change, but then I kept on noticing different things that should change as well, so in the end I resubmitted it instead [1]. Please review that patch. If you have any question about my modifications, don't hesitate to ask. Regards, Arnout [1] http://patchwork.ozlabs.org/patch/1085910/ > > Regards, > > Anisse > > On Sat, Apr 06, 2019 at 03:20:59PM +0200, Anisse Astier wrote: >> The go toolchain can cross-compile by default. So most of the time, >> building a toolchain that supports a target, allows us to also build go >> binaries for the host. This is how support for host go packages was >> added: we use the same toolchain that was initially built only for >> target. >> >> But we might want to build a go binary for the host, when compiling a >> target for which go isn't supported. Then, building host-go will fail: >> by default, we build go for a specific target, and give the toolchain >> bootstrap scripts the cross compiler we'll use. >> >> This change modifies this behaviour: we only assume the go toolchain is >> cross-capable if we know the current target is supported. Otherwise this >> is a simple host go tool. For the host, only x86_64, i386 and arm are >> supported, to mimic the limitation of the go-bootstrap package. >> >> Fixes: >> http://autobuild.buildroot.net/results/98b9c7aaff2af4d19adfedac00b768d92530ce94 >> http://autobuild.buildroot.net/results/bed228995ce3778720f991df9b41345a7c724a46 >> http://autobuild.buildroot.net/results/3b3ea148165b96513ea511ee0d4adb334a6afac8 >> >> Signed-off-by: Anisse Astier <anisse@astier.eu> >> --- >> package/go/go.mk | 24 ++++++++++++++++++------ >> 1 file changed, 18 insertions(+), 6 deletions(-) >> >> diff --git a/package/go/go.mk b/package/go/go.mk >> index c27f161f48..86f60b8514 100644 >> --- a/package/go/go.mk >> +++ b/package/go/go.mk >> @@ -62,6 +62,22 @@ else >> HOST_GO_CGO_ENABLED = 0 >> endif >> >> +HOST_GO_CROSS_ENV = \ >> + CC_FOR_TARGET="$(TARGET_CC)" \ >> + CXX_FOR_TARGET="$(TARGET_CXX)" \ >> + GO_ASSUME_CROSSCOMPILING=1 >> + >> +ifneq ($(BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS),y) >> +HOST_GO_CROSS_ENV = >> +GO_GOARM = >> +ifeq ($(HOSTARCH),x86_64) >> +GO_GOARCH = amd64 >> +else ifeq ($(HOSTARCH),i386) >> +GO_GOARCH = 386 >> +else ifeq ($(HOSTARCH),arm) >> +GO_GOARCH = arm >> +endif >> +endif >> # The go build system is not compatible with ccache, so use >> # HOSTCC_NOCCACHE. See https://github.com/golang/go/issues/11685. >> HOST_GO_MAKE_ENV = \ >> @@ -75,16 +91,12 @@ HOST_GO_MAKE_ENV = \ >> $(if $(GO_GOARM),GOARM=$(GO_GOARM)) \ >> GOOS=linux \ >> CC=$(HOSTCC_NOCCACHE) \ >> - CXX=$(HOSTCXX_NOCCACHE) \ >> - GO_ASSUME_CROSSCOMPILING=1 >> + CXX=$(HOSTCXX_NOCCACHE) >> >> -HOST_GO_TARGET_CC = \ >> - CC_FOR_TARGET="$(TARGET_CC)" \ >> - CXX_FOR_TARGET="$(TARGET_CXX)" >> >> define HOST_GO_BUILD_CMDS >> cd $(@D)/src && \ >> - $(HOST_GO_MAKE_ENV) $(HOST_GO_TARGET_CC) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ >> + $(HOST_GO_MAKE_ENV) $(HOST_GO_CROSS_ENV) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ >> ./make.bash $(if $(VERBOSE),-v) >> endef >> >> -- >> 2.20.1 >> > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
diff --git a/package/go/go.mk b/package/go/go.mk index c27f161f48..86f60b8514 100644 --- a/package/go/go.mk +++ b/package/go/go.mk @@ -62,6 +62,22 @@ else HOST_GO_CGO_ENABLED = 0 endif +HOST_GO_CROSS_ENV = \ + CC_FOR_TARGET="$(TARGET_CC)" \ + CXX_FOR_TARGET="$(TARGET_CXX)" \ + GO_ASSUME_CROSSCOMPILING=1 + +ifneq ($(BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS),y) +HOST_GO_CROSS_ENV = +GO_GOARM = +ifeq ($(HOSTARCH),x86_64) +GO_GOARCH = amd64 +else ifeq ($(HOSTARCH),i386) +GO_GOARCH = 386 +else ifeq ($(HOSTARCH),arm) +GO_GOARCH = arm +endif +endif # The go build system is not compatible with ccache, so use # HOSTCC_NOCCACHE. See https://github.com/golang/go/issues/11685. HOST_GO_MAKE_ENV = \ @@ -75,16 +91,12 @@ HOST_GO_MAKE_ENV = \ $(if $(GO_GOARM),GOARM=$(GO_GOARM)) \ GOOS=linux \ CC=$(HOSTCC_NOCCACHE) \ - CXX=$(HOSTCXX_NOCCACHE) \ - GO_ASSUME_CROSSCOMPILING=1 + CXX=$(HOSTCXX_NOCCACHE) -HOST_GO_TARGET_CC = \ - CC_FOR_TARGET="$(TARGET_CC)" \ - CXX_FOR_TARGET="$(TARGET_CXX)" define HOST_GO_BUILD_CMDS cd $(@D)/src && \ - $(HOST_GO_MAKE_ENV) $(HOST_GO_TARGET_CC) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ + $(HOST_GO_MAKE_ENV) $(HOST_GO_CROSS_ENV) CGO_ENABLED=$(HOST_GO_CGO_ENABLED) \ ./make.bash $(if $(VERBOSE),-v) endef
The go toolchain can cross-compile by default. So most of the time, building a toolchain that supports a target, allows us to also build go binaries for the host. This is how support for host go packages was added: we use the same toolchain that was initially built only for target. But we might want to build a go binary for the host, when compiling a target for which go isn't supported. Then, building host-go will fail: by default, we build go for a specific target, and give the toolchain bootstrap scripts the cross compiler we'll use. This change modifies this behaviour: we only assume the go toolchain is cross-capable if we know the current target is supported. Otherwise this is a simple host go tool. For the host, only x86_64, i386 and arm are supported, to mimic the limitation of the go-bootstrap package. Fixes: http://autobuild.buildroot.net/results/98b9c7aaff2af4d19adfedac00b768d92530ce94 http://autobuild.buildroot.net/results/bed228995ce3778720f991df9b41345a7c724a46 http://autobuild.buildroot.net/results/3b3ea148165b96513ea511ee0d4adb334a6afac8 Signed-off-by: Anisse Astier <anisse@astier.eu> --- package/go/go.mk | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-)