diff mbox series

[1/1] package/haproxy: disable on nios2 and microblaze

Message ID 20190330133107.19895-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [1/1] package/haproxy: disable on nios2 and microblaze | expand

Commit Message

Fabrice Fontaine March 30, 2019, 1:31 p.m. UTC
Fixes:
 - http://autobuild.buildroot.org/results/4d7be00514f5276a9fd533adfdbc3d5183bb59ca
 - http://autobuild.buildroot.org/results/64706f96db793777de9d3ec63b0a47d776cf33fd

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/haproxy/Config.in | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni March 30, 2019, 2:10 p.m. UTC | #1
On Sat, 30 Mar 2019 14:31:07 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/4d7be00514f5276a9fd533adfdbc3d5183bb59ca
>  - http://autobuild.buildroot.org/results/64706f96db793777de9d3ec63b0a47d776cf33fd
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/haproxy/Config.in | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

Applied to master, thanks. I'm not a big fan of those architecture
dependencies, because it means we will never notice if those issues get
fixed in the future or not. That being said, who is ever going to us
haproxy on a low-speed Microblaze on NIOS2 system ?

So it's good enough.

Thomas
Peter Korsgaard April 5, 2019, 3:28 p.m. UTC | #2
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Fixes:
 >  - http://autobuild.buildroot.org/results/4d7be00514f5276a9fd533adfdbc3d5183bb59ca
 >  - http://autobuild.buildroot.org/results/64706f96db793777de9d3ec63b0a47d776cf33fd

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2019.02.x, thanks.
diff mbox series

Patch

diff --git a/package/haproxy/Config.in b/package/haproxy/Config.in
index 78cbf6e103..670de5a3ee 100644
--- a/package/haproxy/Config.in
+++ b/package/haproxy/Config.in
@@ -1,7 +1,16 @@ 
-config BR2_PACKAGE_HAPROXY
-	bool "haproxy"
+config BR2_PACKAGE_HAPROXY_ARCH_SUPPORTS
+	bool
+	default y
+	# internal compiler error: in do_output_reload, at reload1.c:7978
+	depends on !BR2_microblaze
+	# src/proto_http.c:6330:1: internal compiler error: Segmentation fault
+	depends on !BR2_nios2
 	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60040
 	depends on !(BR2_sh4 && !BR2_TOOLCHAIN_GCC_AT_LEAST_7)
+
+config BR2_PACKAGE_HAPROXY
+	bool "haproxy"
+	depends on BR2_PACKAGE_HAPROXY_ARCH_SUPPORTS
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4 # __sync_*_4 intrisics
 	help