| Message ID | 20190205212142.2244-1-patrickdepinguin@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [PATCHv3,1/2] utils/test-pkg: fix long option parsing | expand |
Thomas, All, On 2019-02-05 22:21 +0100, Thomas De Schampheleire spake thusly: > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > > The long option parsing of test-pkg is broken because: > - some long options are not declared > - there should be a comma between long options, the colon does not replace > it. > > This change also revealed that the declaration of 'toolchains-dir' should > have been 'toolchains-csv', originally introduced in commit ed59f81a3cb4ddb. > > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > utils/test-pkg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > v3: unchanged > v2: new patch > > diff --git a/utils/test-pkg b/utils/test-pkg > index 1995fa8578..087f9ddca9 100755 > --- a/utils/test-pkg > +++ b/utils/test-pkg > @@ -5,12 +5,12 @@ TOOLCHAINS_CSV='support/config-fragments/autobuild/toolchain-configs.csv' > > main() { > local o O opts > - local cfg dir pkg random toolchains_dir toolchain all number mode > + local cfg dir pkg random toolchains_csv toolchain all number mode > local ret nb nb_skip nb_fail nb_legal nb_tc build_dir > local -a toolchains > > o='hac:d:n:p:r:t:' > - O='help,config-snippet:build-dir:package:,random:,toolchains-dir:' > + O='help,all,config-snippet:,build-dir:,number:,package:,random:,toolchains-csv:' > opts="$(getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}")" > eval set -- "${opts}" > > -- > 2.19.2 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
On Tue, 5 Feb 2019 22:21:41 +0100 Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > > The long option parsing of test-pkg is broken because: > - some long options are not declared > - there should be a comma between long options, the colon does not replace > it. > > This change also revealed that the declaration of 'toolchains-dir' should > have been 'toolchains-csv', originally introduced in commit ed59f81a3cb4ddb. > > Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > --- > utils/test-pkg | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Both patches applied. Thanks! Thomas
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > Thomas, All, > On 2019-02-05 22:21 +0100, Thomas De Schampheleire spake thusly: >> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> >> >> The long option parsing of test-pkg is broken because: >> - some long options are not declared >> - there should be a comma between long options, the colon does not replace >> it. >> >> This change also revealed that the declaration of 'toolchains-dir' should >> have been 'toolchains-csv', originally introduced in commit ed59f81a3cb4ddb. >> >> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com> > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> Committed to 2019.02.x and 2019.05.x, thanks.
diff --git a/utils/test-pkg b/utils/test-pkg index 1995fa8578..087f9ddca9 100755 --- a/utils/test-pkg +++ b/utils/test-pkg @@ -5,12 +5,12 @@ TOOLCHAINS_CSV='support/config-fragments/autobuild/toolchain-configs.csv' main() { local o O opts - local cfg dir pkg random toolchains_dir toolchain all number mode + local cfg dir pkg random toolchains_csv toolchain all number mode local ret nb nb_skip nb_fail nb_legal nb_tc build_dir local -a toolchains o='hac:d:n:p:r:t:' - O='help,config-snippet:build-dir:package:,random:,toolchains-dir:' + O='help,all,config-snippet:,build-dir:,number:,package:,random:,toolchains-csv:' opts="$(getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}")" eval set -- "${opts}"