| Message ID | 20181215202937.81372-1-aduskett@gmail.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [1/1] dependencies.sh: Check for a host python version >= 2.7 | expand |
Hi Adam, aduskett@gmail.com writes: > From: Adam Duskett <Aduskett@gmail.com> > > Older distributions such as CentOS6 come with python2.6, which causes build > failures in packages such as host-libglib2 because they require python2.7 or > above. Any reference to glib requirements? autobuilder failures? > CentOS6 does have the centos-release-scl which allows users to install > python2.7, making this transition reasonably easy. > > Debian 6 and 7 have reached EOL, and Debian 8 comes with Python 2.7, so > this patch should be relatively low impact. Please update the requirements documentation in a separate patch: https://buildroot.org/downloads/manual/manual.html#requirement-mandatory baruch > Signed-off-by: Adam Duskett <Aduskett@gmail.com> > --- > support/dependencies/dependencies.sh | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh > index 58c34d880f..d0b6bdc23a 100755 > --- a/support/dependencies/dependencies.sh > +++ b/support/dependencies/dependencies.sh > @@ -181,6 +181,14 @@ if test "${missing_progs}" = "yes" ; then > exit 1 > fi > > +# Check that the python version is at least 2.7 > +PYTHON_VERSION=$(python -V 2>&1 |awk '{print $2}') > +if [ $(echo $PYTHON_VERSION |sed -e 's/\.//g') -lt 2700 ]; then > + echo > + echo "You have python '$PYTHON_VERSION' installed. Python >= 2.7 is required" > + exit 1; > +fi > + > if grep ^BR2_NEEDS_HOST_UTF8_LOCALE=y $BR2_CONFIG > /dev/null; then > if ! which locale > /dev/null ; then > echo
Hi Baruch! On Sat, Dec 15, 2018 at 3:42 PM Baruch Siach <baruch@tkos.co.il> wrote: > > Hi Adam, > > aduskett@gmail.com writes: > > From: Adam Duskett <Aduskett@gmail.com> > > > > Older distributions such as CentOS6 come with python2.6, which causes build > > failures in packages such as host-libglib2 because they require python2.7 or > > above. > > Any reference to glib requirements? autobuilder failures? > Not that I can see. I am not sure if any of the autobuilders are using CentOS6, however I noticed the crash when I was using a CentOS6 Docker container and decided to do some due diligence. :) > > CentOS6 does have the centos-release-scl which allows users to install > > python2.7, making this transition reasonably easy. > > > > Debian 6 and 7 have reached EOL, and Debian 8 comes with Python 2.7, so > > this patch should be relatively low impact. > > Please update the requirements documentation in a separate patch: > > https://buildroot.org/downloads/manual/manual.html#requirement-mandatory > Can do! Adam > baruch > > > Signed-off-by: Adam Duskett <Aduskett@gmail.com> > > --- > > support/dependencies/dependencies.sh | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh > > index 58c34d880f..d0b6bdc23a 100755 > > --- a/support/dependencies/dependencies.sh > > +++ b/support/dependencies/dependencies.sh > > @@ -181,6 +181,14 @@ if test "${missing_progs}" = "yes" ; then > > exit 1 > > fi > > > > +# Check that the python version is at least 2.7 > > +PYTHON_VERSION=$(python -V 2>&1 |awk '{print $2}') > > +if [ $(echo $PYTHON_VERSION |sed -e 's/\.//g') -lt 2700 ]; then > > + echo > > + echo "You have python '$PYTHON_VERSION' installed. Python >= 2.7 is required" > > + exit 1; > > +fi > > + > > if grep ^BR2_NEEDS_HOST_UTF8_LOCALE=y $BR2_CONFIG > /dev/null; then > > if ! which locale > /dev/null ; then > > echo > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
Hello, On Sat, 15 Dec 2018 15:47:45 -0500, Adam Duskett wrote: > On Sat, Dec 15, 2018 at 3:42 PM Baruch Siach <baruch@tkos.co.il> wrote: > > > > Hi Adam, > > > > aduskett@gmail.com writes: > > > From: Adam Duskett <Aduskett@gmail.com> > > > > > > Older distributions such as CentOS6 come with python2.6, which causes build > > > failures in packages such as host-libglib2 because they require python2.7 or > > > above. > > > > Any reference to glib requirements? autobuilder failures? > > > Not that I can see. I am not sure if any of the autobuilders are using > CentOS6, however > I noticed the crash when I was using a CentOS6 Docker container and > decided to do some > due diligence. :) Please explain in the commit log which glib version has this requirement, and which specific build failure you got. Thanks, Thomas
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh index 58c34d880f..d0b6bdc23a 100755 --- a/support/dependencies/dependencies.sh +++ b/support/dependencies/dependencies.sh @@ -181,6 +181,14 @@ if test "${missing_progs}" = "yes" ; then exit 1 fi +# Check that the python version is at least 2.7 +PYTHON_VERSION=$(python -V 2>&1 |awk '{print $2}') +if [ $(echo $PYTHON_VERSION |sed -e 's/\.//g') -lt 2700 ]; then + echo + echo "You have python '$PYTHON_VERSION' installed. Python >= 2.7 is required" + exit 1; +fi + if grep ^BR2_NEEDS_HOST_UTF8_LOCALE=y $BR2_CONFIG > /dev/null; then if ! which locale > /dev/null ; then echo