| Message ID | 20180923133759.30626-1-thomas.petazzoni@bootlin.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xlib_libxshmfence: drop AUTORECONF | expand |
Thomas, All, On 2018-09-23 15:37 +0200, Thomas Petazzoni spake thusly: > In commit 2524acd4179fccc627a72ff188bf51c95fed9876 This sha1 does not exist in the official Buildroot tree... However, 2524acd4179fccc627a72ff188bf51c95fed9867 does exist, and its title is indeed the one you quoted... So, I really wonder how you managed to invert just the last two xdigits in that sha1... :-/ Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch > 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but > the corresponding AUTORECONF = YES was not dropped. > > This causes a build issue if just xlib_libxshmfence is built (using > "make xlib_libxshmfence" or using per-package host/target directories): > > >>> xlib_libxshmfence 1.3 Autoreconfiguring > configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen > configure.ac:40: the top level > > This commit fixes that by dropping the no longer needed > AUTORECONF = YES. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk > index f395ebe172..605408fff7 100644 > --- a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk > +++ b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk > @@ -12,7 +12,4 @@ XLIB_LIBXSHMFENCE_LICENSE_FILES = COPYING > XLIB_LIBXSHMFENCE_INSTALL_STAGING = YES > XLIB_LIBXSHMFENCE_DEPENDENCIES = host-pkgconf xorgproto > > -# 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch > -XLIB_LIBXSHMFENCE_AUTORECONF = YES > - > $(eval $(autotools-package)) > -- > 2.14.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Sun, 23 Sep 2018 15:51:06 +0200, Yann E. MORIN wrote: > Thomas, All, > > On 2018-09-23 15:37 +0200, Thomas Petazzoni spake thusly: > > In commit 2524acd4179fccc627a72ff188bf51c95fed9876 > > This sha1 does not exist in the official Buildroot tree... > > However, 2524acd4179fccc627a72ff188bf51c95fed9867 does exist, and its > title is indeed the one you quoted... So, I really wonder how you > managed to invert just the last two xdigits in that sha1... :-/ Gah, it's a Ctrl+T in Emacs, which inverts two characters. > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Thanks for the review and spotting this mistake! Best regards, Thomas
Hello, On Sun, 23 Sep 2018 15:37:59 +0200, Thomas Petazzoni wrote: > In commit 2524acd4179fccc627a72ff188bf51c95fed9876 > ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch > 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but > the corresponding AUTORECONF = YES was not dropped. > > This causes a build issue if just xlib_libxshmfence is built (using > "make xlib_libxshmfence" or using per-package host/target directories): > > >>> xlib_libxshmfence 1.3 Autoreconfiguring > configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen > configure.ac:40: the top level > > This commit fixes that by dropping the no longer needed > AUTORECONF = YES. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 --- > 1 file changed, 3 deletions(-) Applied to master after fixing the reference to the commit, as noticed by Yann. Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > In commit 2524acd4179fccc627a72ff188bf51c95fed9876 > ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch > 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but > the corresponding AUTORECONF = YES was not dropped. > This causes a build issue if just xlib_libxshmfence is built (using > "make xlib_libxshmfence" or using per-package host/target directories): >>>> xlib_libxshmfence 1.3 Autoreconfiguring > configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen > configure.ac:40: the top level > This commit fixes that by dropping the no longer needed > AUTORECONF = YES. > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Committed to 2018.05.x and 2018.08.x, thanks.
diff --git a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk index f395ebe172..605408fff7 100644 --- a/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk +++ b/package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk @@ -12,7 +12,4 @@ XLIB_LIBXSHMFENCE_LICENSE_FILES = COPYING XLIB_LIBXSHMFENCE_INSTALL_STAGING = YES XLIB_LIBXSHMFENCE_DEPENDENCIES = host-pkgconf xorgproto -# 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch -XLIB_LIBXSHMFENCE_AUTORECONF = YES - $(eval $(autotools-package))
In commit 2524acd4179fccc627a72ff188bf51c95fed9876 ("package/x11r7/xlib_libxshmfence: bump version to 1.3"), the patch 0001-configure.ac-call-AC_USE_SYSTEM_EXTENSIONS.patch was dropped, but the corresponding AUTORECONF = YES was not dropped. This causes a build issue if just xlib_libxshmfence is built (using "make xlib_libxshmfence" or using per-package host/target directories): >>> xlib_libxshmfence 1.3 Autoreconfiguring configure.ac:40: error: must install xorg-macros 1.3 or later before running autoconf/autogen configure.ac:40: the top level This commit fixes that by dropping the no longer needed AUTORECONF = YES. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- package/x11r7/xlib_libxshmfence/xlib_libxshmfence.mk | 3 --- 1 file changed, 3 deletions(-)