| Message ID | 20180702123820.32222-1-david.degrave@mind.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] support/dependencies/dependencies.sh: | expand |
Hello, On Mon, 2 Jul 2018 14:38:20 +0200, David De Grave (Essensium/Mind) wrote: > Add the i686 package list to install when using pre-built 32 bits binaries with > a redhat/fedora host distribution (glibc.i686 and zlib.i686). > > Signed-off-by: David De Grave (Essensium/Mind) <david.degrave@mind.be> Thanks, but why your title was cut ? It needs to have the following format: <prefix>: <description> > Remark: The 32 bits libraries are already included in the gcc package contrary "libraries" no, but multilib compiler yes. Patch applied after fixing the commit title. Thanks! Thomas
Hi Thomas, On Mon, Jul 2, 2018 at 10:56 PM, Thomas Petazzoni < thomas.petazzoni@bootlin.com> wrote: Thanks, but why your title was cut ? It needs to have the following > format: > > <prefix>: <description I missed a short description after the "prefix:" ... Will take care of this the next time. Thx. > > Remark: The 32 bits libraries are already included in the gcc package > contrary > > "libraries" no, but multilib compiler yes. > Yes, multilib, that's what I meant :-) > Patch applied after fixing the commit title. Thanks! > No problem. Thanks for the feedback and changes. Regards, David. --- *David De Grave* Senior Embedded Software Developer Gsm : +32(0)496.364.960 | Tel : +32-16-28.65.00 | Fax : +32-16-28a.65.01 Essensium-Mind <http://www.mind.be/> - Gaston Geenslaan 9, B-3001 Leuven, Belgium *>>> Visit our new website:* *https://www.mind.be/ <https://www.mind.be/>** <<<* <div dir="ltr"><div>Hi Thomas,</div><div><br></div><div class="gmail_extra"><div class="gmail_quote">On Mon, Jul 2, 2018 at 10:56 PM, Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span> wrote:</div><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"></span>Thanks, but why your title was cut ? It needs to have the following<br> format:<br> <br> <prefix>: <description</blockquote><div><br></div>I missed a short description after the "prefix:" ... Will take care of this the next time. Thx.<br></div><div> </div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">> Remark: The 32 bits libraries are already included in the gcc package contrary<br> <br> </span>"libraries" no, but multilib compiler yes.<br></blockquote><div><br></div><div>Yes, multilib, that's what I meant :-)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> Patch applied after fixing the commit title. Thanks!<span class="gmail-HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div>No problem. Thanks for the feedback and changes.</div><div><br></div>Regards,<br clear="all"></div>David.</div><div class="gmail_extra"><br></div><div class="gmail_extra">---<br><div class="gmail_signature"><div dir="ltr"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"></span></font><div name="divtagdefaultwrapper"><table style="background-color:white" width="486" height="92" cellspacing="0" cellpadding="0" border="0"><tbody><tr><td style="width:6.9pt;padding:0px" width="11"> <br></td> <td style="width:479.7pt;padding:0px" width="799"> <div style="margin:0px"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"><font color="#17365D"><span lang="en-US"><b>David De Grave</b></span></font></span></font></div> <div style="margin:0px"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"><font color="#17365D"><span lang="en-US">Senior Embedded Software Developer<br> </span></font></span></font></div> <div style="margin:0px"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"><font color="#908F94"><span lang="en-US">Gsm : +32(0)496.364.960 | Tel : +32-16-28.65.00 | Fax : +32-16-28a.65.01 </span></font></span></font></div> <div style="margin:0px"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"><font color="gray"><a href="http://www.mind.be/" target="_blank">Essensium-Mind</a> - Gaston Geenslaan 9, B-3001 Leuven, Belgium</font></span></font></div> <div style="margin:0px"><font size="2" face="Calibri,sans-serif"><span style="font-size:11pt"><font color="gray"><font color="0000FF"><b><font color="FF00FF">>>> </font>Visit our new website:</b></font> <i><font color="3366FF"><a href="https://www.mind.be/" target="_blank">https://www.mind.be/</a></font></i><font color="FF00FF"><b> <<<</b></font><br> </font></span></font></div> </td> </tr> </tbody> </table> <div name="divtagdefaultwrapper"> <span lang="en-US"></span></div> </div> </div></div> </div></div>
>>>>> "David" == David De Grave (Essensium/Mind) <david.degrave@mind.be> writes: > Add the i686 package list to install when using pre-built 32 bits binaries with > a redhat/fedora host distribution (glibc.i686 and zlib.i686). > Signed-off-by: David De Grave (Essensium/Mind) <david.degrave@mind.be> > --- > Remark: The 32 bits libraries are already included in the gcc package contrary > to debian where additionnal packages are needed. So it's not needed to > do something similar for BR2_HOSTARCH_NEEDS_IA32_COMPILER. Committed to 2018.02.x and 2018.05.x, thanks.
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh index e570a9ee1a..58c34d880f 100755 --- a/support/dependencies/dependencies.sh +++ b/support/dependencies/dependencies.sh @@ -222,6 +222,8 @@ if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then echo "If you're running a Debian/Ubuntu distribution, install the libc6-i386," echo "lib32stdc++6, and lib32z1 packages (or alternatively libc6:i386," echo "libstdc++6:i386, and zlib1g:i386)." + echo "If you're running a RedHat/Fedora distribution, install the glibc.i686 and" + echo "zlib.i686 packages." echo "For other distributions, refer to the documentation on how to install the 32 bits" echo "compatibility libraries." exit 1
Add the i686 package list to install when using pre-built 32 bits binaries with a redhat/fedora host distribution (glibc.i686 and zlib.i686). Signed-off-by: David De Grave (Essensium/Mind) <david.degrave@mind.be> --- Remark: The 32 bits libraries are already included in the gcc package contrary to debian where additionnal packages are needed. So it's not needed to do something similar for BR2_HOSTARCH_NEEDS_IA32_COMPILER. --- support/dependencies/dependencies.sh | 2 ++ 1 file changed, 2 insertions(+)