| Message ID | 20180603193126.7582-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] php-amqp: selects openssl | expand |
Hi Fabrice, On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote: > php-amqp needs a rabbitmq-c with openssl support: > https://github.com/pdezwart/php-amqp/issues/310 > > Fixes: > - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/php-amqp/Config.in | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in > index 0aa2021f5a..cf32ec10b2 100644 > --- a/package/php-amqp/Config.in > +++ b/package/php-amqp/Config.in > @@ -1,12 +1,14 @@ > config BR2_PACKAGE_PHP_AMQP > bool "php-amqp" > depends on BR2_PACKAGE_PHP > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS. > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h > select BR2_PACKAGE_RABBITMQ_C > help > Communicate with any AMQP compliant server. > > http://pecl.php.net/package/amqp > > -comment "php-amqp needs a toolchain w/ threads" > - depends on !BR2_TOOLCHAIN_HAS_THREADS > +comment "php-amqp needs a toolchain w/ dynamic library, threads" > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS baruch
Hello, On Sun, 3 Jun 2018 21:31:26 +0200, Fabrice Fontaine wrote: > php-amqp needs a rabbitmq-c with openssl support: > https://github.com/pdezwart/php-amqp/issues/310 We've had php-amqp since October 2016 and the last version bump is from May 2017, i.e a year ago. What has changed that makes php-amqp now require OpenSSL support in rabbitmq-c ? Is this an issue that was always occurring, but we never fixed ? Is it a new issue ? If so, why does it suddenly started to happen ? Thanks! Thomas
Dear Thomas, 2018-06-04 6:59 GMT+02:00 Thomas Petazzoni <thomas.petazzoni@bootlin.com>: > Hello, > > On Sun, 3 Jun 2018 21:31:26 +0200, Fabrice Fontaine wrote: > > php-amqp needs a rabbitmq-c with openssl support: > > https://github.com/pdezwart/php-amqp/issues/310 > > We've had php-amqp since October 2016 and the last version bump is from > May 2017, i.e a year ago. What has changed that makes php-amqp now > require OpenSSL support in rabbitmq-c ? > SSL connection supports in php-amqp was added in 1.8.0beta2: https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e . So it was introduced in buildroot by the bump to version 1.9.0 in May 2017. In autobuilders, we have three errors with php-amqp: http://autobuild.buildroot.net/?reason=php-amqp-1.9.0. The three errors are all related to SSL and the older one is from February 2018 but I suppose that autobuilder results are deleted after some time? > > Is this an issue that was always occurring, but we never fixed ? Is it > a new issue ? If so, why does it suddenly started to happen ? > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com > Best Regards, Fabrice <div dir="ltr">Dear Thomas,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-06-04 6:59 GMT+02:00 Thomas Petazzoni <span dir="ltr"><<a href="mailto:thomas.petazzoni@bootlin.com" target="_blank">thomas.petazzoni@bootlin.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br> <span class="gmail-"><br> On Sun, 3 Jun 2018 21:31:26 +0200, Fabrice Fontaine wrote:<br> > php-amqp needs a rabbitmq-c with openssl support:<br> > <a href="https://github.com/pdezwart/php-amqp/issues/310" rel="noreferrer" target="_blank">https://github.com/pdezwart/<wbr>php-amqp/issues/310</a><br> <br> </span>We've had php-amqp since October 2016 and the last version bump is from<br> May 2017, i.e a year ago. What has changed that makes php-amqp now<br> require OpenSSL support in rabbitmq-c ?<br></blockquote><div>SSL connection supports in php-amqp was added in 1.8.0beta2: <a href="https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e">https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e</a>.<br>So it was introduced in buildroot by the bump to version 1.9.0 in May 2017.<br></div><div>In autobuilders, we have three errors with php-amqp: <a href="http://autobuild.buildroot.net/?reason=php-amqp-1.9.0">http://autobuild.buildroot.net/?reason=php-amqp-1.9.0</a>.<br></div><div>The three errors are all related to SSL and the older one is from February 2018 but I suppose that autobuilder results are deleted after some time?<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Is this an issue that was always occurring, but we never fixed ? Is it<br> a new issue ? If so, why does it suddenly started to happen ? </blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br> Thanks!<br> <span class="gmail-HOEnZb"><font color="#888888"><br> Thomas<br> -- <br> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)<br> Embedded Linux and Kernel engineering<br> <a href="https://bootlin.com" rel="noreferrer" target="_blank">https://bootlin.com</a><br> </font></span></blockquote></div>Best Regards,<br><br></div><div class="gmail_extra">Fabrice<br></div></div>
Dear Baruch, 2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>: > Hi Fabrice, > > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote: > > php-amqp needs a rabbitmq-c with openssl support: > > https://github.com/pdezwart/php-amqp/issues/310 > > > > Fixes: > > - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b4 > 5dcf1fad05 > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > --- > > package/php-amqp/Config.in | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in > > index 0aa2021f5a..cf32ec10b2 100644 > > --- a/package/php-amqp/Config.in > > +++ b/package/php-amqp/Config.in > > @@ -1,12 +1,14 @@ > > config BR2_PACKAGE_PHP_AMQP > > bool "php-amqp" > > depends on BR2_PACKAGE_PHP > > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h > > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS. > This is needed because openssl supports in rabbitmq-c has been disabled in static mode since May 2017: http://patchwork.ozlabs.org/patch/762183. But perhaps it would be better to make all rabbitmq-c depends on !BR2_STATIC_LIBS as suggested by Peter back in May 2017. > > > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c > > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h > > select BR2_PACKAGE_RABBITMQ_C > > help > > Communicate with any AMQP compliant server. > > > > http://pecl.php.net/package/amqp > > > > -comment "php-amqp needs a toolchain w/ threads" > > - depends on !BR2_TOOLCHAIN_HAS_THREADS > > +comment "php-amqp needs a toolchain w/ dynamic library, threads" > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS > > baruch > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U-- > Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > Best Regards, Fabrice <div dir="ltr">Dear Baruch,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-06-04 4:32 GMT+02:00 Baruch Siach <span dir="ltr"><<a href="mailto:baruch@tkos.co.il" target="_blank">baruch@tkos.co.il</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Fabrice,<br> <span class="gmail-"><br> On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:<br> > php-amqp needs a rabbitmq-c with openssl support:<br> > <a href="https://github.com/pdezwart/php-amqp/issues/310" rel="noreferrer" target="_blank">https://github.com/pdezwart/<wbr>php-amqp/issues/310</a><br> > <br> > Fixes:<br> > - <a href="http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05" rel="noreferrer" target="_blank">http://autobuild.buildroot.<wbr>net/results/<wbr>b7c89bbbd0ca1df08dd7cbfc90c7b4<wbr>5dcf1fad05</a><br> > <br> > Signed-off-by: Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com">fontaine.fabrice@gmail.com</a>><br> > ---<br> > package/php-amqp/Config.in | 6 ++++--<br> > 1 file changed, 4 insertions(+), 2 deletions(-)<br> > <br> > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in<br> > index 0aa2021f5a..cf32ec10b2 100644<br> > --- a/package/php-amqp/Config.in<br> > +++ b/package/php-amqp/Config.in<br> > @@ -1,12 +1,14 @@<br> > config BR2_PACKAGE_PHP_AMQP<br> > bool "php-amqp"<br> > depends on BR2_PACKAGE_PHP<br> > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h<br> <br> </span>Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.<br></blockquote><div>This is needed because openssl supports in rabbitmq-c has been disabled in static mode since May 2017: <a href="http://patchwork.ozlabs.org/patch/762183">http://patchwork.ozlabs.org/patch/762183</a>.<br></div><div>But perhaps it would be better to make all rabbitmq-c depends on !BR2_STATIC_LIBS as suggested by Peter back in May 2017. <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div class="gmail-HOEnZb"><div class="gmail-h5"><br> > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c<br> > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h<br> > select BR2_PACKAGE_RABBITMQ_C<br> > help<br> > Communicate with any AMQP compliant server.<br> > <br> > <a href="http://pecl.php.net/package/amqp" rel="noreferrer" target="_blank">http://pecl.php.net/package/<wbr>amqp</a><br> > <br> > -comment "php-amqp needs a toolchain w/ threads"<br> > - depends on !BR2_TOOLCHAIN_HAS_THREADS<br> > +comment "php-amqp needs a toolchain w/ dynamic library, threads"<br> > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS<br> <br> </div></div><span class="gmail-HOEnZb"><font color="#888888">baruch<br> <br> -- <br> <a href="http://baruch.siach.name/blog/" rel="noreferrer" target="_blank">http://baruch.siach.name/blog/</a> ~. .~ Tk Open Systems<br> =}----------------------------<wbr>--------------------ooO--U--<wbr>Ooo------------{=<br> - <a href="mailto:baruch@tkos.co.il">baruch@tkos.co.il</a> - tel: +972.52.368.4656, <a href="http://www.tkos.co.il" rel="noreferrer" target="_blank">http://www.tkos.co.il</a> -<br> </font></span></blockquote></div>Best Regards,<br><br></div><div class="gmail_extra">Fabrice<br></div></div>
Hi Fabrice, On Mon, Jun 04, 2018 at 07:30:37AM +0200, Fabrice Fontaine wrote: > 2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>: > > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote: > > > php-amqp needs a rabbitmq-c with openssl support: > > > https://github.com/pdezwart/php-amqp/issues/310 > > > > > > Fixes: > > > - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b4 > > 5dcf1fad05 > > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > --- > > > package/php-amqp/Config.in | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in > > > index 0aa2021f5a..cf32ec10b2 100644 > > > --- a/package/php-amqp/Config.in > > > +++ b/package/php-amqp/Config.in > > > @@ -1,12 +1,14 @@ > > > config BR2_PACKAGE_PHP_AMQP > > > bool "php-amqp" > > > depends on BR2_PACKAGE_PHP > > > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h > > > > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS. > > > This is needed because openssl supports in rabbitmq-c has been disabled in > static mode since May 2017: http://patchwork.ozlabs.org/patch/762183. > But perhaps it would be better to make all rabbitmq-c depends on > !BR2_STATIC_LIBS as suggested by Peter back in May 2017. Thanks for the explanation. Please add it to the commit log. In addition, it might be good time to check whether openssl detection in cmake has improved since May 2017. baruch > > > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c > > > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h > > > select BR2_PACKAGE_RABBITMQ_C > > > help > > > Communicate with any AMQP compliant server. > > > > > > http://pecl.php.net/package/amqp > > > > > > -comment "php-amqp needs a toolchain w/ threads" > > > - depends on !BR2_TOOLCHAIN_HAS_THREADS > > > +comment "php-amqp needs a toolchain w/ dynamic library, threads" > > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
Hello, On Mon, 4 Jun 2018 07:25:05 +0200, Fabrice Fontaine wrote: > > We've had php-amqp since October 2016 and the last version bump is from > > May 2017, i.e a year ago. What has changed that makes php-amqp now > > require OpenSSL support in rabbitmq-c ? > > > SSL connection supports in php-amqp was added in 1.8.0beta2: > https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e > . > So it was introduced in buildroot by the bump to version 1.9.0 in May 2017. > In autobuilders, we have three errors with php-amqp: > http://autobuild.buildroot.net/?reason=php-amqp-1.9.0. > The three errors are all related to SSL and the older one is from February > 2018 but I suppose that autobuilder results are deleted after some time? No, autobuilder results are never deleted. Except in October 2017, when I had a hard disk crash, and we lost all the autobuilder results that we had back then. But since October 2017, all autobuilder results are there. Strange that this problem did not occur more often. Only 3 times since October 2017. But OK, it happened once in February 2018, once in May 2018 and more recently in June. Best regards, Thomas
Dear Baruch, 2018-06-04 7:43 GMT+02:00 Baruch Siach <baruch@tkos.co.il>: > Hi Fabrice, > > On Mon, Jun 04, 2018 at 07:30:37AM +0200, Fabrice Fontaine wrote: > > 2018-06-04 4:32 GMT+02:00 Baruch Siach <baruch@tkos.co.il>: > > > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote: > > > > php-amqp needs a rabbitmq-c with openssl support: > > > > https://github.com/pdezwart/php-amqp/issues/310 > > > > > > > > Fixes: > > > > - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7c > bfc90c7b4 > > > 5dcf1fad05 > > > > > > > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > > > > --- > > > > package/php-amqp/Config.in | 6 ++++-- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in > > > > index 0aa2021f5a..cf32ec10b2 100644 > > > > --- a/package/php-amqp/Config.in > > > > +++ b/package/php-amqp/Config.in > > > > @@ -1,12 +1,14 @@ > > > > config BR2_PACKAGE_PHP_AMQP > > > > bool "php-amqp" > > > > depends on BR2_PACKAGE_PHP > > > > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h > > > > > > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS. > > > > > This is needed because openssl supports in rabbitmq-c has been disabled > in > > static mode since May 2017: http://patchwork.ozlabs.org/patch/762183. > > But perhaps it would be better to make all rabbitmq-c depends on > > !BR2_STATIC_LIBS as suggested by Peter back in May 2017. > > Thanks for the explanation. Please add it to the commit log. > In addition, it might be good time to check whether openssl detection in > cmake > has improved since May 2017. > Static linking with openssl works with my old cmake (version 3.5.1 released in May 2016). Thomas, the autobuilders results from May 2017 are not available anymore, which version of cmake had an issue? Nevertheless, I also found out that all PHP external extensions already depend on !BR2_STATIC_LIBS (as specified in package/Config.in). So, I will remove this dependency in v2 to keep only the select. > > baruch > > > > > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c > > > > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h > > > > select BR2_PACKAGE_RABBITMQ_C > > > > help > > > > Communicate with any AMQP compliant server. > > > > > > > > http://pecl.php.net/package/amqp > > > > > > > > -comment "php-amqp needs a toolchain w/ threads" > > > > - depends on !BR2_TOOLCHAIN_HAS_THREADS > > > > +comment "php-amqp needs a toolchain w/ dynamic library, threads" > > > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open > Systems > =}------------------------------------------------ooO--U--Oo > o------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > Best Regards, Fabrice <div dir="ltr">Dear Baruch,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-06-04 7:43 GMT+02:00 Baruch Siach <span dir="ltr"><<a href="mailto:baruch@tkos.co.il" target="_blank">baruch@tkos.co.il</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Fabrice,<br> <span><br> On Mon, Jun 04, 2018 at 07:30:37AM +0200, Fabrice Fontaine wrote:<br> > 2018-06-04 4:32 GMT+02:00 Baruch Siach <<a href="mailto:baruch@tkos.co.il" target="_blank">baruch@tkos.co.il</a>>:<br> </span><div><div class="m_-7427849490291293822h5">> > On Sun, Jun 03, 2018 at 09:31:26PM +0200, Fabrice Fontaine wrote:<br> > > > php-amqp needs a rabbitmq-c with openssl support:<br> > > > <a href="https://github.com/pdezwart/php-amqp/issues/310" rel="noreferrer" target="_blank">https://github.com/pdezwart/ph<wbr>p-amqp/issues/310</a><br> > > ><br> > > > Fixes:<br> > > > - <a href="http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b4" rel="noreferrer" target="_blank">http://autobuild.buildroot.net<wbr>/results/b7c89bbbd0ca1df08dd7c<wbr>bfc90c7b4</a><br> > > 5dcf1fad05<br> > > ><br> > > > Signed-off-by: Fabrice Fontaine <<a href="mailto:fontaine.fabrice@gmail.com" target="_blank">fontaine.fabrice@gmail.com</a>><br> > > > ---<br> > > > package/php-amqp/Config.in | 6 ++++--<br> > > > 1 file changed, 4 insertions(+), 2 deletions(-)<br> > > ><br> > > > diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in<br> > > > index 0aa2021f5a..cf32ec10b2 100644<br> > > > --- a/package/php-amqp/Config.in<br> > > > +++ b/package/php-amqp/Config.in<br> > > > @@ -1,12 +1,14 @@<br> > > > config BR2_PACKAGE_PHP_AMQP<br> > > > bool "php-amqp"<br> > > > depends on BR2_PACKAGE_PHP<br> > > > + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h<br> > ><br> > > Why is this needed? rabbitmq-c does not depend on !BR2_STATIC_LIBS.<br> > ><br> > This is needed because openssl supports in rabbitmq-c has been disabled in<br> > static mode since May 2017: <a href="http://patchwork.ozlabs.org/patch/762183" rel="noreferrer" target="_blank">http://patchwork.ozlabs.org/pa<wbr>tch/762183</a>.<br> > But perhaps it would be better to make all rabbitmq-c depends on<br> > !BR2_STATIC_LIBS as suggested by Peter back in May 2017.<br> <br> </div></div>Thanks for the explanation. Please add it to the commit log.<br></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> In addition, it might be good time to check whether openssl detection in cmake <br> has improved since May 2017.<br></blockquote><div>Static linking with openssl works with my old cmake (version 3.5.1 released in May 2016).</div><div>Thomas, the autobuilders results from May 2017 are not available anymore, which version of cmake had an issue?</div><div><br></div><div>Nevertheless, I also found out that all PHP external extensions already depend on !BR2_STATIC_LIBS (as specified in package/Config.in).</div><div>So, I will remove this dependency in v2 to keep only the select.<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <span class="m_-7427849490291293822HOEnZb"><font color="#888888"><br> baruch<br> </font></span><span class="m_-7427849490291293822im m_-7427849490291293822HOEnZb"><br> > > > depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c<br> > > > + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h<br> > > > select BR2_PACKAGE_RABBITMQ_C<br> > > > help<br> > > > Communicate with any AMQP compliant server.<br> > > ><br> > > > <a href="http://pecl.php.net/package/amqp" rel="noreferrer" target="_blank">http://pecl.php.net/package/a<wbr>mqp</a><br> > > ><br> > > > -comment "php-amqp needs a toolchain w/ threads"<br> > > > - depends on !BR2_TOOLCHAIN_HAS_THREADS<br> > > > +comment "php-amqp needs a toolchain w/ dynamic library, threads"<br> > > > + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS<br> <br> </span><div class="m_-7427849490291293822HOEnZb"><div class="m_-7427849490291293822h5">-- <br> <a href="http://baruch.siach.name/blog/" rel="noreferrer" target="_blank">http://baruch.siach.name/<wbr>blog/</a> ~. .~ Tk Open Systems<br> =}----------------------------<wbr>--------------------ooO--U--Oo<wbr>o------------{=<br> - <a href="mailto:baruch@tkos.co.il" target="_blank">baruch@tkos.co.il</a> - tel: +972.52.368.4656, <a href="http://www.tkos.co.il" rel="noreferrer" target="_blank">http://www.tkos.co.il</a> -<br> </div></div></blockquote></div>Best Regards,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Fabrice<br></div></div>
Hello, On Mon, 4 Jun 2018 18:50:53 +0200, Fabrice Fontaine wrote: > Static linking with openssl works with my old cmake (version 3.5.1 released > in May 2016). > Thomas, the autobuilders results from May 2017 are not available anymore, > which version of cmake had an issue? Is this a question for me ? If so, I have absolutely no idea :-) Thomas
On 04-06-18 12:12, Thomas Petazzoni wrote: > Hello, > > On Mon, 4 Jun 2018 07:25:05 +0200, Fabrice Fontaine wrote: > >>> We've had php-amqp since October 2016 and the last version bump is from >>> May 2017, i.e a year ago. What has changed that makes php-amqp now >>> require OpenSSL support in rabbitmq-c ? >>> >> SSL connection supports in php-amqp was added in 1.8.0beta2: >> https://github.com/pdezwart/php-amqp/commit/83defa18d958503a395e928d4669a23041014b2e >> . >> So it was introduced in buildroot by the bump to version 1.9.0 in May 2017. >> In autobuilders, we have three errors with php-amqp: >> http://autobuild.buildroot.net/?reason=php-amqp-1.9.0. >> The three errors are all related to SSL and the older one is from February >> 2018 but I suppose that autobuilder results are deleted after some time? > > No, autobuilder results are never deleted. > > Except in October 2017, when I had a hard disk crash, and we lost all > the autobuilder results that we had back then. But since October 2017, > all autobuilder results are there. > > Strange that this problem did not occur more often. Only 3 times since > October 2017. But OK, it happened once in February 2018, once in May > 2018 and more recently in June. I think that that's because it's very likely that openssl gets selected somehow. And conversely, it's much less likely that php-amqp gets selected (it is only selected if php is already selected, so with the average probably of 15%, that would be only 1 out of 45 builds). Regards, Arnout
diff --git a/package/php-amqp/Config.in b/package/php-amqp/Config.in index 0aa2021f5a..cf32ec10b2 100644 --- a/package/php-amqp/Config.in +++ b/package/php-amqp/Config.in @@ -1,12 +1,14 @@ config BR2_PACKAGE_PHP_AMQP bool "php-amqp" depends on BR2_PACKAGE_PHP + depends on !BR2_STATIC_LIBS # rabbitmq-c: amqp_ssl_socket.h depends on BR2_TOOLCHAIN_HAS_THREADS # rabbitmq-c + select BR2_PACKAGE_OPENSSL # rabbitmq-c: amqp_ssl_socket.h select BR2_PACKAGE_RABBITMQ_C help Communicate with any AMQP compliant server. http://pecl.php.net/package/amqp -comment "php-amqp needs a toolchain w/ threads" - depends on !BR2_TOOLCHAIN_HAS_THREADS +comment "php-amqp needs a toolchain w/ dynamic library, threads" + depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
php-amqp needs a rabbitmq-c with openssl support: https://github.com/pdezwart/php-amqp/issues/310 Fixes: - http://autobuild.buildroot.net/results/b7c89bbbd0ca1df08dd7cbfc90c7b45dcf1fad05 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/php-amqp/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)