| Message ID | 1dc021862b1041c3990d6ce25bb331ca@exitstrategytech.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | package/systemd: set vconsole support option to default y | expand |
Hello David, Thanks for this contribution! On Fri, 4 Jan 2019 21:35:23 +0000, David J. Fogle wrote: > package/systemd: set vconsole support option to default y There is no need to repeat the commit title twice. > Without this support option enabled, systemd does not allow vterm switching, and could possibly lead to user lockout on tty1. > > We prevent these scenarios by enabling the vconsole tool default y, as console login is much more prevalent than not. I am not sure why you say "much more prevalent than not". I would say quite the opposite: in embedded systems, either there is no screen at all, or when there is a screen, it is used to display an end-user application and not a console login. > This allows the option to disable the tool if needed, but as this is a > rare usage, it is better to let a user decide they do *not* need it > than to expect them to know they *do*. I'm a bit unconvinced. What is the size impact of having this option enabled by default ? Also, make sure your commit log is wrapped to 72 characters. Thanks! Thomas
On Fri, 4 Jan 2019 21:35:23 +0000 "David J. Fogle" <Dave@exitstrategytech.com> wrote: > package/systemd: set vconsole support option to default y > > Without this support option enabled, systemd does not allow vterm switching, and could possibly lead to user lockout on tty1. > > We prevent these scenarios by enabling the vconsole tool default y, as console login is much more prevalent than not. This allows the option to disable the tool if needed, but as this is a rare usage, it is better to let a user decide they do *not* need it than to expect them to know they *do*. > > Any serial connections will not be impacted by absence of this tool, as there are no vconsoles on serial. > > Signed-off-by: David Fogle <dave@exitstrategytech.com> > --- > package/systemd/Config.in | 1 + > 1 file changed, 1 insertion(+) Applied to master with the reworked commit message proposed by Yann. Thanks! Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes: > On Fri, 4 Jan 2019 21:35:23 +0000 > "David J. Fogle" <Dave@exitstrategytech.com> wrote: >> package/systemd: set vconsole support option to default y >> >> Without this support option enabled, systemd does not allow vterm >> switching, and could possibly lead to user lockout on tty1. >> >> We prevent these scenarios by enabling the vconsole tool default y, >> as console login is much more prevalent than not. This allows the >> option to disable the tool if needed, but as this is a rare usage, >> it is better to let a user decide they do *not* need it than to >> expect them to know they *do*. >> >> Any serial connections will not be impacted by absence of this tool, as there are no vconsoles on serial. >> >> Signed-off-by: David Fogle <dave@exitstrategytech.com> >> --- >> package/systemd/Config.in | 1 + >> 1 file changed, 1 insertion(+) > Applied to master with the reworked commit message proposed by Yann. > Thanks! Committed to 2018.02.x and 2018.11.x, thanks.
diff --git a/package/systemd/Config.in b/package/systemd/Config.in index 25f322e8f3..920b65db44 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -325,6 +325,7 @@ config BR2_PACKAGE_SYSTEMD_TMPFILES config BR2_PACKAGE_SYSTEMD_VCONSOLE bool "enable vconsole tool" + default y help systemd-vconsole-setup is an early boot service that configures the virtual console font and console keymap.
package/systemd: set vconsole support option to default y Without this support option enabled, systemd does not allow vterm switching, and could possibly lead to user lockout on tty1. We prevent these scenarios by enabling the vconsole tool default y, as console login is much more prevalent than not. This allows the option to disable the tool if needed, but as this is a rare usage, it is better to let a user decide they do *not* need it than to expect them to know they *do*. Any serial connections will not be impacted by absence of this tool, as there are no vconsoles on serial. Signed-off-by: David Fogle <dave@exitstrategytech.com> --- package/systemd/Config.in | 1 + 1 file changed, 1 insertion(+)