diff mbox series

[1/7] support/docker/Dockerfile: new package expect

Message ID 1556555546-9246-2-git-send-email-jugurtha.belkalem@smile.fr
State Superseded
Headers show
Series gitlab Qemu runtime testing | expand

Commit Message

Jugurtha BELKALEM April 29, 2019, 4:32 p.m. UTC
expect package is required for various automation tests.
One use case is to integrate the script from toolchain builder :
https://github.com/bootlin/toolchains-builder/blob/master/build.sh
to check Qemu build states.
expect can be used to launch a qemu machine for a given
architecture (x86, x86_64, mips, arm, sparc, nios2, ..., etc),
send root password,  wait for login and then perform shutdown.

Special note concerning python-pexpect package which can be
used for the same task: After testing the package, We
have noticed that it does not show the automation process
correcly (you may not even see the message welcome to buildroot)
and it is not verbose when errors are encountered.

Signed-off-by: Jugurtha BELKALEM <jugurtha.belkalem@smile.fr>
---
v2: reorder alphabetically
    Remove m68k kernel issue, since we use kernel 4.19 with qemu
    m68k defconfig. The patch fixing the issue was merged in
    kernel 4.17.
---
 support/docker/Dockerfile | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnout Vandecappelle April 29, 2019, 8:49 p.m. UTC | #1
On 29/04/2019 18:32, Jugurtha BELKALEM wrote:
> Special note concerning python-pexpect package which can be
> used for the same task: After testing the package, We
> have noticed that it does not show the automation process
> correcly (you may not even see the message welcome to buildroot)
> and it is not verbose when errors are encountered.

 Could you expand on this a little? We've been using pexpect (both fdpexpect and
pxssh) very successfully for our testing project. Admittedly, we only use
Python3 so maybe that's where the problem is.

 Clearly, for this simple use case it should be acceptable to use tk-expect
(even though I expect hardly anyone under the age of 40 to still know about it
:-). But if we're going to reuse the same approach for other tests as well, we
might benefit from a more powerful and python-integrated package.

 Regards,
 Arnout
diff mbox series

Patch

diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
index 36cd3b2..8dcd3ef 100644
--- a/support/docker/Dockerfile
+++ b/support/docker/Dockerfile
@@ -29,6 +29,7 @@  RUN apt-get install -y --no-install-recommends \
         cmake \
         cpio \
         cvs \
+        expect \
         file \
         g++-multilib \
         git \