diff mbox series

eudev: prevent udev init script nonexistent directory error

Message ID 1521735601-29879-1-git-send-email-joshua.henderson@microchip.com
State Accepted
Commit cbe725d755006e41a71180b5786fa9f52104f518
Headers show
Series eudev: prevent udev init script nonexistent directory error | expand

Commit Message

Joshua Henderson March 22, 2018, 4:20 p.m. UTC
The following error occures in the udev init script because the kernel config
may optionally not include uevent_helper.

/etc/init.d/S10udev: line 47: can't create /proc/sys/kernel/hotplug: nonexistent directory

Work around this by not trying to access the destination if it's not available.

Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
---
 package/eudev/S10udev | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN March 25, 2018, 7:20 p.m. UTC | #1
Joshua, All,

On 2018-03-22 09:20 -0700, Joshua Henderson spake thusly:
> The following error occures in the udev init script because the kernel config
> may optionally not include uevent_helper.
> 
> /etc/init.d/S10udev: line 47: can't create /proc/sys/kernel/hotplug: nonexistent directory
> 
> Work around this by not trying to access the destination if it's not available.
> 
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/eudev/S10udev | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/eudev/S10udev b/package/eudev/S10udev
> index 640fec6..47c715c 100755
> --- a/package/eudev/S10udev
> +++ b/package/eudev/S10udev
> @@ -28,7 +28,7 @@ test -r $UDEV_CONFIG || exit 6
>  case "$1" in
>      start)
>          printf "Populating %s using udev: " "${udev_root:-/dev}"
> -        printf '\000\000\000\000' > /proc/sys/kernel/hotplug
> +        [ -e /proc/sys/kernel/hotplug ] && printf '\000\000\000\000' > /proc/sys/kernel/hotplug
>          $UDEV_BIN -d || { echo "FAIL"; exit 1; }
>          udevadm trigger --type=subsystems --action=add
>          udevadm trigger --type=devices --action=add
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard March 25, 2018, 7:37 p.m. UTC | #2
>>>>> "Joshua" == Joshua Henderson <joshua.henderson@microchip.com> writes:

 > The following error occures in the udev init script because the kernel config
 > may optionally not include uevent_helper.

 > /etc/init.d/S10udev: line 47: can't create /proc/sys/kernel/hotplug: nonexistent directory

 > Work around this by not trying to access the destination if it's not available.

 > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>

Committed, thanks.
Peter Korsgaard April 6, 2018, 4:58 p.m. UTC | #3
>>>>> "Joshua" == Joshua Henderson <joshua.henderson@microchip.com> writes:

 > The following error occures in the udev init script because the kernel config
 > may optionally not include uevent_helper.

 > /etc/init.d/S10udev: line 47: can't create /proc/sys/kernel/hotplug: nonexistent directory

 > Work around this by not trying to access the destination if it's not available.

 > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>

Committed to 2018.02.x, thanks.
diff mbox series

Patch

diff --git a/package/eudev/S10udev b/package/eudev/S10udev
index 640fec6..47c715c 100755
--- a/package/eudev/S10udev
+++ b/package/eudev/S10udev
@@ -28,7 +28,7 @@  test -r $UDEV_CONFIG || exit 6
 case "$1" in
     start)
         printf "Populating %s using udev: " "${udev_root:-/dev}"
-        printf '\000\000\000\000' > /proc/sys/kernel/hotplug
+        [ -e /proc/sys/kernel/hotplug ] && printf '\000\000\000\000' > /proc/sys/kernel/hotplug
         $UDEV_BIN -d || { echo "FAIL"; exit 1; }
         udevadm trigger --type=subsystems --action=add
         udevadm trigger --type=devices --action=add