diff mbox series

[v2,1/3] python-decorator: Update to add host package

Message ID 1521553662-4115-1-git-send-email-jared.bents@rockwellcollins.com
State Superseded
Headers show
Series [v2,1/3] python-decorator: Update to add host package | expand

Commit Message

Jared Bents March 20, 2018, 1:47 p.m. UTC
Update to add host package for python decorator

Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
--
v1 -> v2: No change

---
 package/python-decorator/python-decorator.mk | 3 +++
 1 file changed, 3 insertions(+)

Comments

Yegor Yefremov March 20, 2018, 1:54 p.m. UTC | #1
Hi Jared,

On Tue, Mar 20, 2018 at 2:47 PM, Jared Bents
<jared.bents@rockwellcollins.com> wrote:
> Update to add host package for python decorator
>
> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
> --
> v1 -> v2: No change
>
> ---
>  package/python-decorator/python-decorator.mk | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/package/python-decorator/python-decorator.mk b/package/python-decorator/python-decorator.mk
> index c0c43f6..f97365f 100644
> --- a/package/python-decorator/python-decorator.mk
> +++ b/package/python-decorator/python-decorator.mk
> @@ -7,7 +7,10 @@
>  PYTHON_DECORATOR_VERSION = 4.0.11
>  PYTHON_DECORATOR_SITE = https://pypi.python.org/packages/cc/ac/5a16f1fc0506ff72fcc8fd4e858e3a1c231f224ab79bb7c4c9b2094cc570
>  PYTHON_DECORATOR_SOURCE = decorator-$(PYTHON_DECORATOR_VERSION).tar.gz
> +PYTHON_DECORATOR_DEPENDENCIES = python-setuptools

why do you need this dependency? setup type "setuptools" should be sufficient.

>  PYTHON_DECORATOR_LICENSE = BSD-2-Clause
>  PYTHON_DECORATOR_SETUP_TYPE = setuptools
> +HOST_PYTHON_DECORATOR_DEPENDENCIES = host-python-setuptools

same here (see python-lxml for reference)

Yegor

>
>  $(eval $(python-package))
> +$(eval $(host-python-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Jared Bents March 20, 2018, 2:02 p.m. UTC | #2
Hi Yegor

On Tue, Mar 20, 2018 at 8:54 AM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> Hi Jared,
>
> On Tue, Mar 20, 2018 at 2:47 PM, Jared Bents
> <jared.bents@rockwellcollins.com> wrote:
>> Update to add host package for python decorator
>>
>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>> --
>> v1 -> v2: No change
>>
>> ---
>>  package/python-decorator/python-decorator.mk | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/package/python-decorator/python-decorator.mk b/package/python-decorator/python-decorator.mk
>> index c0c43f6..f97365f 100644
>> --- a/package/python-decorator/python-decorator.mk
>> +++ b/package/python-decorator/python-decorator.mk
>> @@ -7,7 +7,10 @@
>>  PYTHON_DECORATOR_VERSION = 4.0.11
>>  PYTHON_DECORATOR_SITE = https://pypi.python.org/packages/cc/ac/5a16f1fc0506ff72fcc8fd4e858e3a1c231f224ab79bb7c4c9b2094cc570
>>  PYTHON_DECORATOR_SOURCE = decorator-$(PYTHON_DECORATOR_VERSION).tar.gz
>> +PYTHON_DECORATOR_DEPENDENCIES = python-setuptools
>
> why do you need this dependency? setup type "setuptools" should be sufficient.
>

Without this dependency specified, I was getting build errors because
setuptools was not present

>>  PYTHON_DECORATOR_LICENSE = BSD-2-Clause
>>  PYTHON_DECORATOR_SETUP_TYPE = setuptools
>> +HOST_PYTHON_DECORATOR_DEPENDENCIES = host-python-setuptools
>
> same here (see python-lxml for reference)
>

Same as above

> Yegor
>
>>
>>  $(eval $(python-package))
>> +$(eval $(host-python-package))
>> --
>> 1.9.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Jared
Yegor Yefremov March 20, 2018, 2:20 p.m. UTC | #3
On Tue, Mar 20, 2018 at 3:02 PM, Jared Bents
<jared.bents@rockwellcollins.com> wrote:
> Hi Yegor
>
> On Tue, Mar 20, 2018 at 8:54 AM, Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
>> Hi Jared,
>>
>> On Tue, Mar 20, 2018 at 2:47 PM, Jared Bents
>> <jared.bents@rockwellcollins.com> wrote:
>>> Update to add host package for python decorator
>>>
>>> Signed-off-by: Jared Bents <jared.bents@rockwellcollins.com>
>>> --
>>> v1 -> v2: No change
>>>
>>> ---
>>>  package/python-decorator/python-decorator.mk | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/package/python-decorator/python-decorator.mk b/package/python-decorator/python-decorator.mk
>>> index c0c43f6..f97365f 100644
>>> --- a/package/python-decorator/python-decorator.mk
>>> +++ b/package/python-decorator/python-decorator.mk
>>> @@ -7,7 +7,10 @@
>>>  PYTHON_DECORATOR_VERSION = 4.0.11
>>>  PYTHON_DECORATOR_SITE = https://pypi.python.org/packages/cc/ac/5a16f1fc0506ff72fcc8fd4e858e3a1c231f224ab79bb7c4c9b2094cc570
>>>  PYTHON_DECORATOR_SOURCE = decorator-$(PYTHON_DECORATOR_VERSION).tar.gz
>>> +PYTHON_DECORATOR_DEPENDENCIES = python-setuptools
>>
>> why do you need this dependency? setup type "setuptools" should be sufficient.
>>
>
> Without this dependency specified, I was getting build errors because
> setuptools was not present
>
>>>  PYTHON_DECORATOR_LICENSE = BSD-2-Clause
>>>  PYTHON_DECORATOR_SETUP_TYPE = setuptools
>>> +HOST_PYTHON_DECORATOR_DEPENDENCIES = host-python-setuptools
>>
>> same here (see python-lxml for reference)
>>
>
> Same as above

Remove these dependencies and try "make clean && make"

Yegor
diff mbox series

Patch

diff --git a/package/python-decorator/python-decorator.mk b/package/python-decorator/python-decorator.mk
index c0c43f6..f97365f 100644
--- a/package/python-decorator/python-decorator.mk
+++ b/package/python-decorator/python-decorator.mk
@@ -7,7 +7,10 @@ 
 PYTHON_DECORATOR_VERSION = 4.0.11
 PYTHON_DECORATOR_SITE = https://pypi.python.org/packages/cc/ac/5a16f1fc0506ff72fcc8fd4e858e3a1c231f224ab79bb7c4c9b2094cc570
 PYTHON_DECORATOR_SOURCE = decorator-$(PYTHON_DECORATOR_VERSION).tar.gz
+PYTHON_DECORATOR_DEPENDENCIES = python-setuptools
 PYTHON_DECORATOR_LICENSE = BSD-2-Clause
 PYTHON_DECORATOR_SETUP_TYPE = setuptools
+HOST_PYTHON_DECORATOR_DEPENDENCIES = host-python-setuptools
 
 $(eval $(python-package))
+$(eval $(host-python-package))