diff mbox series

package/physfs: needs threads support

Message ID 1516370369-21683-1-git-send-email-romain.naour@smile.fr
State Accepted
Commit 53252f23b7011780daaf8185d8f0e2a7c5609dd9
Headers show
Series package/physfs: needs threads support | expand

Commit Message

Romain Naour Jan. 19, 2018, 1:59 p.m. UTC
When physfs is build for a Linux system the PHYSFS_PLATFORM_POSIX
(which enable code that use pthread_*()) symbol must defined,
so threads support is required.
The physfs build system used by the previous version didn't correctly
set PHYSFS_PLATFORM_POSIX for system without pthread support.

Add pthread dependency.

Fixes:
http://autobuild.buildroot.org/results/75d/75d68ff9da42d61f47d80b463445c12bc51ed1a4

Signed-off-by: Romain Naour <romain.naour@smile.fr>
---
 package/physfs/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard Jan. 27, 2018, 10:21 a.m. UTC | #1
>>>>> "Romain" == Romain Naour <romain.naour@smile.fr> writes:

 > When physfs is build for a Linux system the PHYSFS_PLATFORM_POSIX
 > (which enable code that use pthread_*()) symbol must defined,
 > so threads support is required.
 > The physfs build system used by the previous version didn't correctly
 > set PHYSFS_PLATFORM_POSIX for system without pthread support.

 > Add pthread dependency.

 > Fixes:
 > http://autobuild.buildroot.org/results/75d/75d68ff9da42d61f47d80b463445c12bc51ed1a4

 > Signed-off-by: Romain Naour <romain.naour@smile.fr>

Committed, thanks.
diff mbox series

Patch

diff --git a/package/physfs/Config.in b/package/physfs/Config.in
index dad3ab4..c272d88 100644
--- a/package/physfs/Config.in
+++ b/package/physfs/Config.in
@@ -1,10 +1,11 @@ 
 config BR2_PACKAGE_PHYSFS
 	bool "physfs"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  PhysicsFS; a portable, flexible file i/o abstraction.
 
 	  http://icculus.org/physfs
 
-comment "physfs needs a toolchain w/ C++"
-	depends on !BR2_INSTALL_LIBSTDCPP
+comment "physfs needs a toolchain w/ C++, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS