| Message ID | 1499163849-9884-1-git-send-email-brgl@bgdev.pl |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Bartosz, On Tue, Jul 04, 2017 at 12:24:09PM +0200, Bartosz Golaszewski wrote: > Since version 1.2.0 libzip requires dynamic library capabilities. > > Fixes: http://autobuild.buildroot.net/results/c50/c50ffa5bf565e75333192edc89e2d39044d07f26/ > Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> > --- > package/libzip/Config.in | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/libzip/Config.in b/package/libzip/Config.in > index 54de9e5..0414186 100644 > --- a/package/libzip/Config.in > +++ b/package/libzip/Config.in > @@ -1,8 +1,12 @@ > config BR2_PACKAGE_LIBZIP > bool "libzip" > + depends on !BR2_STATIC_LIBS You need to propagate dependencies to packages that select BR2_PACKAGE_LIBZIP, and their reverse dependencies, recursively. In this case libsigrok, sigrok-cli, and pulseview are affected. baruch > select BR2_PACKAGE_ZLIB > help > C library for reading, creating, and modifying zip archives. This > package also contains zipcmp, ziptorrent and zipmerge utilities. > > http://www.nih.at/libzip/ > + > +comment "libzip needs a toolchain w/ dynamic library" > + depends on BR2_STATIC_LIBS
On 04-07-17 12:48, Baruch Siach wrote: > Hi Bartosz, > > On Tue, Jul 04, 2017 at 12:24:09PM +0200, Bartosz Golaszewski wrote: >> Since version 1.2.0 libzip requires dynamic library capabilities. >> >> Fixes: http://autobuild.buildroot.net/results/c50/c50ffa5bf565e75333192edc89e2d39044d07f26/ >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> >> --- >> package/libzip/Config.in | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/package/libzip/Config.in b/package/libzip/Config.in >> index 54de9e5..0414186 100644 >> --- a/package/libzip/Config.in >> +++ b/package/libzip/Config.in >> @@ -1,8 +1,12 @@ >> config BR2_PACKAGE_LIBZIP >> bool "libzip" >> + depends on !BR2_STATIC_LIBS > > You need to propagate dependencies to packages that select BR2_PACKAGE_LIBZIP, > and their reverse dependencies, recursively. In this case libsigrok, > sigrok-cli, and pulseview are affected. Also, we usually put the reason in a comment, in this case: depends on !BR2_STATIC_LIBS # dlsym() Regards, Arnout > > baruch > >> select BR2_PACKAGE_ZLIB >> help >> C library for reading, creating, and modifying zip archives. This >> package also contains zipcmp, ziptorrent and zipmerge utilities. >> >> http://www.nih.at/libzip/ >> + >> +comment "libzip needs a toolchain w/ dynamic library" >> + depends on BR2_STATIC_LIBS >
diff --git a/package/libzip/Config.in b/package/libzip/Config.in index 54de9e5..0414186 100644 --- a/package/libzip/Config.in +++ b/package/libzip/Config.in @@ -1,8 +1,12 @@ config BR2_PACKAGE_LIBZIP bool "libzip" + depends on !BR2_STATIC_LIBS select BR2_PACKAGE_ZLIB help C library for reading, creating, and modifying zip archives. This package also contains zipcmp, ziptorrent and zipmerge utilities. http://www.nih.at/libzip/ + +comment "libzip needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS
Since version 1.2.0 libzip requires dynamic library capabilities. Fixes: http://autobuild.buildroot.net/results/c50/c50ffa5bf565e75333192edc89e2d39044d07f26/ Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> --- package/libzip/Config.in | 4 ++++ 1 file changed, 4 insertions(+)