| Message ID | 1486542692-26969-1-git-send-email-apalos@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
>>>>> "Ilias" == Ilias Apalodimas <apalos@gmail.com> writes: > Changelog: > - Added keepalived on DEVELOPERS file > - Fix package dependecies as proposed(MMU support) > - Added keepalived.hash Thanks for the update. This changelog should not be part of the git commit, so it should go after the --- line. > +++ b/package/keepalived/keepalived.mk > @@ -0,0 +1,13 @@ > +################################################################################ > +# > +# keepalived > +# > +################################################################################ > + > +KEEPALIVED_VERSION = 1.3.2 > +KEEPALIVED_SITE = http://www.keepalived.org/software > +KEEPALIVED_DEPENDENCIES = popt openssl > +KEEPALIVED_LICENSE = GPLv2+ > +KEEPALIVED_LICENSE_FILES = COPYING > + > +$(eval $(autotools-package)) This looks good, but a quick look at the configure script shows that it uses pkg-config so you should most likely depend on host-pkgconf and there are a number of optional dependencies that we do have in Buildroot (E.G. dbus, glib, ipset, libnl, netsnmp, ..) that should either be enabled/disabled depending on if those packages are enabled or forcefully disabled to ensure reproducable builds. Can you look into that please?
Will do on first chance! Regards Ilias On Wed, Feb 8, 2017 at 4:48 PM, Peter Korsgaard <peter@korsgaard.com> wrote: >>>>>> "Ilias" == Ilias Apalodimas <apalos@gmail.com> writes: > > > Changelog: > > - Added keepalived on DEVELOPERS file > > - Fix package dependecies as proposed(MMU support) > > - Added keepalived.hash > > Thanks for the update. This changelog should not be part of the git > commit, so it should go after the --- line. > > > +++ b/package/keepalived/keepalived.mk > > @@ -0,0 +1,13 @@ > > +################################################################################ > > +# > > +# keepalived > > +# > > +################################################################################ > > + > > +KEEPALIVED_VERSION = 1.3.2 > > +KEEPALIVED_SITE = http://www.keepalived.org/software > > +KEEPALIVED_DEPENDENCIES = popt openssl > > +KEEPALIVED_LICENSE = GPLv2+ > > +KEEPALIVED_LICENSE_FILES = COPYING > > + > > +$(eval $(autotools-package)) > > This looks good, but a quick look at the configure script shows that it > uses pkg-config so you should most likely depend on host-pkgconf and > there are a number of optional dependencies that we do have in Buildroot > (E.G. dbus, glib, ipset, libnl, netsnmp, ..) that should either be > enabled/disabled depending on if those packages are enabled or > forcefully disabled to ensure reproducable builds. > > Can you look into that please? > > -- > Bye, Peter Korsgaard
diff --git a/DEVELOPERS b/DEVELOPERS index b8ccb46..f636f2d 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -765,6 +765,9 @@ F: package/python-rpi-gpio/ N: Ignacy Gawędzki <ignacy.gawedzki@green-communications.fr> F: package/angularjs/ +N: Ilias Apalodimas <apalos@gmail.com> +F: package/keepalived/ + N: James Knight <james.knight@rockwellcollins.com> F: package/atkmm/ F: package/cairomm/ diff --git a/package/Config.in b/package/Config.in index 114a5ad..f0f1dec 100644 --- a/package/Config.in +++ b/package/Config.in @@ -1546,6 +1546,7 @@ menu "Networking applications" source "package/irssi/Config.in" source "package/iw/Config.in" source "package/janus-gateway/Config.in" + source "package/keepalived/Config.in" source "package/kismet/Config.in" source "package/knock/Config.in" source "package/leafnode2/Config.in" diff --git a/package/keepalived/Config.in b/package/keepalived/Config.in new file mode 100644 index 0000000..721eed5 --- /dev/null +++ b/package/keepalived/Config.in @@ -0,0 +1,14 @@ +config BR2_PACKAGE_KEEPALIVED + bool "keepalived" + select BR2_PACKAGE_OPENSSL + select BR2_PACKAGE_POPT + depends on BR2_USE_MMU + help + The main goal of the keepalived project is to add a strong & robust + keepalive facility to the Linux Virtual Server project. + It implements a multilayer TCP/IP stack checks. Keepalived implements + a framework based on three family checks : Layer3, Layer4 & Layer5. + This framework gives the daemon the ability of checking a LVS server + pool states. Keepalived can be sumarize as a LVS driving daemon. + + http://www.keepalived.org/ diff --git a/package/keepalived/keepalived.hash b/package/keepalived/keepalived.hash new file mode 100644 index 0000000..e868587 --- /dev/null +++ b/package/keepalived/keepalived.hash @@ -0,0 +1,3 @@ +# From http://www.keepalived.org/download.html +md5 744025d57c7f065c42fe925b0283897e keepalived-1.3.2.tar.gz +sha1 449f06dfce07e05c1ebd516d0545182e1416f264 keepalived-1.3.2.tar.gz diff --git a/package/keepalived/keepalived.mk b/package/keepalived/keepalived.mk new file mode 100644 index 0000000..4f8a6b2 --- /dev/null +++ b/package/keepalived/keepalived.mk @@ -0,0 +1,13 @@ +################################################################################ +# +# keepalived +# +################################################################################ + +KEEPALIVED_VERSION = 1.3.2 +KEEPALIVED_SITE = http://www.keepalived.org/software +KEEPALIVED_DEPENDENCIES = popt openssl +KEEPALIVED_LICENSE = GPLv2+ +KEEPALIVED_LICENSE_FILES = COPYING + +$(eval $(autotools-package))
Changelog: - Added keepalived on DEVELOPERS file - Fix package dependecies as proposed(MMU support) - Added keepalived.hash Signed-off-by: Ilias Apalodimas <apalos@gmail.com> --- DEVELOPERS | 3 +++ package/Config.in | 1 + package/keepalived/Config.in | 14 ++++++++++++++ package/keepalived/keepalived.hash | 3 +++ package/keepalived/keepalived.mk | 13 +++++++++++++ 5 files changed, 34 insertions(+) create mode 100644 package/keepalived/Config.in create mode 100644 package/keepalived/keepalived.hash create mode 100644 package/keepalived/keepalived.mk