| Message ID | 1457457777-9017-1-git-send-email-peter@korsgaard.com |
|---|---|
| State | Accepted |
| Commit | bdd8362a88428ed1c04fc6f4bbcbf7692b2a2b39 |
| Headers | show |
On 08/03/16 14:22, Peter Korsgaard wrote: > As recently reported on the mailing list: > http://lists.busybox.net/pipermail/buildroot/2016-February/154130.html > > Our configuration options to use sha-256 / sha-512 password encoding do not > work very well with uClibc-ng as our defconfig doesn't enable support for > these encodings, breaking E.G. password login with dropbear. > > Notice that it doesn't break login with the busybox login applet, as we > currently force the use of the internal busybox password handling routines > when sha-256/512 encoding is used. This workaround can afaik now be removed. > > To fix this, enable support for these password encodings in our defconfig. > Do it unconditionally and not based on BR2_TARGET_GENERIC_PASSWD_* so it > also works when a Buildroot toolchain is reused as an external toolchain and > as the support code is quite small (~8KB): > > -rwxr-xr-x 1 peko peko 13360 Mar 7 22:56 output/target/lib/libcrypt-1.0.12.so > -rwxr-xr-x 1 peko peko 21552 Mar 7 23:47 output-sha/target/lib/libcrypt-1.0.12.so > > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar> (this isn't the XX century)
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes: > As recently reported on the mailing list: > http://lists.busybox.net/pipermail/buildroot/2016-February/154130.html > Our configuration options to use sha-256 / sha-512 password encoding do not > work very well with uClibc-ng as our defconfig doesn't enable support for > these encodings, breaking E.G. password login with dropbear. > Notice that it doesn't break login with the busybox login applet, as we > currently force the use of the internal busybox password handling routines > when sha-256/512 encoding is used. This workaround can afaik now be removed. > To fix this, enable support for these password encodings in our defconfig. > Do it unconditionally and not based on BR2_TARGET_GENERIC_PASSWD_* so it > also works when a Buildroot toolchain is reused as an external toolchain and > as the support code is quite small (~8KB): > -rwxr-xr-x 1 peko peko 13360 Mar 7 22:56 output/target/lib/libcrypt-1.0.12.so > -rwxr-xr-x 1 peko peko 21552 Mar 7 23:47 output-sha/target/lib/libcrypt-1.0.12.so > Signed-off-by: Peter Korsgaard <peter@korsgaard.com> Committed, thanks.
diff --git a/package/uclibc/uClibc-ng.config b/package/uclibc/uClibc-ng.config index c17603d..66de5a9 100644 --- a/package/uclibc/uClibc-ng.config +++ b/package/uclibc/uClibc-ng.config @@ -16,6 +16,8 @@ UCLIBC_HAS_PROGRAM_INVOCATION_NAME=y UCLIBC_HAS_GETPT=y UCLIBC_HAS_LIBUTIL=y UCLIBC_HAS_OBSOLETE_BSD_SIGNAL=y +UCLIBC_HAS_SHA256_CRYPT_IMPL=y +UCLIBC_HAS_SHA512_CRYPT_IMPL=y UCLIBC_USE_NETLINK=y UCLIBC_SUPPORT_AI_ADDRCONFIG=y UCLIBC_HAS_RESOLVER_SUPPORT=y
As recently reported on the mailing list: http://lists.busybox.net/pipermail/buildroot/2016-February/154130.html Our configuration options to use sha-256 / sha-512 password encoding do not work very well with uClibc-ng as our defconfig doesn't enable support for these encodings, breaking E.G. password login with dropbear. Notice that it doesn't break login with the busybox login applet, as we currently force the use of the internal busybox password handling routines when sha-256/512 encoding is used. This workaround can afaik now be removed. To fix this, enable support for these password encodings in our defconfig. Do it unconditionally and not based on BR2_TARGET_GENERIC_PASSWD_* so it also works when a Buildroot toolchain is reused as an external toolchain and as the support code is quite small (~8KB): -rwxr-xr-x 1 peko peko 13360 Mar 7 22:56 output/target/lib/libcrypt-1.0.12.so -rwxr-xr-x 1 peko peko 21552 Mar 7 23:47 output-sha/target/lib/libcrypt-1.0.12.so Signed-off-by: Peter Korsgaard <peter@korsgaard.com> --- package/uclibc/uClibc-ng.config | 2 ++ 1 file changed, 2 insertions(+)