diff mbox

[v2,2/3] python-pexpect: new package

Message ID 1449670313-3613-3-git-send-email-viktorin@rehivetech.com
State Changes Requested
Headers show

Commit Message

Jan Viktorin Dec. 9, 2015, 2:11 p.m. UTC
Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
---
 package/Config.in                        |  1 +
 package/python-pexpect/Config.in         | 10 ++++++++++
 package/python-pexpect/python-pexpect.mk | 14 ++++++++++++++
 3 files changed, 25 insertions(+)
 create mode 100644 package/python-pexpect/Config.in
 create mode 100644 package/python-pexpect/python-pexpect.mk

Comments

Yegor Yefremov Dec. 9, 2015, 2:18 p.m. UTC | #1
On Wed, Dec 9, 2015 at 3:11 PM, Jan Viktorin <viktorin@rehivetech.com> wrote:
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  package/Config.in                        |  1 +
>  package/python-pexpect/Config.in         | 10 ++++++++++
>  package/python-pexpect/python-pexpect.mk | 14 ++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 package/python-pexpect/Config.in
>  create mode 100644 package/python-pexpect/python-pexpect.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 69bc347..77a92d2 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -638,6 +638,7 @@ menu "External python modules"
>         source "package/python-networkmanager/Config.in"
>         source "package/python-nfc/Config.in"
>         source "package/python-numpy/Config.in"
> +       source "package/python-pexpect/Config.in"
>         source "package/python-pam/Config.in"
>         source "package/python-posix-ipc/Config.in"
>         source "package/python-protobuf/Config.in"
> diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
> new file mode 100644
> index 0000000..a42aec7
> --- /dev/null
> +++ b/package/python-pexpect/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_PEXPECT
> +       bool "python-pexpect"
> +       depends on BR2_PACKAGE_PYTHON

remove BR2_PACKAGE_PYTHON dependency

> +       select BR2_PACKAGE_PYTHON_PTYPROCESS
> +       help
> +         Pexpect is a pure Python module for spawning child applications; controlling them; and responding to
> +         expected patterns in their output. Pexpect works like Don Libes’ Expect. Pexpect allows your script
> +         to spawn a child application and control it as if a human were typing commands.

Lines must be max. 80 characters long

> +
> +         https://pexpect.readthedocs.org
> diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
> new file mode 100644
> index 0000000..9de7849
> --- /dev/null
> +++ b/package/python-pexpect/python-pexpect.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# python-pexpect
> +#
> +################################################################################
> +
> +PYTHON_PEXPECT_VERSION = 4.0.1
> +PYTHON_PEXPECT_SITE = $(call github,pexpect,pexpect,$(PYTHON_PEXPECT_VERSION))
> +PYTHON_PEXPECT_LICENSE = ISC
> +PYTHON_PEXPECT_LICENSE_FILES = LICENSE
> +PYTHON_PEXPECT_SETUP_TYPE = distutils
> +PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess

is this a run-time or build dependency?

> +
> +$(eval $(python-package))
> --
> 2.6.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Vicente Olivert Riera Dec. 9, 2015, 2:19 p.m. UTC | #2
Dear Jan Viktorin,

On 09/12/15 14:11, Jan Viktorin wrote:
> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> ---
>  package/Config.in                        |  1 +
>  package/python-pexpect/Config.in         | 10 ++++++++++
>  package/python-pexpect/python-pexpect.mk | 14 ++++++++++++++
>  3 files changed, 25 insertions(+)
>  create mode 100644 package/python-pexpect/Config.in
>  create mode 100644 package/python-pexpect/python-pexpect.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 69bc347..77a92d2 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -638,6 +638,7 @@ menu "External python modules"
>  	source "package/python-networkmanager/Config.in"
>  	source "package/python-nfc/Config.in"
>  	source "package/python-numpy/Config.in"
> +	source "package/python-pexpect/Config.in"

This should be alphabetically ordered.

>  	source "package/python-pam/Config.in"
>  	source "package/python-posix-ipc/Config.in"
>  	source "package/python-protobuf/Config.in"
> diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
> new file mode 100644
> index 0000000..a42aec7
> --- /dev/null
> +++ b/package/python-pexpect/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_PYTHON_PEXPECT
> +	bool "python-pexpect"
> +	depends on BR2_PACKAGE_PYTHON
> +	select BR2_PACKAGE_PYTHON_PTYPROCESS
> +	help
> +	  Pexpect is a pure Python module for spawning child applications; controlling them; and responding to
> +	  expected patterns in their output. Pexpect works like Don Libes’ Expect. Pexpect allows your script
> +	  to spawn a child application and control it as if a human were typing commands.

Wrap that line to 72 characters length, taking into account that we
consider a tab as 8 characters wide.

Regards,

Vincent.
Vicente Olivert Riera Dec. 9, 2015, 2:21 p.m. UTC | #3
Hello Yegor and Jan,

On 09/12/15 14:18, Yegor Yefremov wrote:
>> diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
>> new file mode 100644
>> index 0000000..a42aec7
>> --- /dev/null
>> +++ b/package/python-pexpect/Config.in
>> @@ -0,0 +1,10 @@
>> +config BR2_PACKAGE_PYTHON_PEXPECT
>> +       bool "python-pexpect"
>> +       depends on BR2_PACKAGE_PYTHON
> 
> remove BR2_PACKAGE_PYTHON dependency
> 
>> +       select BR2_PACKAGE_PYTHON_PTYPROCESS
>> +       help
>> +         Pexpect is a pure Python module for spawning child applications; controlling them; and responding to
>> +         expected patterns in their output. Pexpect works like Don Libes’ Expect. Pexpect allows your script
>> +         to spawn a child application and control it as if a human were typing commands.
> 
> Lines must be max. 80 characters long

72.

Regards,

Vincent.
Jan Viktorin Dec. 9, 2015, 2:34 p.m. UTC | #4
On Wed, 9 Dec 2015 15:18:40 +0100
Yegor Yefremov <yegorslists@googlemail.com> wrote:

> On Wed, Dec 9, 2015 at 3:11 PM, Jan Viktorin <viktorin@rehivetech.com> wrote:
> > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com>
> > ---
> >  package/Config.in                        |  1 +
> >  package/python-pexpect/Config.in         | 10 ++++++++++
> >  package/python-pexpect/python-pexpect.mk | 14 ++++++++++++++
> >  3 files changed, 25 insertions(+)
> >  create mode 100644 package/python-pexpect/Config.in
> >  create mode 100644 package/python-pexpect/python-pexpect.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index 69bc347..77a92d2 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -638,6 +638,7 @@ menu "External python modules"
> >         source "package/python-networkmanager/Config.in"
> >         source "package/python-nfc/Config.in"
> >         source "package/python-numpy/Config.in"
> > +       source "package/python-pexpect/Config.in"
> >         source "package/python-pam/Config.in"
> >         source "package/python-posix-ipc/Config.in"
> >         source "package/python-protobuf/Config.in"
> > diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
> > new file mode 100644
> > index 0000000..a42aec7
> > --- /dev/null
> > +++ b/package/python-pexpect/Config.in
> > @@ -0,0 +1,10 @@
> > +config BR2_PACKAGE_PYTHON_PEXPECT
> > +       bool "python-pexpect"
> > +       depends on BR2_PACKAGE_PYTHON  
> 
> remove BR2_PACKAGE_PYTHON dependency

OK, fixed for v3.

> 
> > +       select BR2_PACKAGE_PYTHON_PTYPROCESS
> > +       help
> > +         Pexpect is a pure Python module for spawning child applications; controlling them; and responding to
> > +         expected patterns in their output. Pexpect works like Don Libes’ Expect. Pexpect allows your script
> > +         to spawn a child application and control it as if a human were typing commands.  
> 
> Lines must be max. 80 characters long

OK, fixed everywhere... sorry, thanks ;).

> 
> > +
> > +         https://pexpect.readthedocs.org
> > diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
> > new file mode 100644
> > index 0000000..9de7849
> > --- /dev/null
> > +++ b/package/python-pexpect/python-pexpect.mk
> > @@ -0,0 +1,14 @@
> > +################################################################################
> > +#
> > +# python-pexpect
> > +#
> > +################################################################################
> > +
> > +PYTHON_PEXPECT_VERSION = 4.0.1
> > +PYTHON_PEXPECT_SITE = $(call github,pexpect,pexpect,$(PYTHON_PEXPECT_VERSION))
> > +PYTHON_PEXPECT_LICENSE = ISC
> > +PYTHON_PEXPECT_LICENSE_FILES = LICENSE
> > +PYTHON_PEXPECT_SETUP_TYPE = distutils
> > +PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess  
> 
> is this a run-time or build dependency?

This is run-time so I guess to remove this line...

> 
> > +
> > +$(eval $(python-package))
> > --
> > 2.6.3
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 69bc347..77a92d2 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -638,6 +638,7 @@  menu "External python modules"
 	source "package/python-networkmanager/Config.in"
 	source "package/python-nfc/Config.in"
 	source "package/python-numpy/Config.in"
+	source "package/python-pexpect/Config.in"
 	source "package/python-pam/Config.in"
 	source "package/python-posix-ipc/Config.in"
 	source "package/python-protobuf/Config.in"
diff --git a/package/python-pexpect/Config.in b/package/python-pexpect/Config.in
new file mode 100644
index 0000000..a42aec7
--- /dev/null
+++ b/package/python-pexpect/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_PYTHON_PEXPECT
+	bool "python-pexpect"
+	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_PTYPROCESS
+	help
+	  Pexpect is a pure Python module for spawning child applications; controlling them; and responding to
+	  expected patterns in their output. Pexpect works like Don Libes’ Expect. Pexpect allows your script
+	  to spawn a child application and control it as if a human were typing commands.
+
+	  https://pexpect.readthedocs.org
diff --git a/package/python-pexpect/python-pexpect.mk b/package/python-pexpect/python-pexpect.mk
new file mode 100644
index 0000000..9de7849
--- /dev/null
+++ b/package/python-pexpect/python-pexpect.mk
@@ -0,0 +1,14 @@ 
+################################################################################
+#
+# python-pexpect
+#
+################################################################################
+
+PYTHON_PEXPECT_VERSION = 4.0.1
+PYTHON_PEXPECT_SITE = $(call github,pexpect,pexpect,$(PYTHON_PEXPECT_VERSION))
+PYTHON_PEXPECT_LICENSE = ISC
+PYTHON_PEXPECT_LICENSE_FILES = LICENSE
+PYTHON_PEXPECT_SETUP_TYPE = distutils
+PYTHON_PEXPECT_DEPENDENCIES = python-ptyprocess
+
+$(eval $(python-package))