diff mbox

[1/1] qt5base: stop qt stripping installed libraries

Message ID 1401306290-25105-1-git-send-email-will_wagner@carallon.com
State Accepted
Commit 05fb9bd16569bcc07dfc646afe782f4ebf4dd3f1
Headers show

Commit Message

Will Wagner May 28, 2014, 7:44 p.m. UTC 
From: Will Wagner <will_wagner@carallon.com>

By default the 'make install' step for qt5base will strip all the binaries
and libraries when they are stinalled to staging. This hinders debugging
as the libries in staging dir have been stripped and is unnecessary
as buildroot will strip all files on the target

Signed-off-by: Will Wagner <will_wagner@carallon.com>
---
 .../qt5/qt5base/qt5base-0002-mkspecs-files.patch   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Comments

Yann E. MORIN May 28, 2014, 7:54 p.m. UTC | #1 
Will, All,

On 2014-05-28 20:44 +0100, will_wagner@carallon.com spake thusly:
> From: Will Wagner <will_wagner@carallon.com>
> 
> By default the 'make install' step for qt5base will strip all the binaries
> and libraries when they are stinalled to staging. This hinders debugging

stinalled? :-)

> as the libries in staging dir have been stripped and is unnecessary
> as buildroot will strip all files on the target
> 
> Signed-off-by: Will Wagner <will_wagner@carallon.com>

Otherwise, I'm OK with what this change is supposed to do. Not a Qt
expert, so not sure this is the correct way of doing things, so:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  .../qt5/qt5base/qt5base-0002-mkspecs-files.patch   |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
> index 06436b4..6283bbe 100644
> --- a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
> +++ b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
> @@ -14,13 +14,14 @@ Index: b/mkspecs/devices/linux-buildroot-g++/qmake.conf
>  ===================================================================
>  --- /dev/null
>  +++ b/mkspecs/devices/linux-buildroot-g++/qmake.conf
> -@@ -0,0 +1,11 @@
> +@@ -0,0 +1,12 @@
>  +include(../common/linux_device_pre.conf)
>  +
>  +#modifications to gcc-base.conf
>  +QMAKE_CFLAGS           += $${BR_COMPILER_CFLAGS}
>  +QMAKE_CXXFLAGS         += $${BR_COMPILER_CXXFLAGS}
>  +QMAKE_CXXFLAGS_RELEASE += -O3
> ++CONFIG                 += nostrip
>  +
>  +QMAKE_LIBS             += -lrt -lpthread -ldl
>  +
> -- 
> 1.7.2.5
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Mike Zick May 28, 2014, 8:17 p.m. UTC | #2 
On Wed, 28 May 2014 21:54:28 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> > By default the 'make install' step for qt5base will strip all the
> > binaries and libraries when they are stinalled to staging. This
> > hinders debugging  
> 
> stinalled? :-)
>

Coffee cup in right hand.
(LLrr ... rather than rrLL ...)

Mike
diff mbox

Patch

diff --git a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
index 06436b4..6283bbe 100644
--- a/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
+++ b/package/qt5/qt5base/qt5base-0002-mkspecs-files.patch
@@ -14,13 +14,14 @@  Index: b/mkspecs/devices/linux-buildroot-g++/qmake.conf
 ===================================================================
 --- /dev/null
 +++ b/mkspecs/devices/linux-buildroot-g++/qmake.conf
-@@ -0,0 +1,11 @@
+@@ -0,0 +1,12 @@
 +include(../common/linux_device_pre.conf)
 +
 +#modifications to gcc-base.conf
 +QMAKE_CFLAGS           += $${BR_COMPILER_CFLAGS}
 +QMAKE_CXXFLAGS         += $${BR_COMPILER_CXXFLAGS}
 +QMAKE_CXXFLAGS_RELEASE += -O3
++CONFIG                 += nostrip
 +
 +QMAKE_LIBS             += -lrt -lpthread -ldl
 +