diff mbox

support: do not depend on bash

Message ID 1395173848-15759-1-git-send-email-yann.morin.1998@free.fr
State Rejected
Headers show

Commit Message

Yann E. MORIN March 18, 2014, 8:17 p.m. UTC 
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

We do want to work properly whatever the system shell or the
user's login shell are.

The current check is anyway broken, as it only checks if the
user's login shell is bash, not what the system shell is.

Remove the check altogether, since it is unneeded, and broken.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <jacmet@uclibc.org>
Cc: Andrew Barnes <andy@outsideglobe.com>
---
 support/dependencies/dependencies.sh | 7 -------
 1 file changed, 7 deletions(-)

Comments

Peter Korsgaard March 18, 2014, 10:32 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > We do want to work properly whatever the system shell or the
 > user's login shell are.

 > The current check is anyway broken, as it only checks if the
 > user's login shell is bash, not what the system shell is.

 > Remove the check altogether, since it is unneeded, and broken.

But we (currently atleast) do want bash for our own Makefiles (see
toplevel Makefile). I'm not sure we're completely bashism-free (or if it
is worth the trouble to be so).
Yann E. MORIN March 18, 2014, 10:45 p.m. UTC | #2 
Peter, All,

On 2014-03-18 23:32 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>  > We do want to work properly whatever the system shell or the
>  > user's login shell are.
> 
>  > The current check is anyway broken, as it only checks if the
>  > user's login shell is bash, not what the system shell is.
> 
>  > Remove the check altogether, since it is unneeded, and broken.
> 
> But we (currently atleast) do want bash for our own Makefiles (see
> toplevel Makefile). I'm not sure we're completely bashism-free (or if it
> is worth the trouble to be so).

OK, but then the check is jsut borked, since it does not check that basj
is isntalled on the system.

Notes:
  - SHELL is set in the environment by the login shell;
  - if one has bash as login shell, but sub-sequently runs dash, dahs
    does not reset SHELL and does not set it; instead, it uses the value
    that was pre-exisiting in the environment when it was launched.

So, all the current shell tests is whether the user's login shell is bash.

If instead we want to check that we do have bash installed on the
system, we need to fix the test.

As it is now, it is only confusing.

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
index a8261b3..8de1013 100755
--- a/support/dependencies/dependencies.sh
+++ b/support/dependencies/dependencies.sh
@@ -138,13 +138,6 @@  if [ ! -z "$CXXCOMPILER" ] ; then
 	fi
 fi
 
-# Check bash
-if ! $SHELL --version 2>&1 | grep -q '^GNU bash'; then
-	echo
-	echo "You must install 'bash' on your build machine";
-	exit 1;
-fi;
-
 # Check that a few mandatory programs are installed
 missing_progs="no"
 for prog in patch perl tar wget cpio python unzip rsync bc ${DL_TOOLS} ; do