| Message ID | 1385157507.14731.31.camel@bender |
|---|---|
| State | Accepted |
| Commit | e9060f3c18ee8e25e6ad73aa6ff007a58f231f52 |
| Headers | show |
>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: > If glib2 is compiled with the system PCRE instead of the included > copy, then that system PCRE needs to have support for UTF-8 and > Unicode properties enabled. Otherwise you will get such warnings > at run-time: > GLib-CRITICAL **: PCRE library is compiled without UTF8 support > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support > Signed-off-by: Sven Neumann <neumann@teufel.de> Committed to next, thanks.
Hello, On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote: > >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: > > > If glib2 is compiled with the system PCRE instead of the included > > copy, then that system PCRE needs to have support for UTF-8 and > > Unicode properties enabled. Otherwise you will get such warnings > > at run-time: > > > GLib-CRITICAL **: PCRE library is compiled without UTF8 support > > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support > > > Signed-off-by: Sven Neumann <neumann@teufel.de> > > Committed to next, thanks. May I suggest that you also merge this to the stable tree. Otherwise glib2 will be unusable on any system that also has pcre selected (which is for example pulled in by gnutls). Regards, Sven
>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: > Hello, > On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote: >> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: >> >> > If glib2 is compiled with the system PCRE instead of the included >> > copy, then that system PCRE needs to have support for UTF-8 and >> > Unicode properties enabled. Otherwise you will get such warnings >> > at run-time: >> >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 support >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support >> >> > Signed-off-by: Sven Neumann <neumann@teufel.de> >> >> Committed to next, thanks. > May I suggest that you also merge this to the stable tree. Otherwise > glib2 will be unusable on any system that also has pcre selected (which > is for example pulled in by gnutls). Hmm, ok - That wasn't completely clear to me. So even though it's just a warning, this is something critical? When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 also affected? For the future, it is nice if patches that should go to the current release are clearly marked as such.
Hi Peter, On Mo, 2013-11-25 at 10:17 +0100, Peter Korsgaard wrote: > >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: > > > Hello, > > On Fr, 2013-11-22 at 23:33 +0100, Peter Korsgaard wrote: > >> >>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: > >> > >> > If glib2 is compiled with the system PCRE instead of the included > >> > copy, then that system PCRE needs to have support for UTF-8 and > >> > Unicode properties enabled. Otherwise you will get such warnings > >> > at run-time: > >> > >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 support > >> > GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support > >> > >> > Signed-off-by: Sven Neumann <neumann@teufel.de> > >> > >> Committed to next, thanks. > > > May I suggest that you also merge this to the stable tree. Otherwise > > glib2 will be unusable on any system that also has pcre selected (which > > is for example pulled in by gnutls). > > Hmm, ok - That wasn't completely clear to me. So even though it's just a > warning, this is something critical? Any functionality that use GRegex won't work if the system PCRE is not compiled with UTF-8 and UCP support. There might be glib-based applications that won't be affected by this, but there is a good chance that people will run into unexpected problems because of this. > When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 > also affected? As far as I can see this was introduced with commit fe192908a4e: commit fe192908a4e3195b6f724310fe83fadaf18b66e7 Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Date: Sat Mar 9 08:21:30 2013 +0000 libglib2: use system pcre when available Regards, Sven
>>>>> "Sven" == Sven Neumann <neumann@teufel.de> writes: Hi, >> Hmm, ok - That wasn't completely clear to me. So even though it's >> just a warning, this is something critical? > Any functionality that use GRegex won't work if the system PCRE is not > compiled with UTF-8 and UCP support. There might be glib-based > applications that won't be affected by this, but there is a good chance > that people will run into unexpected problems because of this. Ok, thanks for the details. >> When was this introduced? By the 2.36.1 -> 2.36.3 bump or is 2013.08 >> also affected? > As far as I can see this was introduced with commit fe192908a4e: > commit fe192908a4e3195b6f724310fe83fadaf18b66e7 > Author: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Date: Sat Mar 9 08:21:30 2013 +0000 > libglib2: use system pcre when available Ok, so 2013.08 is also affected. We afaik didn't have any bug reports related to this, but I have added the 2 patches for 2013.11 - Thanks.
diff --git a/package/libglib2/Config.in b/package/libglib2/Config.in index db6a950..7cbfea5 100644 --- a/package/libglib2/Config.in +++ b/package/libglib2/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE select BR2_PACKAGE_LIBFFI + select BR2_PACKAGE_PCRE_UCP if BR2_PACKAGE_PCRE select BR2_PACKAGE_ZLIB depends on BR2_USE_WCHAR # gettext depends on BR2_TOOLCHAIN_HAS_THREADS
If glib2 is compiled with the system PCRE instead of the included copy, then that system PCRE needs to have support for UTF-8 and Unicode properties enabled. Otherwise you will get such warnings at run-time: GLib-CRITICAL **: PCRE library is compiled without UTF8 support GLib-CRITICAL **: PCRE library is compiled without UTF8 properties support Signed-off-by: Sven Neumann <neumann@teufel.de> --- package/libglib2/Config.in | 1 + 1 file changed, 1 insertion(+)