diff mbox

connman: disable on avr32

Message ID 1383735672-24550-1-git-send-email-spdawson@gmail.com
State Superseded
Headers show

Commit Message

Simon Dawson Nov. 6, 2013, 11:01 a.m. UTC
From: Simon Dawson <spdawson@gmail.com>

The inotify_init1 syscall is not available on avr32. Fixes build failures
such as the following.

  http://autobuild.buildroot.net/results/0d8/0d8e7bd8bd3f227fabfb0d5feb59a5d316026d3f

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/connman/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas De Schampheleire Nov. 6, 2013, 11:03 a.m. UTC | #1
Hi,

On Wed, Nov 6, 2013 at 12:01 PM,  <spdawson@gmail.com> wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> The inotify_init1 syscall is not available on avr32. Fixes build failures
> such as the following.
>
>   http://autobuild.buildroot.net/results/0d8/0d8e7bd8bd3f227fabfb0d5feb59a5d316026d3f
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  package/connman/Config.in | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/package/connman/Config.in b/package/connman/Config.in
> index c74618a..efb2486 100644
> --- a/package/connman/Config.in
> +++ b/package/connman/Config.in
> @@ -4,6 +4,7 @@ config BR2_PACKAGE_CONNMAN
>         select BR2_PACKAGE_LIBGLIB2
>         select BR2_PACKAGE_IPTABLES
>         select BR2_PACKAGE_GNUTLS
> +       depends on !BR2_avr32 # no inotify_init1
>         depends on !BR2_UCLIBC_VERSION_0_9_32
>         depends on BR2_USE_WCHAR # libglib2 and gnutls
>         depends on BR2_INET_IPV6

This dependency should also be added to the comment, on a separate
'depends on' statement.
(see also my patch in the queue, that I have to rework)
Simon Dawson Nov. 6, 2013, 11:10 a.m. UTC | #2
Thanks for the feedback Thomas.

On 6 November 2013 11:03, Thomas De Schampheleire
<patrickdepinguin@gmail.com> wrote:
> This dependency should also be added to the comment, on a separate
> 'depends on' statement.
> (see also my patch in the queue, that I have to rework)

Okay. I'll fix my patch.

Simon.
diff mbox

Patch

diff --git a/package/connman/Config.in b/package/connman/Config.in
index c74618a..efb2486 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_CONNMAN
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_IPTABLES
 	select BR2_PACKAGE_GNUTLS
+	depends on !BR2_avr32 # no inotify_init1
 	depends on !BR2_UCLIBC_VERSION_0_9_32
 	depends on BR2_USE_WCHAR # libglib2 and gnutls
 	depends on BR2_INET_IPV6