diff mbox

dropbear: add vfork fix

Message ID 1364941788-15890-1-git-send-email-gustavo@zacarias.com.ar
State Accepted
Commit 83800fa2598bf21aaec18f6176ae1cbcea2fa205
Headers show

Commit Message

Gustavo Zacarias April 2, 2013, 10:29 p.m. UTC
Causes scp to fail badly.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/dropbear/dropbear-fix-vfork-logic.patch | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 package/dropbear/dropbear-fix-vfork-logic.patch

Comments

Peter Korsgaard April 3, 2013, 8:47 p.m. UTC | #1
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Causes scp to fail badly.

Committed, thanks.

Do we need the /dev/urandom write fix as well?
Gustavo Zacarias April 3, 2013, 8:48 p.m. UTC | #2
On 04/03/2013 05:47 PM, Peter Korsgaard wrote:

> Do we need the /dev/urandom write fix as well?

I don't think so, we default to 0666 for it in the device table...
Regards.
Peter Korsgaard April 3, 2013, 9 p.m. UTC | #3
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> On 04/03/2013 05:47 PM, Peter Korsgaard wrote:
 >> Do we need the /dev/urandom write fix as well?

 Gustavo> I don't think so, we default to 0666 for it in the device table...
 Gustavo> Regards.

Ok, great.
diff mbox

Patch

diff --git a/package/dropbear/dropbear-fix-vfork-logic.patch b/package/dropbear/dropbear-fix-vfork-logic.patch
new file mode 100644
index 0000000..2706bc8
--- /dev/null
+++ b/package/dropbear/dropbear-fix-vfork-logic.patch
@@ -0,0 +1,21 @@ 
+
+# HG changeset patch
+# User Matt Johnston <matt@ucc.asn.au>
+# Date 1364743743 -28800
+# Node ID fedfb8ede1fdebad5d19df7bd4d452c3264d9545
+# Parent  f27058078d61a8c3a057530d3ddcd19bd5062569
+Fix incorrect logic for USE_VFORK and calling arg_setup()
+
+diff -r f27058078d61 -r fedfb8ede1fd scp.c
+--- a/scp.c	Sun Mar 31 23:15:35 2013 +0800
++++ b/scp.c	Sun Mar 31 23:29:03 2013 +0800
+@@ -230,7 +230,7 @@
+ 		close(pin[0]);
+ 		close(pout[1]);
+ 
+-#ifdef USE_VFORK
++#ifndef USE_VFORK
+ 		arg_setup(host, remuser, cmd);
+ #endif
+ 
+