mbox series

[0/5] support: accept text files with missing terminating \n (branch yem/newlines)

Message ID cover.1710027863.git.yann.morin.1998@free.fr
Headers show
Series support: accept text files with missing terminating \n (branch yem/newlines) | expand

Message

Yann E. MORIN March 9, 2024, 11:44 p.m. UTC 
Hello All!

As explained in the last commit, we expect text files to be properly
terminated with a full line, i.e. one having a final \n.

However, a lot of people do not have proper text editors, and those do
not add the terminating newline, and do not honour our .editorconfig.

This series fixes two of the affected scripts, and also fixes shellcheck
errors in both. Fixing those also uncovered an actual issue in mkusers,
so that too is fixed.

Regards,
Yann E. MORIN.


----------------------------------------------------------------
Yann E. MORIN (5):
      support/scripts/mkusers: fix UID/GID confusion
      support/scripts/mkusers: fix shellcheck errors
      support/scripts/mkusers: accept user tables without terminating \n
      support/download/check-hash: fix shellcheck errors
      support/download/check-hash: accept hash files without terminating \n

 .checkpackageignore         |  2 --
 support/download/check-hash | 11 ++++++++---
 support/scripts/mkusers     | 34 ++++++++++++++++++++++++----------
 3 files changed, 32 insertions(+), 15 deletions(-)

--
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Comments

Yann E. MORIN April 1, 2024, 6:49 p.m. UTC | #1 
All,

On 2024-03-10 00:44 +0100, Yann E. MORIN spake thusly:
> This series fixes two of the affected scripts, and also fixes shellcheck
> errors in both. Fixing those also uncovered an actual issue in mkusers,
> so that too is fixed.
> 
> Yann E. MORIN (5):
>       support/scripts/mkusers: fix UID/GID confusion
>       support/scripts/mkusers: fix shellcheck errors
>       support/download/check-hash: fix shellcheck errors

Those three: applied to master.

>       support/scripts/mkusers: accept user tables without terminating \n
>       support/download/check-hash: accept hash files without terminating \n

Those two: hold for a little while yet...

Regards,
Yann E. MORIN.