| Message ID | 20211030234650.939616-1-giulio.benetti@benettiengineering.com |
|---|---|
| Headers | show |
| Series | configs/olimex_*: fix uboot build failure on gitlab jobs | expand |
Hello, On Sun, 31 Oct 2021 01:46:44 +0200 Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > Giulio Benetti (6): > configs/olimex_a10_olinuxino: uboot 2021.10 needs openssl and python3 > configs/olimex_a13_olinuxino: uboot 2021.10 needs openssl, pylibfdt > and python3 > configs/olimex_a20_olinuxino_lime2: uboot 2021.10 needs openssl > configs/olimex_a20_olinuxino_lime: uboot 2021.10 needs openssl > configs/olimex_a20_olinuxino_micro: uboot 2021.10 needs openssl, > pylibfdt and python3 > configs/olimex_a33_olinuxino: uboot 2021.10 needs openssl and python3 I've applied the entire series, but I changed something: the options in a defconfig are not sorted alphabetically, but they are sorted in their "natural" order in a defconfig (when generated with "make savedefconfig"). Of course, those hand-edited defconfigs, with extra comments, makes using "make savedefconfig" bit less convenient, but still I think we should follow the ordering of option that "make savedefconfig" provides, which is based on the ordering of options in Config.in files. Thanks! Thomas
On 10/31/21 6:42 PM, Thomas Petazzoni wrote: > Hello, > > On Sun, 31 Oct 2021 01:46:44 +0200 > Giulio Benetti <giulio.benetti@benettiengineering.com> wrote: > >> Giulio Benetti (6): >> configs/olimex_a10_olinuxino: uboot 2021.10 needs openssl and python3 >> configs/olimex_a13_olinuxino: uboot 2021.10 needs openssl, pylibfdt >> and python3 >> configs/olimex_a20_olinuxino_lime2: uboot 2021.10 needs openssl >> configs/olimex_a20_olinuxino_lime: uboot 2021.10 needs openssl >> configs/olimex_a20_olinuxino_micro: uboot 2021.10 needs openssl, >> pylibfdt and python3 >> configs/olimex_a33_olinuxino: uboot 2021.10 needs openssl and python3 > > I've applied the entire series, but I changed something: the options in > a defconfig are not sorted alphabetically, but they are sorted in their > "natural" order in a defconfig (when generated with "make > savedefconfig"). > > Of course, those hand-edited defconfigs, with extra comments, makes > using "make savedefconfig" bit less convenient, but still I think we > should follow the ordering of option that "make savedefconfig" > provides, which is based on the ordering of options in Config.in files. Ok, thank you for pointing. Kind regards
Unfortunately before sending the patchset to update Linux and u-boot for almost all Olimex Olinuxino boards I didn't try to build all those boards' defconfigs inside the latest official Buildroot Docker. This lead to build failure in case host doesnd't provide openssl, python3 and pylibfdt. So this patchset fix those build failure and end up uniforming all the BR2_TARGET_UBOOT_NEEDS_* since all are based on sunxi SoCs and share the same board.c. Anyway everything I've added is required. Best regards --- Giulio Benetti Benetti Engineering sas Giulio Benetti (6): configs/olimex_a10_olinuxino: uboot 2021.10 needs openssl and python3 configs/olimex_a13_olinuxino: uboot 2021.10 needs openssl, pylibfdt and python3 configs/olimex_a20_olinuxino_lime2: uboot 2021.10 needs openssl configs/olimex_a20_olinuxino_lime: uboot 2021.10 needs openssl configs/olimex_a20_olinuxino_micro: uboot 2021.10 needs openssl, pylibfdt and python3 configs/olimex_a33_olinuxino: uboot 2021.10 needs openssl and python3 configs/olimex_a10_olinuxino_lime_defconfig | 2 ++ configs/olimex_a13_olinuxino_defconfig | 3 +++ configs/olimex_a20_olinuxino_lime2_defconfig | 3 ++- configs/olimex_a20_olinuxino_lime_defconfig | 3 ++- configs/olimex_a20_olinuxino_micro_defconfig | 3 +++ configs/olimex_a33_olinuxino_defconfig | 2 ++ 6 files changed, 14 insertions(+), 2 deletions(-)